Highlight use of toString() inside string interpolation as redundant #KT-10731 Fixed

idea/testData/inspections/removeToStringInStringTemplate/inspectionData/expected.xml

@@ -0,0 +1,10 @@
+<problems>
+    <problem>
+        <file>test.kt</file>
+        <line>1</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="temp:///src/test.kt" />
+        <problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Remove redundant call to 'toString()' in string template</problem_class>
+        <description>Redundant 'toString()' call in string template</description>
+    </problem>
+</problems>

idea/testData/inspections/removeToStringInStringTemplate/inspectionData/inspections.test

@@ -0,0 +1 @@
+// INSPECTION_CLASS: org.jetbrains.kotlin.idea.inspections.RemoveToStringInStringTemplateInspection

idea/testData/inspections/removeToStringInStringTemplate/test.kt

@@ -0,0 +1 @@
+val z = "a${"b".toString()}"

idea/testData/quickfix/removeToStringInStringTemplate/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.RemoveToStringInStringTemplateInspection

idea/testData/quickfix/removeToStringInStringTemplate/call.kt

@@ -0,0 +1,5 @@
+// "Remove 'toString()' call" "true"
+
+operator fun Any.invoke() = this
+
+fun foo(arg: Any) = "${arg().<caret>toString()}"

idea/testData/quickfix/removeToStringInStringTemplate/call.kt.after

@@ -0,0 +1,5 @@
+// "Remove 'toString()' call" "true"
+
+operator fun Any.invoke() = this
+
+fun foo(arg: Any) = "${arg()}"

idea/testData/quickfix/removeToStringInStringTemplate/name.kt

@@ -0,0 +1,3 @@
+// "Remove 'toString()' call" "true"
+
+fun foo(arg: Any) = "arg = ${arg.<caret>toString()}"

idea/testData/quickfix/removeToStringInStringTemplate/name.kt.after

@@ -0,0 +1,3 @@
+// "Remove 'toString()' call" "true"
+
+fun foo(arg: Any) = "arg = $arg"

idea/testData/quickfix/removeToStringInStringTemplate/nameWithPostfix.kt

@@ -0,0 +1,3 @@
+// "Remove 'toString()' call" "true"
+
+fun foo(arg: Any) = "arg = ${arg.<caret>toString()}xy"

idea/testData/quickfix/removeToStringInStringTemplate/nameWithPostfix.kt.after

@@ -0,0 +1,3 @@
+// "Remove 'toString()' call" "true"
+
+fun foo(arg: Any) = "arg = ${arg}xy"

idea/testData/quickfix/removeToStringInStringTemplate/simple.kt

@@ -0,0 +1,5 @@
+// "Remove 'toString()' call" "true"
+
+fun foo(s: String) = s
+
+fun bar() = foo("a${"b".toString()<caret>}")

idea/testData/quickfix/removeToStringInStringTemplate/simple.kt.after

@@ -0,0 +1,5 @@
+// "Remove 'toString()' call" "true"
+
+fun foo(s: String) = s
+
+fun bar() = foo("a${"b"<caret>}")