azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

String.toBoolean() should be String?.toBoolean() #KT-14119

Browse Source
This commit is contained in:
Abduqodiri Qurbonzoda
2020-02-27 21:08:31 +03:00
parent b8b1dd753c
commit d5c851980c
8 changed files with 38 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/stdlib/jvm/test/io/UseCloseableResourceTest.kt
+1 -4
View File
@@ -5,8 +5,8 @@
package test.io
import test.platformNull
import java.io.*
import java.util.*
import kotlin.test.*
class UseCloseableResourceTest {
@@ -23,9 +23,6 @@ class UseCloseableResourceTest {
assertEquals("World", secondLine)
}
@Suppress("HasPlatformType", "UNCHECKED_CAST") fun <T> platformNull() = Collections.singletonList(null as T).first()
class Resource(val faultyClose: Boolean = false) : Closeable {
var isClosed = false
libraries/stdlib/jvm/test/text/StringJVMTest.kt
+15
View File
@@ -104,4 +104,19 @@ class StringJVMTest {
assertEquals("dzdzdz", "DZdzdz".decapitalize(Locale.US))
assertEquals("dzdzdz", "Dzdzdz".decapitalize(Locale.US))
}
@Test
fun stringToBoolean() {
assertFalse(platformNull<String>().toBoolean())
}
@Test
fun stringEquals() {
assertFalse(platformNull<String>().equals("sample", ignoreCase = false))
assertFalse(platformNull<String>().equals("sample", ignoreCase = true))
assertFalse("sample".equals(platformNull<String>(), ignoreCase = false))
assertFalse("sample".equals(platformNull(), ignoreCase = true))
assertTrue(platformNull<String>().equals(platformNull(), ignoreCase = true))
assertTrue(platformNull<String>().equals(platformNull<String>(), ignoreCase = false))
}
}