[FIR] Add substitution to classifiers processing

This commit is contained in:
simon.ogorodnik
2020-04-09 22:16:54 +03:00
parent cd4a7a25c3
commit d55c6550bb
21 changed files with 80 additions and 60 deletions
@@ -23,6 +23,7 @@ import org.jetbrains.kotlin.fir.java.JavaTypeParameterStack
import org.jetbrains.kotlin.fir.java.declarations.*
import org.jetbrains.kotlin.fir.java.enhancement.*
import org.jetbrains.kotlin.fir.render
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.scopes.jvm.computeJvmDescriptor
import org.jetbrains.kotlin.fir.symbols.CallableId
@@ -76,8 +77,8 @@ class JavaClassEnhancementScope(
return super.processFunctionsByName(name, processor)
}
override fun processClassifiersByName(name: Name, processor: (FirClassifierSymbol<*>) -> Unit) {
useSiteMemberScope.processClassifiersByName(name, processor)
override fun processClassifiersByNameWithSubstitution(name: Name, processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit) {
useSiteMemberScope.processClassifiersByNameWithSubstitution(name, processor)
}
private fun enhance(
@@ -7,6 +7,7 @@ package org.jetbrains.kotlin.fir.scopes.jvm
import org.jetbrains.kotlin.builtins.jvm.JvmBuiltInsSettings
import org.jetbrains.kotlin.fir.declarations.FirRegularClass
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.symbols.impl.FirClassifierSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirFunctionSymbol
@@ -39,8 +40,8 @@ class JvmMappedScope(
declaredMemberScope.processPropertiesByName(name, processor)
}
override fun processClassifiersByName(name: Name, processor: (FirClassifierSymbol<*>) -> Unit) {
declaredMemberScope.processClassifiersByName(name, processor)
override fun processClassifiersByNameWithSubstitution(name: Name, processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit) {
declaredMemberScope.processClassifiersByNameWithSubstitution(name, processor)
}
companion object {
@@ -23,6 +23,7 @@ import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.scopes.ProcessorAction
import org.jetbrains.kotlin.fir.scopes.impl.FirAbstractImportingScope
import org.jetbrains.kotlin.fir.scopes.impl.FirExplicitSimpleImportingScope
import org.jetbrains.kotlin.fir.scopes.processClassifiersByName
import org.jetbrains.kotlin.fir.symbols.AbstractFirBasedSymbol
import org.jetbrains.kotlin.fir.symbols.impl.*
import org.jetbrains.kotlin.fir.types.classId
@@ -14,6 +14,7 @@ import org.jetbrains.kotlin.fir.resolve.constructType
import org.jetbrains.kotlin.fir.resolve.firSymbolProvider
import org.jetbrains.kotlin.fir.scopes.FirIterableScope
import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.scopes.processClassifiersByName
import org.jetbrains.kotlin.fir.symbols.impl.FirClassLikeSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirClassifierSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirTypeParameterSymbol
@@ -135,6 +135,12 @@ data class ChainedSubstitutor(private val first: ConeSubstitutor, private val se
}
}
fun ConeSubstitutor.chain(other: ConeSubstitutor): ConeSubstitutor {
if (this == ConeSubstitutor.Empty) return other
if (other == ConeSubstitutor.Empty) return this
return ChainedSubstitutor(this, other)
}
data class ConeSubstitutorByMap(val substitution: Map<FirTypeParameterSymbol, ConeKotlinType>) : AbstractConeSubstitutor() {
override fun substituteType(type: ConeKotlinType): ConeKotlinType? {
if (type !is ConeTypeParameterType) return null
@@ -6,18 +6,19 @@
package org.jetbrains.kotlin.fir.scopes
import org.jetbrains.kotlin.fir.declarations.FirTypeParameter
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.symbols.impl.FirClassifierSymbol
import org.jetbrains.kotlin.name.Name
abstract class FirTypeParameterScope : FirScope() {
abstract val typeParameters: Map<Name, List<FirTypeParameter>>
override fun processClassifiersByName(
override fun processClassifiersByNameWithSubstitution(
name: Name,
processor: (FirClassifierSymbol<*>) -> Unit
processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit
) {
val matchedTypeParameters = typeParameters[name] ?: return
matchedTypeParameters.forEach { processor(it.symbol) }
matchedTypeParameters.forEach { processor(it.symbol, ConeSubstitutor.Empty) }
}
}
@@ -15,6 +15,7 @@ import org.jetbrains.kotlin.fir.declarations.builder.buildSimpleFunction
import org.jetbrains.kotlin.fir.declarations.impl.FirSimpleFunctionImpl
import org.jetbrains.kotlin.fir.declarations.impl.FirValueParameterImpl
import org.jetbrains.kotlin.fir.expressions.FirExpression
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.scopes.FirOverrideChecker
import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.symbols.impl.*
@@ -118,12 +119,8 @@ abstract class AbstractFirUseSiteMemberScope(
isVararg = parameter.isVararg
}
override fun processClassifiersByName(
name: Name,
processor: (FirClassifierSymbol<*>) -> Unit
) {
declaredMemberScope.processClassifiersByName(name, processor)
superTypesScope.processClassifiersByName(name, processor)
override fun processClassifiersByNameWithSubstitution(name: Name, processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit) {
declaredMemberScope.processClassifiersByNameWithSubstitution(name, processor)
superTypesScope.processClassifiersByNameWithSubstitution(name, processor)
}
}
@@ -10,6 +10,7 @@ import org.jetbrains.kotlin.fir.declarations.FirResolvedImport
import org.jetbrains.kotlin.fir.resolve.FirSymbolProvider
import org.jetbrains.kotlin.fir.resolve.ScopeSession
import org.jetbrains.kotlin.fir.resolve.calls.tower.TowerScopeLevel
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.symbols.impl.FirCallableSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirClassifierSymbol
import org.jetbrains.kotlin.name.ClassId
@@ -22,10 +23,7 @@ abstract class FirAbstractSimpleImportingScope(
protected abstract val simpleImports: Map<Name, List<FirResolvedImport>>
override fun processClassifiersByName(
name: Name,
processor: (FirClassifierSymbol<*>) -> Unit
) {
override fun processClassifiersByNameWithSubstitution(name: Name, processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit) {
val imports = simpleImports[name] ?: return
if (imports.isEmpty()) return
val provider = FirSymbolProvider.getInstance(session)
@@ -35,7 +33,7 @@ abstract class FirAbstractSimpleImportingScope(
import.resolvedClassId?.createNestedClassId(importedName)
?: ClassId.topLevel(import.packageFqName.child(importedName))
val symbol = provider.getClassLikeSymbolByFqName(classId) ?: continue
processor(symbol)
processor(symbol, ConeSubstitutor.Empty)
}
}
@@ -9,6 +9,7 @@ import org.jetbrains.kotlin.fir.FirSession
import org.jetbrains.kotlin.fir.declarations.FirResolvedImport
import org.jetbrains.kotlin.fir.resolve.ScopeSession
import org.jetbrains.kotlin.fir.resolve.calls.tower.TowerScopeLevel
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.symbols.impl.FirCallableSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirClassifierSymbol
import org.jetbrains.kotlin.name.ClassId
@@ -24,10 +25,7 @@ abstract class FirAbstractStarImportingScope(
private val absentClassifierNames = mutableSetOf<Name>()
override fun processClassifiersByName(
name: Name,
processor: (FirClassifierSymbol<*>) -> Unit
) {
override fun processClassifiersByNameWithSubstitution(name: Name, processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit) {
if (starImports.isEmpty() || name in absentClassifierNames) {
return
}
@@ -41,7 +39,7 @@ abstract class FirAbstractStarImportingScope(
}
val symbol = provider.getClassLikeSymbolByFqName(classId) ?: continue
empty = false
processor(symbol)
processor(symbol, ConeSubstitutor.Empty)
}
if (empty) {
absentClassifierNames += name
@@ -7,6 +7,7 @@ package org.jetbrains.kotlin.fir.scopes.impl
import org.jetbrains.kotlin.fir.declarations.*
import org.jetbrains.kotlin.fir.resolve.FirSymbolProvider
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.symbols.impl.FirCallableSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirClassifierSymbol
@@ -62,8 +63,8 @@ class FirClassDeclaredMemberScope(
}
}
override fun processClassifiersByName(
override fun processClassifiersByNameWithSubstitution(
name: Name,
processor: (FirClassifierSymbol<*>) -> Unit
) = nestedClassifierScope.processClassifiersByName(name, processor)
processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit
) = nestedClassifierScope.processClassifiersByNameWithSubstitution(name, processor)
}
@@ -14,6 +14,7 @@ import org.jetbrains.kotlin.fir.declarations.synthetic.buildSyntheticProperty
import org.jetbrains.kotlin.fir.resolve.ScopeSession
import org.jetbrains.kotlin.fir.resolve.substitution.ChainedSubstitutor
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.resolve.substitution.chain
import org.jetbrains.kotlin.fir.resolve.substitution.substitutorByMap
import org.jetbrains.kotlin.fir.resolve.transformers.ReturnTypeCalculator
import org.jetbrains.kotlin.fir.resolve.transformers.ReturnTypeCalculatorForFullBodyResolve
@@ -82,8 +83,10 @@ class FirClassSubstitutionScope(
}
}
override fun processClassifiersByName(name: Name, processor: (FirClassifierSymbol<*>) -> Unit) {
useSiteMemberScope.processClassifiersByName(name, processor)
override fun processClassifiersByNameWithSubstitution(name: Name, processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit) {
useSiteMemberScope.processClassifiersByNameWithSubstitution(name) { symbol, substitutor ->
processor(symbol, substitutor.chain(this.substitutor))
}
}
private val typeCalculator =
@@ -81,9 +81,6 @@ class FirIntegerLiteralTypeScope(private val session: FirSession, val isUnsigned
resolvePhase = FirResolvePhase.BODY_RESOLVE
}
override fun processClassifiersByName(name: Name, processor: (FirClassifierSymbol<*>) -> Unit) {
}
override fun processFunctionsByName(name: Name, processor: (FirFunctionSymbol<*>) -> Unit) {
val symbol = BINARY_OPERATOR_SYMBOLS[name]
@@ -6,6 +6,7 @@
package org.jetbrains.kotlin.fir.scopes.impl
import org.jetbrains.kotlin.fir.resolve.FirSymbolProvider
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.symbols.impl.FirClassifierSymbol
import org.jetbrains.kotlin.name.ClassId
@@ -20,9 +21,9 @@ class FirLazyNestedClassifierScope(
private val symbolProvider: FirSymbolProvider
) : FirScope() {
override fun processClassifiersByName(
override fun processClassifiersByNameWithSubstitution(
name: Name,
processor: (FirClassifierSymbol<*>) -> Unit
processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit
) {
if (name !in existingNames) {
return
@@ -30,6 +31,6 @@ class FirLazyNestedClassifierScope(
val child = classId.createNestedClassId(name)
val symbol = symbolProvider.getClassLikeSymbolByFqName(child) ?: return
processor(symbol)
processor(symbol, ConeSubstitutor.Empty)
}
}
@@ -10,6 +10,7 @@ import kotlinx.collections.immutable.persistentMapOf
import org.jetbrains.kotlin.fir.declarations.*
import org.jetbrains.kotlin.fir.NAME_FOR_BACKING_FIELD
import org.jetbrains.kotlin.fir.resolve.PersistentMultimap
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.symbols.impl.*
import org.jetbrains.kotlin.name.Name
@@ -62,10 +63,10 @@ class FirLocalScope(
}
}
override fun processClassifiersByName(name: Name, processor: (FirClassifierSymbol<*>) -> Unit) {
override fun processClassifiersByNameWithSubstitution(name: Name, processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit) {
val klass = classes[name]
if (klass != null) {
processor(klass)
processor(klass, ConeSubstitutor.Empty)
}
}
}
@@ -7,6 +7,7 @@ package org.jetbrains.kotlin.fir.scopes.impl
import org.jetbrains.kotlin.fir.declarations.FirClass
import org.jetbrains.kotlin.fir.declarations.FirRegularClass
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.symbols.impl.FirClassifierSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirRegularClassSymbol
@@ -24,11 +25,11 @@ class FirNestedClassifierScope(val klass: FirClass<*>) : FirScope() {
result
}
override fun processClassifiersByName(
override fun processClassifiersByNameWithSubstitution(
name: Name,
processor: (FirClassifierSymbol<*>) -> Unit
processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit
) {
val matchedClass = classIndex[name] ?: return
processor(matchedClass)
processor(matchedClass, ConeSubstitutor.Empty)
}
}
@@ -5,12 +5,13 @@
package org.jetbrains.kotlin.fir.scopes.impl
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.symbols.impl.FirClassifierSymbol
import org.jetbrains.kotlin.name.Name
class FirOnlyClassifiersScope(val delegate: FirScope) : FirScope() {
override fun processClassifiersByName(name: Name, processor: (FirClassifierSymbol<*>) -> Unit) {
return delegate.processClassifiersByName(name, processor)
override fun processClassifiersByNameWithSubstitution(name: Name, processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit) {
return delegate.processClassifiersByNameWithSubstitution(name, processor)
}
}
@@ -7,6 +7,7 @@ package org.jetbrains.kotlin.fir.scopes.impl
import org.jetbrains.kotlin.fir.FirSession
import org.jetbrains.kotlin.fir.resolve.FirSymbolProvider
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.symbols.impl.*
import org.jetbrains.kotlin.name.ClassId
@@ -21,9 +22,9 @@ class FirPackageMemberScope(val fqName: FqName, val session: FirSession) : FirSc
private val callableCache = mutableMapOf<Name, List<FirCallableSymbol<*>>>()
override fun processClassifiersByName(
override fun processClassifiersByNameWithSubstitution(
name: Name,
processor: (FirClassifierSymbol<*>) -> Unit
processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit
) {
if (name.asString().isEmpty()) return
@@ -34,7 +35,7 @@ class FirPackageMemberScope(val fqName: FqName, val session: FirSession) : FirSc
}
if (symbol != null) {
processor(symbol)
processor(symbol, ConeSubstitutor.Empty)
}
}
@@ -8,6 +8,7 @@ package org.jetbrains.kotlin.fir.scopes.impl
import org.jetbrains.kotlin.fir.declarations.FirCallableMemberDeclaration
import org.jetbrains.kotlin.fir.declarations.FirSimpleFunction
import org.jetbrains.kotlin.fir.declarations.isStatic
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.symbols.impl.FirClassifierSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirFunctionSymbol
@@ -16,10 +17,8 @@ import org.jetbrains.kotlin.name.Name
class FirStaticScope(private val delegateScope: FirScope) : FirScope() {
override fun processClassifiersByName(name: Name, processor: (FirClassifierSymbol<*>) -> Unit) {
delegateScope.processClassifiersByName(name) {
processor(it)
}
override fun processClassifiersByNameWithSubstitution(name: Name, processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit) {
delegateScope.processClassifiersByNameWithSubstitution(name, processor)
}
override fun processFunctionsByName(
@@ -10,6 +10,7 @@ import org.jetbrains.kotlin.fir.FirSession
import org.jetbrains.kotlin.fir.declarations.FirCallableMemberDeclaration
import org.jetbrains.kotlin.fir.declarations.FirProperty
import org.jetbrains.kotlin.fir.declarations.FirSimpleFunction
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.scopes.FirOverrideChecker
import org.jetbrains.kotlin.fir.scopes.FirScope
import org.jetbrains.kotlin.fir.symbols.impl.*
@@ -214,7 +215,7 @@ class FirSuperTypeScope private constructor(
return result
}
override fun processClassifiersByName(name: Name, processor: (FirClassifierSymbol<*>) -> Unit) {
override fun processClassifiersByNameWithSubstitution(name: Name, processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit) {
if (name in absentClassifiers) {
return
}
@@ -222,11 +223,11 @@ class FirSuperTypeScope private constructor(
val pending = mutableListOf<FirClassifierSymbol<*>>()
var empty = true
for (scope in scopes) {
scope.processClassifiersByName(name) {
scope.processClassifiersByNameWithSubstitution(name) { symbol, substitution ->
empty = false
if (it !in accepted) {
pending += it
processor(it)
if (symbol !in accepted) {
pending += symbol
processor(symbol, substitution)
}
}
accepted += pending
@@ -235,7 +236,7 @@ class FirSuperTypeScope private constructor(
if (empty) {
absentClassifiers += name
}
super.processClassifiersByName(name, processor)
super.processClassifiersByNameWithSubstitution(name, processor)
}
companion object {
@@ -5,6 +5,7 @@
package org.jetbrains.kotlin.fir.scopes
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.symbols.impl.FirClassifierSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirFunctionSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirVariableSymbol
@@ -13,12 +14,12 @@ import org.jetbrains.kotlin.name.Name
abstract class FirIterableScope : FirScope() {
abstract val scopes: Iterable<FirScope>
override fun processClassifiersByName(
override fun processClassifiersByNameWithSubstitution(
name: Name,
processor: (FirClassifierSymbol<*>) -> Unit
processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit
) {
for (scope in scopes) {
scope.processClassifiersByName(name, processor)
scope.processClassifiersByNameWithSubstitution(name, processor)
}
}
@@ -5,15 +5,16 @@
package org.jetbrains.kotlin.fir.scopes
import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
import org.jetbrains.kotlin.fir.symbols.impl.FirClassifierSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirFunctionSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirVariableSymbol
import org.jetbrains.kotlin.name.Name
abstract class FirScope {
open fun processClassifiersByName(
open fun processClassifiersByNameWithSubstitution(
name: Name,
processor: (FirClassifierSymbol<*>) -> Unit
processor: (FirClassifierSymbol<*>, ConeSubstitutor) -> Unit
) {}
open fun processFunctionsByName(
@@ -48,3 +49,11 @@ enum class ProcessorAction {
return this
}
}
inline fun FirScope.processClassifiersByName(
name: Name,
noinline processor: (FirClassifierSymbol<*>) -> Unit
) {
processClassifiersByNameWithSubstitution(name) { symbol, _ -> processor(symbol) }
}