From d554a4234d4b41ff5962fe579dbbe10c5b8a8bcd Mon Sep 17 00:00:00 2001 From: Mikhail Glukhikh Date: Thu, 8 Feb 2018 11:46:46 +0300 Subject: [PATCH] Redundant object type check: fix problem highlighting #KT-22484 Fixed --- .../inspections/RedundantObjectTypeCheckInspection.kt | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/idea/src/org/jetbrains/kotlin/idea/inspections/RedundantObjectTypeCheckInspection.kt b/idea/src/org/jetbrains/kotlin/idea/inspections/RedundantObjectTypeCheckInspection.kt index 6db5f57ef8b..436cff0cba1 100644 --- a/idea/src/org/jetbrains/kotlin/idea/inspections/RedundantObjectTypeCheckInspection.kt +++ b/idea/src/org/jetbrains/kotlin/idea/inspections/RedundantObjectTypeCheckInspection.kt @@ -38,17 +38,14 @@ class RedundantObjectTypeCheckInspection : AbstractKotlinInspection() { super.visitIsExpression(expression) val typeReference = expression.typeReference ?: return if (!typeReference.isObject()) return - registerProblem(expression.operationReference, ReplaceWithEqualityFix(expression.isNegated)) - } - - private fun registerProblem(element: KtElement, quickFix: LocalQuickFix) { holder.registerProblem( - element, - TextRange(0, 2), + expression.operationReference, + TextRange(0, if (expression.isNegated) 3 else 2), "Redundant type checks for object", - quickFix + ReplaceWithEqualityFix(expression.isNegated) ) } + } } }