Fix ReplaceWithOperatorAssignmentIntention in some cases

#KT-7831 Fixed

idea/src/org/jetbrains/kotlin/idea/intentions/ReplaceWithOperatorAssignmentIntention.kt

@@ -17,6 +17,7 @@
 package org.jetbrains.kotlin.idea.intentions
 
 import com.intellij.openapi.editor.Editor
+import com.intellij.psi.tree.IElementType
 import org.jetbrains.kotlin.builtins.KotlinBuiltIns
 import org.jetbrains.kotlin.descriptors.ClassDescriptor
 import org.jetbrains.kotlin.idea.caches.resolve.analyze
@@ -49,17 +50,20 @@ public class ReplaceWithOperatorAssignmentIntention : JetSelfTargetingOffsetInde
         val operationToken = expression.getOperationToken()
         setText("Replace with ${expression.getOperationReference().getText()}= expression")
 
+        val expressionLeft = expression.getLeft()
+        val expressionRight = expression.getRight()
         return when {
-            variableExpression.matches(expression.getLeft()) -> {
+            variableExpression.matches(expressionLeft) -> {
-                operationToken == JetTokens.PLUS || operationToken == JetTokens.MINUS || operationToken == JetTokens.MUL || operationToken == JetTokens.DIV || operationToken == JetTokens.PERC
+                isArithmeticOperation(operationToken)
             }
 
-            variableExpression.matches(expression.getRight()) -> {
+            variableExpression.matches(expressionRight) -> {
-                isPrimitiveOperation && (operationToken == JetTokens.PLUS || operationToken == JetTokens.MUL)
+                isPrimitiveOperation && isCommutative(operationToken)
             }
 
-            expression.getLeft() is JetBinaryExpression -> {
+            expressionLeft is JetBinaryExpression -> {
-                isPrimitiveOperation && checkExpressionRepeat(variableExpression, expression.getLeft() as JetBinaryExpression)
+                val sameCommutativeOperation = expressionLeft.getOperationToken() == operationToken && isCommutative(operationToken)
+                isPrimitiveOperation && sameCommutativeOperation && checkExpressionRepeat(variableExpression, expressionLeft)
             }
 
             else -> {
@@ -68,6 +72,13 @@ public class ReplaceWithOperatorAssignmentIntention : JetSelfTargetingOffsetInde
         }
     }
 
+    private fun isCommutative(operationToken: IElementType) = operationToken == JetTokens.PLUS || operationToken == JetTokens.MUL
+    private fun isArithmeticOperation(operationToken: IElementType) = operationToken == JetTokens.PLUS ||
+                                                                       operationToken == JetTokens.MINUS ||
+                                                                       operationToken == JetTokens.MUL ||
+                                                                       operationToken == JetTokens.DIV ||
+                                                                       operationToken == JetTokens.PERC
+
     override fun applyTo(element: JetBinaryExpression, editor: Editor) {
         val replacement = buildOperatorAssignmentText(
                 element.getLeft() as JetSimpleNameExpression,

idea/testData/intentions/replaceWithOperatorAssignment/illegalMultipleOperators.kt

@@ -1,5 +1,5 @@
 // IS_APPLICABLE: false
 fun foo() {
     var x = 0
-    x = x / 1 + 1
+    x =<caret> x / 1 + 1
 }

idea/testData/intentions/replaceWithOperatorAssignment/illegalMultipleOperatorsMiddle.kt

@@ -2,5 +2,5 @@
 fun foo() {
     var x = 0
     val y = 0
-    x = y / x + 0
+    x =<caret> y / x + 0
 }

idea/testData/intentions/replaceWithOperatorAssignment/nonCommutativeRepeat.kt

@@ -0,0 +1,5 @@
+// IS_APPLICABLE: false
+fun foo() {
+    var x = 0
+    x =<caret> x - 1 - 1
+}

idea/tests/org/jetbrains/kotlin/idea/intentions/IntentionTestGenerated.java

@@ -6059,6 +6059,12 @@ public class IntentionTestGenerated extends AbstractIntentionTest {
             doTest(fileName);
         }
 
+        @TestMetadata("nonCommutativeRepeat.kt")
+        public void testNonCommutativeRepeat() throws Exception {
+            String fileName = JetTestUtils.navigationMetadata("idea/testData/intentions/replaceWithOperatorAssignment/nonCommutativeRepeat.kt");
+            doTest(fileName);
+        }
+
         @TestMetadata("nonRepeatingAssignment.kt")
         public void testNonRepeatingAssignment() throws Exception {
             String fileName = JetTestUtils.navigationMetadata("idea/testData/intentions/replaceWithOperatorAssignment/nonRepeatingAssignment.kt");