FIR: remove default parameter values from FirJvmSessionFactory
Most of them are passed at all call sites anyway. Having default values makes it easy to forget to pass some meaningful argument (especially `LanguageVersionSettingsImpl.DEFAULT` seems scary), and complicates refactoring.
This commit is contained in:
committed by
Space Team
parent
bacb2f0d15
commit
d475371394
+6
-3
@@ -85,7 +85,7 @@ open class FirFrontendFacade(
|
||||
}
|
||||
}
|
||||
|
||||
fun registerExtraComponents(session: FirSession) {
|
||||
private fun registerExtraComponents(session: FirSession) {
|
||||
testServices.firSessionComponentRegistrar?.registerAdditionalComponent(session)
|
||||
}
|
||||
|
||||
@@ -214,7 +214,7 @@ open class FirFrontendFacade(
|
||||
projectFileSearchScope,
|
||||
packagePartProvider,
|
||||
languageVersionSettings,
|
||||
predefinedJavaComponents = predefinedJavaComponents,
|
||||
predefinedJavaComponents,
|
||||
registerExtraComponents = ::registerExtraComponents,
|
||||
)
|
||||
}
|
||||
@@ -367,7 +367,10 @@ open class FirFrontendFacade(
|
||||
createIncrementalCompilationSymbolProviders = { null },
|
||||
extensionRegistrars,
|
||||
languageVersionSettings,
|
||||
predefinedJavaComponents = predefinedJavaComponents,
|
||||
lookupTracker = null,
|
||||
enumWhenTracker = null,
|
||||
importTracker = null,
|
||||
predefinedJavaComponents,
|
||||
needRegisterJavaElementFinder = true,
|
||||
registerExtraComponents = ::registerExtraComponents,
|
||||
init = sessionConfigurator,
|
||||
|
||||
Reference in New Issue
Block a user