From d4485bc47545fa084a94a9377c51d748d55fee16 Mon Sep 17 00:00:00 2001 From: pyos Date: Thu, 27 May 2021 14:52:02 +0200 Subject: [PATCH] JVM: remove unused methodOwner from InlineCodegen --- .../org/jetbrains/kotlin/codegen/ExpressionCodegen.java | 8 +++----- .../org/jetbrains/kotlin/codegen/inline/InlineCodegen.kt | 1 - .../jetbrains/kotlin/codegen/inline/PsiInlineCodegen.kt | 6 +++--- .../kotlin/backend/jvm/codegen/ExpressionCodegen.kt | 3 +-- .../kotlin/backend/jvm/codegen/IrInlineCodegen.kt | 3 +-- 5 files changed, 8 insertions(+), 13 deletions(-) diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/ExpressionCodegen.java b/compiler/backend/src/org/jetbrains/kotlin/codegen/ExpressionCodegen.java index 590d7f182ea..8a7554a08fb 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/ExpressionCodegen.java +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/ExpressionCodegen.java @@ -2967,13 +2967,11 @@ public class ExpressionCodegen extends KtVisitor impleme typeMapper.setUseOldManglingRulesForFunctionAcceptingInlineClass(false); } } - Type methodOwner = typeMapper.mapImplementationOwner(functionDescriptor); if (isDefaultCompilation) { return new InlineCodegenForDefaultBody(functionDescriptor, this, state, signature, sourceCompiler); - } - else { - return new PsiInlineCodegen(this, state, functionDescriptor, methodOwner, signature, typeParameterMappings, sourceCompiler, - typeMapper.mapOwner(descriptor)); + } else { + return new PsiInlineCodegen(this, state, functionDescriptor, signature, typeParameterMappings, sourceCompiler, + typeMapper.mapImplementationOwner(functionDescriptor), typeMapper.mapOwner(descriptor)); } } diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/InlineCodegen.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/InlineCodegen.kt index 9c093b6c20a..ccd38bba087 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/InlineCodegen.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/InlineCodegen.kt @@ -36,7 +36,6 @@ abstract class InlineCodegen( protected val codegen: T, protected val state: GenerationState, protected val functionDescriptor: FunctionDescriptor, - protected val methodOwner: Type, protected val jvmSignature: JvmMethodSignature, private val typeParameterMappings: TypeParameterMappings<*>, protected val sourceCompiler: SourceCompilerForInline, diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/PsiInlineCodegen.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/PsiInlineCodegen.kt index d7e43fa077d..217d48ff474 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/PsiInlineCodegen.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/PsiInlineCodegen.kt @@ -40,13 +40,13 @@ class PsiInlineCodegen( codegen: ExpressionCodegen, state: GenerationState, function: FunctionDescriptor, - methodOwner: Type, signature: JvmMethodSignature, typeParameterMappings: TypeParameterMappings, sourceCompiler: SourceCompilerForInline, - private val actualDispatchReceiver: Type = methodOwner + private val methodOwner: Type, + private val actualDispatchReceiver: Type ) : InlineCodegen( - codegen, state, function, methodOwner, signature, typeParameterMappings, sourceCompiler, + codegen, state, function, signature, typeParameterMappings, sourceCompiler, ReifiedTypeInliner( typeParameterMappings, PsiInlineIntrinsicsSupport(state), codegen.typeSystem, state.languageVersionSettings, state.unifiedNullChecks diff --git a/compiler/ir/backend.jvm/src/org/jetbrains/kotlin/backend/jvm/codegen/ExpressionCodegen.kt b/compiler/ir/backend.jvm/src/org/jetbrains/kotlin/backend/jvm/codegen/ExpressionCodegen.kt index e6da942d7f8..67596f49b1c 100644 --- a/compiler/ir/backend.jvm/src/org/jetbrains/kotlin/backend/jvm/codegen/ExpressionCodegen.kt +++ b/compiler/ir/backend.jvm/src/org/jetbrains/kotlin/backend/jvm/codegen/ExpressionCodegen.kt @@ -1403,7 +1403,6 @@ class ExpressionCodegen( } } - val methodOwner = typeMapper.mapClass(callee.parentAsClass) val sourceCompiler = IrSourceCompilerForInline(state, element, callee, this, data) val reifiedTypeInliner = ReifiedTypeInliner( @@ -1414,7 +1413,7 @@ class ExpressionCodegen( state.unifiedNullChecks, ) - return IrInlineCodegen(this, state, callee, methodOwner, signature, mappings, sourceCompiler, reifiedTypeInliner) + return IrInlineCodegen(this, state, callee, signature, mappings, sourceCompiler, reifiedTypeInliner) } override fun consumeReifiedOperationMarker(typeParameter: TypeParameterMarker) { diff --git a/compiler/ir/backend.jvm/src/org/jetbrains/kotlin/backend/jvm/codegen/IrInlineCodegen.kt b/compiler/ir/backend.jvm/src/org/jetbrains/kotlin/backend/jvm/codegen/IrInlineCodegen.kt index e9d7f3621f5..44ef6abcc42 100644 --- a/compiler/ir/backend.jvm/src/org/jetbrains/kotlin/backend/jvm/codegen/IrInlineCodegen.kt +++ b/compiler/ir/backend.jvm/src/org/jetbrains/kotlin/backend/jvm/codegen/IrInlineCodegen.kt @@ -36,14 +36,13 @@ class IrInlineCodegen( codegen: ExpressionCodegen, state: GenerationState, private val function: IrFunction, - methodOwner: Type, signature: JvmMethodSignature, typeParameterMappings: TypeParameterMappings, sourceCompiler: SourceCompilerForInline, reifiedTypeInliner: ReifiedTypeInliner ) : InlineCodegen( - codegen, state, function.toIrBasedDescriptor(), methodOwner, signature, typeParameterMappings, sourceCompiler, reifiedTypeInliner + codegen, state, function.toIrBasedDescriptor(), signature, typeParameterMappings, sourceCompiler, reifiedTypeInliner ), IrInlineCallGenerator {