From d415ca9cf6332b81da97504d386775c52300aa63 Mon Sep 17 00:00:00 2001 From: Nicolay Mitropolsky Date: Fri, 31 Aug 2018 17:00:02 +0300 Subject: [PATCH] fixed nullability for various listeners update in 183 --- .../intention/KotlinAndroidAddStringResource.kt | 11 ++++++++--- .../KotlinSetupEnvironmentNotificationProvider.kt | 2 +- .../ui/KotlinConfigurationCheckerComponent.kt | 2 +- ...UnsupportedAbiVersionNotificationPanelProvider.kt | 2 +- .../macro/AnonymousTemplateEditingListener.kt | 2 +- .../kotlin/idea/editor/BatchTemplateRunner.kt | 2 +- .../idea/facet/KotlinFacetSettingsProviderImpl.kt | 2 +- .../framework/LibraryEffectiveKindProviderImpl.kt | 2 +- .../ConvertCamelCaseTestFunctionToSpacedIntention.kt | 4 ++-- .../ConvertReceiverToParameterIntention.kt | 2 +- .../intentions/SpecifyTypeExplicitlyIntention.kt | 2 +- .../intentions/DoubleBangToIfThenIntention.kt | 2 +- .../idea/quickfix/MapPlatformClassToKotlinFix.kt | 2 +- .../callableBuilder/CallableBuilder.kt | 2 +- .../kotlin/idea/refactoring/elementSelectionUtils.kt | 2 +- .../extractClass/ExtractSuperRefactoring.kt | 12 ++++++------ .../KotlinIntroduceVariableHandler.kt | 2 +- .../kotlin/idea/refactoring/kotlinRefactoringUtil.kt | 2 +- .../move/changePackage/ChangePackageIntention.kt | 4 ++-- .../idea/refactoring/pullUp/KotlinPullUpDialog.kt | 9 +++++---- .../idea/script/scriptsTemplatesFromDependencies.kt | 2 +- 21 files changed, 39 insertions(+), 33 deletions(-) diff --git a/idea/idea-android/src/org/jetbrains/kotlin/android/intention/KotlinAndroidAddStringResource.kt b/idea/idea-android/src/org/jetbrains/kotlin/android/intention/KotlinAndroidAddStringResource.kt index 4e1fbb253c4..ee670d8fb77 100644 --- a/idea/idea-android/src/org/jetbrains/kotlin/android/intention/KotlinAndroidAddStringResource.kt +++ b/idea/idea-android/src/org/jetbrains/kotlin/android/intention/KotlinAndroidAddStringResource.kt @@ -18,8 +18,13 @@ package org.jetbrains.kotlin.android.intention import com.android.resources.ResourceType import com.intellij.CommonBundle -import com.intellij.codeInsight.template.* -import com.intellij.codeInsight.template.impl.* +import com.intellij.codeInsight.template.Template +import com.intellij.codeInsight.template.TemplateEditingAdapter +import com.intellij.codeInsight.template.TemplateManager +import com.intellij.codeInsight.template.impl.ConstantNode +import com.intellij.codeInsight.template.impl.MacroCallNode +import com.intellij.codeInsight.template.impl.TemplateImpl +import com.intellij.codeInsight.template.impl.TemplateState import com.intellij.codeInsight.template.macro.VariableOfTypeMacro import com.intellij.openapi.application.ApplicationManager import com.intellij.openapi.command.undo.UndoUtil @@ -167,7 +172,7 @@ class KotlinAndroidAddStringResource : SelfTargetingIntention getPsiElementPopup( } } addListener(object : JBPopupAdapter() { - override fun onClosed(event: LightweightWindowEvent?) { + override fun onClosed(event: LightweightWindowEvent) { highlighter?.dropHighlight() } }) diff --git a/idea/src/org/jetbrains/kotlin/idea/refactoring/move/changePackage/ChangePackageIntention.kt b/idea/src/org/jetbrains/kotlin/idea/refactoring/move/changePackage/ChangePackageIntention.kt index 40ede6c10da..3abcd30326c 100644 --- a/idea/src/org/jetbrains/kotlin/idea/refactoring/move/changePackage/ChangePackageIntention.kt +++ b/idea/src/org/jetbrains/kotlin/idea/refactoring/move/changePackage/ChangePackageIntention.kt @@ -72,13 +72,13 @@ class ChangePackageIntention: SelfTargetingOffsetIndependentIntention): PullUpProcessor { val targetPsiClass = targetClass as? PsiClass ?: (targetClass as KtClass).toLightClass() - return PullUpProcessor(sourceClass.toLightClass(), - targetPsiClass, - memberInfos.mapNotNull { it.toJavaMemberInfo() }.toTypedArray(), - DocCommentPolicy(JavaRefactoringSettings.getInstance().PULL_UP_MEMBERS_JAVADOC)) + return PullUpProcessor( + sourceClass.toLightClass() ?: error("can't build lightClass for $sourceClass"), + targetPsiClass, + memberInfos.mapNotNull { it.toJavaMemberInfo() }.toTypedArray(), + DocCommentPolicy(JavaRefactoringSettings.getInstance().PULL_UP_MEMBERS_JAVADOC)) } } } \ No newline at end of file diff --git a/idea/src/org/jetbrains/kotlin/idea/script/scriptsTemplatesFromDependencies.kt b/idea/src/org/jetbrains/kotlin/idea/script/scriptsTemplatesFromDependencies.kt index 72b961e66d9..7e7d2b25856 100644 --- a/idea/src/org/jetbrains/kotlin/idea/script/scriptsTemplatesFromDependencies.kt +++ b/idea/src/org/jetbrains/kotlin/idea/script/scriptsTemplatesFromDependencies.kt @@ -35,7 +35,7 @@ class ScriptTemplatesFromDependenciesProvider(private val project: Project) : Sc init { val connection = project.messageBus.connect() connection.subscribe(ProjectTopics.PROJECT_ROOTS, object : ModuleRootListener { - override fun rootsChanged(event: ModuleRootEvent?) { + override fun rootsChanged(event: ModuleRootEvent) { if (project.isInitialized) { var templatesChanged = false lock.read {