azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[NI] Restore old behaviour of AbstractPartialBodyResolveTest

Browse Source 
Smartcasts between partial and full resolution mode should almost never match,
comparing smartcasted types in test runner is incorrect in general case.
Mute failing test until decision about correct behaviour (KT-35922).
This commit is contained in:
Pavel Kirpichenkov
2020-01-14 19:29:46 +03:00
parent b9a1fc294c
commit d36dd12f58
2 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/tests/org/jetbrains/kotlin/idea/resolve/AbstractPartialBodyResolveTest.kt
+1 -7
View File
@@ -149,13 +149,7 @@ abstract class AbstractPartialBodyResolveTest : KotlinLightCodeInsightFixtureTes
} else { } else {
expression expression
} }
val type = bindingContext.getType(expressionWithType)
val nonDataFlowAwareType = bindingContext.getType(expressionWithType)
val type = getDataFlowAwareTypes(
expressionWithType,
bindingContext,
nonDataFlowAwareType
).singleOrNull() ?: nonDataFlowAwareType
return ResolveData(target, type, processedStatements) return ResolveData(target, type, processedStatements)
} }
tests/mute-common.csv
+1
View File
@@ -41,6 +41,7 @@ org.jetbrains.kotlin.idea.quickfix.QuickFixTestGenerated.Libraries.testTestNG, E
org.jetbrains.kotlin.idea.refactoring.move.MultiModuleMoveTestGenerated.testMoveFromJsModuleToJvmModule_MoveFromJsModuleToJvmModule, KT-34106 org.jetbrains.kotlin.idea.refactoring.move.MultiModuleMoveTestGenerated.testMoveFromJsModuleToJvmModule_MoveFromJsModuleToJvmModule, KT-34106
org.jetbrains.kotlin.idea.refactoring.move.MultiModuleMoveTestGenerated.testMoveFromJvmModuleToJsModule_MoveFromJvmModuleToJsModule, KT-34106 org.jetbrains.kotlin.idea.refactoring.move.MultiModuleMoveTestGenerated.testMoveFromJvmModuleToJsModule_MoveFromJvmModuleToJsModule, KT-34106
org.jetbrains.kotlin.idea.refactoring.move.MultiModuleMoveTestGenerated.testMoveJdkDependentToJsModule_MoveJdkDependentToJsModule, KT-34106 org.jetbrains.kotlin.idea.refactoring.move.MultiModuleMoveTestGenerated.testMoveJdkDependentToJsModule_MoveJdkDependentToJsModule, KT-34106
org.jetbrains.kotlin.idea.resolve.PartialBodyResolveTestGenerated.testSmartCastInTheSameStatement, KT-35922
org.jetbrains.kotlin.idea.run.RunConfigurationTest.testWithModuleForJdk9, Always red org.jetbrains.kotlin.idea.run.RunConfigurationTest.testWithModuleForJdk9, Always red
org.jetbrains.kotlin.idea.spring.tests.references.SpringReferenceNavigationTestGenerated.testPackageReferenceInComponentScan, Always red because of test data org.jetbrains.kotlin.idea.spring.tests.references.SpringReferenceNavigationTestGenerated.testPackageReferenceInComponentScan, Always red because of test data
org.jetbrains.kotlin.idea.stubs.MultiFileHighlightingTestGenerated.testTopLevelMembersReference, Always red org.jetbrains.kotlin.idea.stubs.MultiFileHighlightingTestGenerated.testTopLevelMembersReference, Always red
Can't render this file because it contains an unexpected character in line 12 and column 132.