Rename Visibility to DescriptorVisibility

This commit is contained in:
Dmitriy Novozhilov
2020-09-01 16:06:06 +03:00
parent 2bcd8ee07f
commit d1fd1da56f
379 changed files with 2240 additions and 2250 deletions
@@ -53,5 +53,5 @@ fun DeclarationDescriptor.shouldBeExported(config: JsConfig): Boolean =
private fun EffectiveVisibility.shouldBeExported(config: JsConfig): Boolean {
if (publicApi) return true
if (config.configuration.getBoolean(JSConfigurationKeys.FRIEND_PATHS_DISABLED)) return false
return toVisibility() == Visibilities.INTERNAL
}
return toVisibility() == DescriptorVisibilities.INTERNAL
}
@@ -288,7 +288,7 @@ class NameSuggestion {
is PackageFragmentDescriptor -> when {
effectiveVisibility.isPublicAPI -> mangledAndStable()
effectiveVisibility == Visibilities.INTERNAL -> mangledInternal()
effectiveVisibility == DescriptorVisibilities.INTERNAL -> mangledInternal()
else -> regularAndUnstable()
}
@@ -297,16 +297,16 @@ class NameSuggestion {
descriptor is FunctionDescriptor && descriptor.isEnumValueOfMethod() -> mangledAndStable()
// Make all public declarations stable
effectiveVisibility == Visibilities.PUBLIC -> mangledAndStable()
effectiveVisibility == DescriptorVisibilities.PUBLIC -> mangledAndStable()
descriptor.isOverridableOrOverrides -> mangledAndStable()
// Make all protected declarations of non-final public classes stable
effectiveVisibility == Visibilities.PROTECTED &&
effectiveVisibility == DescriptorVisibilities.PROTECTED &&
!containingDeclaration.isFinalClass &&
containingDeclaration.visibility.isPublicAPI -> mangledAndStable()
effectiveVisibility == Visibilities.INTERNAL -> mangledInternal()
effectiveVisibility == DescriptorVisibilities.INTERNAL -> mangledInternal()
// Mangle (but make unstable) all non-public API of public classes
containingDeclaration.visibility.isPublicAPI && !containingDeclaration.isFinalClass -> mangledPrivate()
@@ -383,4 +383,4 @@ fun Char.isES5IdentifierPart() =
fun String.isValidES5Identifier() =
isNotEmpty() &&
first().isES5IdentifierStart() &&
drop(1).all { it.isES5IdentifierPart() }
drop(1).all { it.isES5IdentifierPart() }
@@ -216,7 +216,7 @@ object JsExternalChecker : DeclarationChecker {
private fun isPrivateMemberOfExternalClass(descriptor: DeclarationDescriptor): Boolean {
if (descriptor is PropertyAccessorDescriptor && descriptor.visibility == descriptor.correspondingProperty.visibility) return false
if (descriptor !is MemberDescriptor || descriptor.visibility != Visibilities.PRIVATE) return false
if (descriptor !is MemberDescriptor || descriptor.visibility != DescriptorVisibilities.PRIVATE) return false
val containingDeclaration = descriptor.containingDeclaration as? ClassDescriptor ?: return false
return AnnotationsUtils.isNativeObject(containingDeclaration)
@@ -19,7 +19,7 @@ package org.jetbrains.kotlin.js.resolve
import org.jetbrains.kotlin.builtins.KotlinBuiltIns
import org.jetbrains.kotlin.descriptors.DeclarationDescriptor
import org.jetbrains.kotlin.descriptors.FunctionDescriptor
import org.jetbrains.kotlin.descriptors.Visibilities
import org.jetbrains.kotlin.descriptors.DescriptorVisibilities
import org.jetbrains.kotlin.diagnostics.DiagnosticSink
import org.jetbrains.kotlin.js.PredefinedAnnotation
import org.jetbrains.kotlin.js.resolve.diagnostics.ErrorsJs
@@ -44,7 +44,7 @@ internal abstract class AbstractNativeAnnotationsChecker(private val requiredAnn
return
}
val isMember = !DescriptorUtils.isTopLevelDeclaration(descriptor) && descriptor.visibility != Visibilities.LOCAL
val isMember = !DescriptorUtils.isTopLevelDeclaration(descriptor) && descriptor.visibility != DescriptorVisibilities.LOCAL
val isExtension = DescriptorUtils.isExtension(descriptor)
if (isMember && (isExtension || !AnnotationsUtils.isNativeObject(descriptor)) ||
@@ -119,7 +119,7 @@ public final class AnnotationsUtils {
public static boolean isExportedObject(@NotNull DeclarationDescriptor descriptor, @NotNull BindingContext bindingContext) {
if (descriptor instanceof MemberDescriptor) {
MemberDescriptor memberDescriptor = (MemberDescriptor) descriptor;
if (memberDescriptor.getVisibility() != Visibilities.PUBLIC) return false;
if (memberDescriptor.getVisibility() != DescriptorVisibilities.PUBLIC) return false;
}
if (hasAnnotationOrInsideAnnotatedClass(descriptor, JS_EXPORT)) return true;