From cd2ff41ef5fc0394d3e53f1e84d952a0d4afb2cc Mon Sep 17 00:00:00 2001 From: Alexey Tsvetkov Date: Thu, 20 Sep 2018 16:02:15 +0300 Subject: [PATCH] Validate Gradle task properties on test run By default `validateTaskProperties` is added only to `check` task's dependencies, so doesn't run on our CI. We can run `check` instead of `test` on CI, but since developers are not used to it, I believe it's better to make `test` tasks depend on `validateTaskProperties` --- .../tools/kotlin-gradle-plugin-integration-tests/build.gradle | 1 + libraries/tools/kotlin-gradle-plugin/build.gradle | 1 + 2 files changed, 2 insertions(+) diff --git a/libraries/tools/kotlin-gradle-plugin-integration-tests/build.gradle b/libraries/tools/kotlin-gradle-plugin-integration-tests/build.gradle index 417ad523560..e435921ee12 100644 --- a/libraries/tools/kotlin-gradle-plugin-integration-tests/build.gradle +++ b/libraries/tools/kotlin-gradle-plugin-integration-tests/build.gradle @@ -135,6 +135,7 @@ tasks.withType(Test) { def jpsIncrementalTestsClass = '**/KotlinGradlePluginJpsParametrizedIT.class' test { + dependsOn(":kotlin-gradle-plugin:validateTaskProperties") exclude jpsIncrementalTestsClass } diff --git a/libraries/tools/kotlin-gradle-plugin/build.gradle b/libraries/tools/kotlin-gradle-plugin/build.gradle index 88ca553654d..0c5922935ed 100644 --- a/libraries/tools/kotlin-gradle-plugin/build.gradle +++ b/libraries/tools/kotlin-gradle-plugin/build.gradle @@ -122,6 +122,7 @@ artifacts { } test.executable = "${JDK_18}/bin/java" +test.dependsOn(validateTaskProperties) validateTaskProperties.failOnWarning = true