azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Detect redundant 'is' check

Browse Source 
#KT-14187 Fixed
This commit is contained in:
Dmitry Neverov
2017-05-01 08:27:25 +02:00
committed by Mikhail Zarechenskiy
parent 768e0fa738
commit cd24adac32
36 changed files with 123 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/testData/checker/IsExpressions.kt
Vendored
+1 -1
View File
@@ -1,5 +1,5 @@
fun test() {
if (1 is Int) {
if (<warning>1 is Int</warning>) {
if (1 is <error>Boolean</error>) {
}
idea/testData/checker/When.kt
Vendored
+2 -2
View File
@@ -5,8 +5,8 @@ fun foo() : Int {
val x = 1
when (x) {
is <error>String</error> -> <warning>1</warning>
!is Int -> <warning>1</warning>
is Any<warning>?</warning> -> <warning>1</warning>
<warning>!is Int</warning> -> <warning>1</warning>
<warning>is Any<warning>?</warning></warning> -> <warning>1</warning>
<error>s</error> -> <warning>1</warning>
1 -> <warning>1</warning>
1 + <error>a</error> -> <warning>1</warning>
idea/testData/checker/infos/SmartCasts.kt
Vendored
+5 -5
View File
@@ -49,7 +49,7 @@ fun f10(a : A?) {
if (!(a is B)) {
return;
}
if (!(a is B)) {
if (!(<warning>a is B</warning>)) {
return;
}
}
@@ -71,7 +71,7 @@ fun f11(a : A?) {
is B -> <info descr="Smart cast to B">a</info>.bar()
is A -> <info descr="Smart cast to A">a</info>.foo()
is Any -> <info descr="Smart cast to A">a</info>.foo()
is Any? -> a.<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: bar">bar</error>()
<warning>is Any?</warning> -> a.<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: bar">bar</error>()
else -> a<info>?.</info>foo()
}
}
@@ -81,12 +81,12 @@ fun f12(a : A?) {
is B -> <info descr="Smart cast to B">a</info>.bar()
is A -> <info descr="Smart cast to A">a</info>.foo()
is Any -> <info descr="Smart cast to A">a</info>.foo();
is Any? -> a.<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: bar">bar</error>()
<warning>is Any?</warning> -> a.<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: bar">bar</error>()
is C -> <info descr="Smart cast to C">a</info>.bar()
else -> a<info>?.</info>foo()
}
if (a is Any?) {
if (<warning>a is Any?</warning>) {
a<info>?.</info><error descr="[UNRESOLVED_REFERENCE] Unresolved reference: bar">bar</error>()
}
if (a is B) {
@@ -203,7 +203,7 @@ fun mergeSmartCasts(a: Any?) {
when (a) {
is String, is Any -> a.<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: compareTo">compareTo</error>("")
}
if (a is String && a is Any) {
if (a is String && <warning>a is Any</warning>) {
val <warning>i</warning>: Int = <info descr="Smart cast to kotlin.String">a</info>.compareTo("")
}
if (a is String && <info descr="Smart cast to kotlin.String">a</info>.compareTo("") == 0) {}