KT-11208 Improve readLine's tests readability

This commit is contained in:
meztihn
2018-02-04 13:31:32 +05:00
committed by Ilya Gorbunov
parent 68cb66ff0e
commit cca7a59bba
+15 -10
View File
@@ -21,42 +21,47 @@ import java.nio.charset.Charset
import kotlin.test.* import kotlin.test.*
class ConsoleTest { class ConsoleTest {
private val defaultLineSeparator: String = "\n" private val linuxLineSeparator: String = "\n"
private val windowsLineSeparator: String = "\r\n"
@Test @Test
fun shouldReadEmptyLine() { fun shouldReadEmptyLine() {
testReadLine("") testReadLine("", emptyList())
} }
@Test @Test
fun shouldReadOneLetter() { fun shouldReadOneLetter() {
testReadLine("a", "a") testReadLine("a", listOf("a"))
} }
@Test @Test
fun shouldReadOneLine() { fun shouldReadOneLine() {
testReadLine("first", "first") testReadLine("first", listOf("first"))
} }
@Test @Test
fun shouldReadTwoLines() { fun shouldReadTwoLines() {
testReadLine("first${defaultLineSeparator}second", "first", "second") testReadLine("first${linuxLineSeparator}second", listOf("first", "second"))
}
@Test
fun shouldReadConsecutiveEmptyLines() {
testReadLine("$linuxLineSeparator$linuxLineSeparator", listOf("", ""))
} }
@Test @Test
fun shouldReadWindowsLineSeparator() { fun shouldReadWindowsLineSeparator() {
val lineSeparator = "\r\n" testReadLine("first${windowsLineSeparator}second", listOf("first", "second"))
testReadLine("first${lineSeparator}second", "first", "second")
} }
@Test @Test
fun shouldReadMultibyteEncodings() { fun shouldReadMultibyteEncodings() {
testReadLine("first${defaultLineSeparator}second", "first", "second", charset = Charsets.UTF_32) testReadLine("first${linuxLineSeparator}second", listOf("first", "second"), charset = Charsets.UTF_32)
} }
private fun testReadLine(text: String, vararg expected: String, charset: Charset = Charsets.UTF_8) { private fun testReadLine(text: String, expected: List<String>, charset: Charset = Charsets.UTF_8) {
val actual = readLines(text, charset) val actual = readLines(text, charset)
assertEquals(expected.asList(), actual) assertEquals(expected, actual)
} }
private fun readLines(text: String, charset: Charset): List<String> { private fun readLines(text: String, charset: Charset): List<String> {