azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add "simplify if with constant" inspection #KT-17919 Fixed

Browse Source
This commit is contained in:
Kirill Rakhman
2017-06-28 22:12:14 +03:00
committed by Mikhail Glukhikh
parent 7634673213
commit cb19a86c44
23 changed files with 359 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/testData/inspections/constantConditionIf/inspectionData/expected.xml
Vendored
+42
View File
@@ -0,0 +1,42 @@
<problems>
<problem>
<file>test.kt</file>
<line>7</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/test.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Condition of 'if' expression is constant</problem_class>
<description>Condition is always 'true'</description>
</problem>
<problem>
<file>test.kt</file>
<line>9</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/test.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Condition of 'if' expression is constant</problem_class>
<description>Condition is always 'false'</description>
</problem>
<problem>
<file>test.kt</file>
<line>14</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/test.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Condition of 'if' expression is constant</problem_class>
<description>Condition is always 'true'</description>
</problem>
<problem>
<file>test.kt</file>
<line>20</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/test.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Condition of 'if' expression is constant</problem_class>
<description>Condition is always 'false'</description>
</problem>
<problem>
<file>test.kt</file>
<line>24</line>
<module>light_idea_test_case</module>
<entry_point TYPE="file" FQNAME="temp:///src/test.kt" />
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Condition of 'if' expression is constant</problem_class>
<description>Condition is always 'true'</description>
</problem>
</problems>
idea/testData/inspections/constantConditionIf/inspectionData/inspections.test
Vendored
+1
View File
@@ -0,0 +1 @@
// INSPECTION_CLASS: org.jetbrains.kotlin.idea.inspections.ConstantConditionIfInspection
idea/testData/inspections/constantConditionIf/test.kt
Vendored
+28
View File
@@ -0,0 +1,28 @@
fun foo(x: Int) {}
fun baz(s: String) {}
const val TRUE = true
fun bar() {
foo(if (TRUE) 1 else 2)
foo(if (false && TRUE) {
baz("a")
1
} else 2)
if (true) {
//asd
baz("a")
baz("b")
}
if (false) {
baz("a")
}
foo(if (TRUE) {
baz("a")
1
} else 2)
}