azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

JVM don't optimize if there are too many data on exception edges

Browse Source
This commit is contained in:
Dmitry Petrov
2021-07-20 18:39:42 +03:00
committed by teamcityserver
parent c1a5ce6e61
commit ca84aa4f2c
1 changed files with 18 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/OptimizationMethodVisitor.kt
+18 -13
View File
@@ -73,24 +73,29 @@ class OptimizationMethodVisitor(
companion object { companion object {
private const val MEMORY_LIMIT_BY_METHOD_MB = 50 private const val MEMORY_LIMIT_BY_METHOD_MB = 50
private const val TRY_CATCH_BLOCKS_LIMIT = 512 private const val TRY_CATCH_BLOCKS_SOFT_LIMIT = 16
fun canBeOptimized(node: MethodNode): Boolean { fun canBeOptimized(node: MethodNode): Boolean {
if (node.tryCatchBlocks.size > TRY_CATCH_BLOCKS_LIMIT) if (node.tryCatchBlocks.size > TRY_CATCH_BLOCKS_SOFT_LIMIT) {
return false if (getTotalFramesWeight(getTotalTcbSize(node), node) > MEMORY_LIMIT_BY_METHOD_MB)
return false
val totalFramesSizeMb = node.instructions.size() * (node.maxLocals + node.maxStack) / (1024 * 1024) }
return totalFramesSizeMb < MEMORY_LIMIT_BY_METHOD_MB return getTotalFramesWeight(node.instructions.size(), node) < MEMORY_LIMIT_BY_METHOD_MB
} }
fun canBeOptimizedUsingSourceInterpreter(node: MethodNode): Boolean { fun canBeOptimizedUsingSourceInterpreter(node: MethodNode): Boolean {
if (node.tryCatchBlocks.size > TRY_CATCH_BLOCKS_LIMIT) val methodSize = node.instructions.size()
return false if (node.tryCatchBlocks.size > TRY_CATCH_BLOCKS_SOFT_LIMIT) {
if (getTotalFramesWeight(getTotalTcbSize(node) * methodSize, node) > MEMORY_LIMIT_BY_METHOD_MB)
val frameSize = node.maxLocals + node.maxStack return false
val methodSize = node.instructions.size().toLong() }
val totalFramesSizeMb = methodSize * methodSize * frameSize / (1024 * 1024) return getTotalFramesWeight(methodSize * methodSize, node) < MEMORY_LIMIT_BY_METHOD_MB
return totalFramesSizeMb < MEMORY_LIMIT_BY_METHOD_MB
} }
private fun getTotalFramesWeight(size: Int, node: MethodNode) =
size.toLong() * (node.maxLocals + node.maxStack) / (1024 * 1024)
private fun getTotalTcbSize(node: MethodNode) =
node.tryCatchBlocks.sumOf { node.instructions.indexOf(it.end) - node.instructions.indexOf(it.start) }
} }
} }