From ca740b70f3e05acf548f1d4233e48e3381de576d Mon Sep 17 00:00:00 2001 From: Dmitrii Gridin Date: Mon, 4 Mar 2024 13:58:12 +0100 Subject: [PATCH] [LL FIR] LLFirLazyResolver: inline `updatePhaseForDeclarationInternals` This is the responsibility of `LLFirTargetResolver` to call it --- .../low/level/api/fir/transformers/LLFirLazyResolver.kt | 9 --------- .../level/api/fir/transformers/LLFirTargetResolver.kt | 7 ++++++- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirLazyResolver.kt b/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirLazyResolver.kt index 53b9f640be2..2085fd5dbfe 100644 --- a/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirLazyResolver.kt +++ b/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirLazyResolver.kt @@ -6,7 +6,6 @@ package org.jetbrains.kotlin.analysis.low.level.api.fir.transformers import org.jetbrains.kotlin.analysis.low.level.api.fir.api.targets.LLFirResolveTarget -import org.jetbrains.kotlin.analysis.low.level.api.fir.lazy.resolve.LLFirPhaseUpdater import org.jetbrains.kotlin.analysis.low.level.api.fir.util.checkCanceled import org.jetbrains.kotlin.analysis.low.level.api.fir.util.checkPhase import org.jetbrains.kotlin.fir.FirElementWithResolveState @@ -53,14 +52,6 @@ internal sealed class LLFirLazyResolver(val resolverPhase: FirResolvePhase) { */ protected abstract fun phaseSpecificCheckIsResolved(target: FirElementWithResolveState) - fun updatePhaseForDeclarationInternals(target: FirElementWithResolveState) { - LLFirPhaseUpdater.updateDeclarationInternalsPhase( - target = target, - newPhase = resolverPhase, - updateForLocalDeclarations = resolverPhase == FirResolvePhase.BODY_RESOLVE, - ) - } - private fun checkNestedDeclarationsAreResolved(target: FirElementWithResolveState) { if (target !is FirDeclaration) return diff --git a/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirTargetResolver.kt b/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirTargetResolver.kt index 03ed8a3dc65..0fa02b68d0c 100644 --- a/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirTargetResolver.kt +++ b/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirTargetResolver.kt @@ -9,6 +9,7 @@ import org.jetbrains.kotlin.analysis.low.level.api.fir.LLFirGlobalResolveCompone import org.jetbrains.kotlin.analysis.low.level.api.fir.api.targets.* import org.jetbrains.kotlin.analysis.low.level.api.fir.api.withFirDesignationEntry import org.jetbrains.kotlin.analysis.low.level.api.fir.file.builder.LLFirLockProvider +import org.jetbrains.kotlin.analysis.low.level.api.fir.lazy.resolve.LLFirPhaseUpdater import org.jetbrains.kotlin.analysis.low.level.api.fir.sessions.LLFirSession import org.jetbrains.kotlin.analysis.low.level.api.fir.util.checkPhase import org.jetbrains.kotlin.analysis.low.level.api.fir.util.errorWithFirSpecificEntries @@ -335,7 +336,11 @@ internal sealed class LLFirTargetResolver( } private fun updatePhaseForDeclarationInternals(target: FirElementWithResolveState) { - LLFirLazyPhaseResolverByPhase.getByPhase(resolverPhase).updatePhaseForDeclarationInternals(target) + LLFirPhaseUpdater.updateDeclarationInternalsPhase( + target = target, + newPhase = resolverPhase, + updateForLocalDeclarations = resolverPhase == FirResolvePhase.BODY_RESOLVE, + ) } /**