azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Saved service implementations to constant for performance.

Browse Source
This commit is contained in:
Evgeny Gerashchenko
2013-07-15 17:07:29 +04:00
parent 89b4e5aab8
commit ca02ca6e77
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/frontend/src/org/jetbrains/jet/lang/resolve/OverridingUtil.java
+8 -2
View File
@@ -21,6 +21,7 @@ import com.google.common.collect.HashBiMap;
import com.google.common.collect.Maps; import com.google.common.collect.Maps;
import com.google.common.collect.Sets; import com.google.common.collect.Sets;
import com.intellij.util.Function; import com.intellij.util.Function;
import com.intellij.util.containers.ContainerUtil;
import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable; import org.jetbrains.annotations.Nullable;
import org.jetbrains.jet.lang.descriptors.*; import org.jetbrains.jet.lang.descriptors.*;
@@ -31,6 +32,12 @@ import java.util.*;
public class OverridingUtil { public class OverridingUtil {
private static final List<ExternalOverridabilityCondition> EXTERNAL_CONDITIONS =
ContainerUtil.collect(ServiceLoader.load(
ExternalOverridabilityCondition.class,
ExternalOverridabilityCondition.class.getClassLoader()).iterator()
);
private OverridingUtil() { private OverridingUtil() {
} }
@@ -183,8 +190,7 @@ public class OverridingUtil {
} }
} }
for (ExternalOverridabilityCondition externalCondition : ServiceLoader for (ExternalOverridabilityCondition externalCondition : EXTERNAL_CONDITIONS) {
.load(ExternalOverridabilityCondition.class, ExternalOverridabilityCondition.class.getClassLoader())) {
if (!externalCondition.isOverridable(superDescriptor, subDescriptor)) { if (!externalCondition.isOverridable(superDescriptor, subDescriptor)) {
return OverrideCompatibilityInfo.externalConditionFailed(externalCondition.getClass()); return OverrideCompatibilityInfo.externalConditionFailed(externalCondition.getClass());
} }