From c8a244cc40eb98e18131d73dbac7afc28d833a7f Mon Sep 17 00:00:00 2001
From: Valentin Kipyatkov <valentin@jetbrains.com>
Date: Fri, 25 Sep 2015 13:02:11 +0300
Subject: [PATCH] Minor corrections on code review

---
 .../org/jetbrains/kotlin/j2k/ClassBodyConverter.kt    |  2 +-
 .../org/jetbrains/kotlin/j2k/ConstructorConverter.kt  | 11 +++++------
 j2k/src/org/jetbrains/kotlin/j2k/propertyDetection.kt |  4 ++--
 j2k/testData/JavaApi.java                             |  1 -
 4 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/j2k/src/org/jetbrains/kotlin/j2k/ClassBodyConverter.kt b/j2k/src/org/jetbrains/kotlin/j2k/ClassBodyConverter.kt
index 8808068c7ed..8b0f3457b76 100644
--- a/j2k/src/org/jetbrains/kotlin/j2k/ClassBodyConverter.kt
+++ b/j2k/src/org/jetbrains/kotlin/j2k/ClassBodyConverter.kt
@@ -70,7 +70,7 @@ class ClassBodyConverter(private val psiClass: PsiClass,
                                               converter.referenceSearcher)
 
         val constructorConverter = if (psiClass.getName() != null && !classKind.isObject())
-            ConstructorConverter(psiClass, converter, { memberToPropertyInfo[it] }, overloadReducer, classKind)
+            ConstructorConverter(psiClass, converter, { field -> memberToPropertyInfo[field]!! }, overloadReducer)
         else
             null
 
diff --git a/j2k/src/org/jetbrains/kotlin/j2k/ConstructorConverter.kt b/j2k/src/org/jetbrains/kotlin/j2k/ConstructorConverter.kt
index 5315000d1cd..1574273eede 100644
--- a/j2k/src/org/jetbrains/kotlin/j2k/ConstructorConverter.kt
+++ b/j2k/src/org/jetbrains/kotlin/j2k/ConstructorConverter.kt
@@ -24,9 +24,8 @@ import java.util.*
 class ConstructorConverter(
         private val psiClass: PsiClass,
         private val converter: Converter,
-        private val fieldToPropertyInfo: (PsiField) -> PropertyInfo?,
-        private val overloadReducer: OverloadReducer,
-        private val classKind: ClassKind
+        private val fieldToPropertyInfo: (PsiField) -> PropertyInfo,
+        private val overloadReducer: OverloadReducer
 ) {
     private val constructors = psiClass.getConstructors().asList()
 
@@ -145,13 +144,13 @@ class ConstructorConverter(
                 }
 
                 val propertyInfo = fieldToPropertyInfo(field)
-                if (propertyInfo != null && (propertyInfo.needExplicitGetter || propertyInfo.needExplicitSetter)) continue
+                if (propertyInfo.needExplicitGetter || propertyInfo.needExplicitSetter) continue
 
                 parameterToField.put(parameter, field to type)
                 statementsToRemove.add(initializationStatement)
                 fieldsToDrop.add(field)
 
-                val fieldName = propertyInfo?.name ?: field.getName()!!
+                val fieldName = propertyInfo.name
                 if (fieldName != parameter.getName()) {
                     parameterUsageReplacementMap.put(parameter.getName()!!, fieldName)
                 }
@@ -200,7 +199,7 @@ class ConstructorConverter(
                     }
                     else {
                         val (field, type) = parameterToField[parameter]!!
-                        val propertyInfo = fieldToPropertyInfo(field)!!
+                        val propertyInfo = fieldToPropertyInfo(field)
                         FunctionParameter(propertyInfo.identifier,
                                           type,
                                           if (propertyInfo.isVar) FunctionParameter.VarValModifier.Var else FunctionParameter.VarValModifier.Val,
diff --git a/j2k/src/org/jetbrains/kotlin/j2k/propertyDetection.kt b/j2k/src/org/jetbrains/kotlin/j2k/propertyDetection.kt
index dae908fc9d9..eaeff2bf4bf 100644
--- a/j2k/src/org/jetbrains/kotlin/j2k/propertyDetection.kt
+++ b/j2k/src/org/jetbrains/kotlin/j2k/propertyDetection.kt
@@ -206,7 +206,7 @@ private class PropertyDetector(
     private fun detectGetters(
             methodsToCheck: List<Pair<PsiMethod, SuperInfo.Property?>>,
             prohibitedPropertyNames: MutableSet<String?>,
-            propertyNamesWithConflict: HashSet<String>
+            propertyNamesWithConflict: MutableSet<String>
     ): Map<String, AccessorInfo> {
         val propertyNameToGetterInfo = LinkedHashMap<String, AccessorInfo>()
         for ((method, superInfo) in methodsToCheck) {
@@ -228,7 +228,7 @@ private class PropertyDetector(
             methodsToCheck: List<Pair<PsiMethod, SuperInfo.Property?>>,
             prohibitedPropertyNames: MutableSet<String?>,
             propertyNamesFromGetters: Set<String>,
-            propertyNamesWithConflict: HashSet<String>
+            propertyNamesWithConflict: MutableSet<String>
     ): Map<String, AccessorInfo> {
         val propertyNameToSetterInfo = LinkedHashMap<String, AccessorInfo>()
         for ((method, superInfo) in methodsToCheck) {
diff --git a/j2k/testData/JavaApi.java b/j2k/testData/JavaApi.java
index e1c1db0d86e..db9f3538eee 100644
--- a/j2k/testData/JavaApi.java
+++ b/j2k/testData/JavaApi.java
@@ -2,7 +2,6 @@ package javaApi;
 
 import org.jetbrains.annotations.Nullable;
 
-import java.lang.String;
 import java.util.Set;
 import kotlinApi.KotlinClassWithProperties;