Incremental KAPT - pass changed classpath entries

Pass computed list of changed classpath names to KAPT instead
of relying on the history files to be computed by stub generation.
Also, stop generating classpath history changes during the stub generation.

This commit does not compute the actual changed classpath entries,
and that will be done in the following commits.

 #KT-23880
This commit is contained in:
Ivan Gavrilovic
2019-03-26 17:31:17 +00:00
committed by Alexey Tsvetkov
parent 0c09f56118
commit c85e21d43b
26 changed files with 136 additions and 255 deletions
@@ -67,7 +67,6 @@ class IncrementalCompilationOptions(
val outputFiles: List<File>, val outputFiles: List<File>,
val multiModuleICSettings: MultiModuleICSettings, val multiModuleICSettings: MultiModuleICSettings,
val modulesInfo: IncrementalModuleInfo, val modulesInfo: IncrementalModuleInfo,
val classpathFqNamesHistory: File? = null,
kotlinScriptExtensions: Array<String>? = null kotlinScriptExtensions: Array<String>? = null
) : CompilationOptions( ) : CompilationOptions(
compilerMode, compilerMode,
@@ -91,7 +90,6 @@ class IncrementalCompilationOptions(
"multiModuleICSettings=$multiModuleICSettings, " + "multiModuleICSettings=$multiModuleICSettings, " +
"usePreciseJavaTracking=$usePreciseJavaTracking" + "usePreciseJavaTracking=$usePreciseJavaTracking" +
"outputFiles=$outputFiles" + "outputFiles=$outputFiles" +
"classpathFqNamesHistory=$classpathFqNamesHistory" +
")" ")"
} }
} }
@@ -566,18 +566,14 @@ class CompileServiceImpl(
} }
} }
val outputFiles = incrementalCompilationOptions.outputFiles.toMutableList()
incrementalCompilationOptions.classpathFqNamesHistory?.let { outputFiles.add(it) }
val compiler = IncrementalJvmCompilerRunner( val compiler = IncrementalJvmCompilerRunner(
workingDir, workingDir,
reporter, reporter,
buildHistoryFile = incrementalCompilationOptions.multiModuleICSettings.buildHistoryFile, buildHistoryFile = incrementalCompilationOptions.multiModuleICSettings.buildHistoryFile,
outputFiles = outputFiles, outputFiles = incrementalCompilationOptions.outputFiles,
usePreciseJavaTracking = incrementalCompilationOptions.usePreciseJavaTracking, usePreciseJavaTracking = incrementalCompilationOptions.usePreciseJavaTracking,
modulesApiHistory = modulesApiHistory, modulesApiHistory = modulesApiHistory,
kotlinSourceFilesExtensions = allKotlinExtensions, kotlinSourceFilesExtensions = allKotlinExtensions
classpathFqNamesHistory = incrementalCompilationOptions.classpathFqNamesHistory
) )
return try { return try {
compiler.compile(allKotlinFiles, k2jvmArgs, compilerMessageCollector, changedFiles) compiler.compile(allKotlinFiles, k2jvmArgs, compilerMessageCollector, changedFiles)
@@ -313,7 +313,7 @@ abstract class IncrementalCompilerRunner<
open fun runWithNoDirtyKotlinSources(caches: CacheManager): Boolean = false open fun runWithNoDirtyKotlinSources(caches: CacheManager): Boolean = false
protected open fun processChangesAfterBuild( private fun processChangesAfterBuild(
compilationMode: CompilationMode, compilationMode: CompilationMode,
currentBuildInfo: BuildInfo, currentBuildInfo: BuildInfo,
dirtyData: DirtyData dirtyData: DirtyData
@@ -109,8 +109,7 @@ class IncrementalJvmCompilerRunner(
buildHistoryFile: File, buildHistoryFile: File,
outputFiles: Collection<File>, outputFiles: Collection<File>,
private val modulesApiHistory: ModulesApiHistory, private val modulesApiHistory: ModulesApiHistory,
override val kotlinSourceFilesExtensions: List<String> = DEFAULT_KOTLIN_SOURCE_FILES_EXTENSIONS, override val kotlinSourceFilesExtensions: List<String> = DEFAULT_KOTLIN_SOURCE_FILES_EXTENSIONS
private val classpathFqNamesHistory: File? = null
) : IncrementalCompilerRunner<K2JVMCompilerArguments, IncrementalJvmCachesManager>( ) : IncrementalCompilerRunner<K2JVMCompilerArguments, IncrementalJvmCachesManager>(
workingDir, workingDir,
"caches-jvm", "caches-jvm",
@@ -257,28 +256,6 @@ class IncrementalJvmCompilerRunner(
} }
} }
override fun processChangesAfterBuild(compilationMode: CompilationMode, currentBuildInfo: BuildInfo, dirtyData: DirtyData) {
super.processChangesAfterBuild(compilationMode, currentBuildInfo, dirtyData)
classpathFqNamesHistory ?: return
classpathFqNamesHistory.mkdirs()
val historyFiles = classpathFqNamesHistory.listFiles()
if (dirtyClasspathChanges.isEmpty() && historyFiles.isNotEmpty()) {
// Don't write an empty file. We check there is at least one file so that downstream task can mark what it has processed.
return
}
if (historyFiles.size > 10) {
historyFiles.minBy { it.lastModified() }!!.delete()
}
val newHistoryFile = classpathFqNamesHistory.resolve(System.currentTimeMillis().toString())
ObjectOutputStream(newHistoryFile.outputStream().buffered()).use {
val listOfNames = dirtyClasspathChanges.map { it.toString() }.toList()
it.writeObject(listOfNames)
}
}
override fun postCompilationHook(exitCode: ExitCode) {} override fun postCompilationHook(exitCode: ExitCode) {}
override fun updateCaches( override fun updateCaches(
@@ -35,26 +35,14 @@ class KaptIncrementalWithAggregatingApt : KaptIncrementalIT() {
fun testIncrementalChanges() { fun testIncrementalChanges() {
val project = getProject() val project = getProject()
var aptTimestamp = 0L
project.build("clean", "build") { project.build("clean", "build") {
assertSuccessful() assertSuccessful()
val classpathHistory =
fileInWorkingDir("build/kotlin/kaptGenerateStubsKotlin/classpath-fq-history").listFiles().asList().single()
val stubsTimestamp = classpathHistory.name.toLong()
aptTimestamp = fileInWorkingDir("build/tmp/kapt3/incApCache/main/last-build-ts.bin").readText().toLong()
assertTrue(stubsTimestamp < aptTimestamp)
} }
project.projectFile("useB.kt").modify { current -> "$current\nfun otherFunction() {}" } project.projectFile("useB.kt").modify { current -> "$current\nfun otherFunction() {}" }
project.build("build") { project.build("build") {
assertSuccessful() assertSuccessful()
val newAptTimestamp = fileInWorkingDir("build/tmp/kapt3/incApCache/main/last-build-ts.bin").readText().toLong()
assertTrue(aptTimestamp < newAptTimestamp)
assertEquals( assertEquals(
setOf( setOf(
fileInWorkingDir("build/tmp/kapt3/stubs/main/bar/UseBKt.java").absolutePath, fileInWorkingDir("build/tmp/kapt3/stubs/main/bar/UseBKt.java").absolutePath,
@@ -38,26 +38,14 @@ class KaptIncrementalWithIsolatingApt : KaptIncrementalIT() {
fun testIncrementalChanges() { fun testIncrementalChanges() {
val project = getProject() val project = getProject()
var aptTimestamp = 0L
project.build("clean", "build") { project.build("clean", "build") {
assertSuccessful() assertSuccessful()
val classpathHistory =
fileInWorkingDir("build/kotlin/kaptGenerateStubsKotlin/classpath-fq-history").listFiles().asList().single()
val stubsTimestamp = classpathHistory.name.toLong()
aptTimestamp = fileInWorkingDir("build/tmp/kapt3/incApCache/main/last-build-ts.bin").readText().toLong()
assertTrue(stubsTimestamp < aptTimestamp)
} }
project.projectFile("useB.kt").modify { current -> "$current\nfun otherFunction() {}" } project.projectFile("useB.kt").modify { current -> "$current\nfun otherFunction() {}" }
project.build("build") { project.build("build") {
assertSuccessful() assertSuccessful()
val newAptTimestamp = fileInWorkingDir("build/tmp/kapt3/incApCache/main/last-build-ts.bin").readText().toLong()
assertTrue(aptTimestamp < newAptTimestamp)
assertEquals(setOf(fileInWorkingDir("build/tmp/kapt3/stubs/main/bar/UseBKt.java").absolutePath), getProcessedSources(output)) assertEquals(setOf(fileInWorkingDir("build/tmp/kapt3/stubs/main/bar/UseBKt.java").absolutePath), getProcessedSources(output))
} }
@@ -268,7 +268,6 @@ internal class GradleKotlinCompilerWork @Inject constructor(
outputFiles = outputFiles, outputFiles = outputFiles,
multiModuleICSettings = icEnv.multiModuleICSettings, multiModuleICSettings = icEnv.multiModuleICSettings,
modulesInfo = incrementalModuleInfo!!, modulesInfo = incrementalModuleInfo!!,
classpathFqNamesHistory = icEnv.classpathFqNamesHistory,
kotlinScriptExtensions = kotlinScriptExtensions kotlinScriptExtensions = kotlinScriptExtensions
) )
@@ -15,8 +15,7 @@ internal class IncrementalCompilationEnvironment(
val workingDir: File, val workingDir: File,
val usePreciseJavaTracking: Boolean = false, val usePreciseJavaTracking: Boolean = false,
val disableMultiModuleIC: Boolean = false, val disableMultiModuleIC: Boolean = false,
val multiModuleICSettings: MultiModuleICSettings, val multiModuleICSettings: MultiModuleICSettings
val classpathFqNamesHistory: File? = null
) : Serializable { ) : Serializable {
companion object { companion object {
const val serialVersionUID: Long = 0 const val serialVersionUID: Long = 0
@@ -234,9 +234,7 @@ class Kapt3KotlinGradleSubplugin : KotlinGradleSubplugin<KotlinCompile> {
) )
val kaptGenerateStubsTask = context.createKaptGenerateStubsTask() val kaptGenerateStubsTask = context.createKaptGenerateStubsTask()
val kaptTask = context.createKaptKotlinTask( val kaptTask = context.createKaptKotlinTask(useWorkerApi = project.isUseWorkerApi())
useWorkerApi = project.isUseWorkerApi(),
classpathHistoryDir = kaptGenerateStubsTask.getClasspathFqNamesHistoryDir())
kaptGenerateStubsTask.source(*kaptConfigurations.toTypedArray()) kaptGenerateStubsTask.source(*kaptConfigurations.toTypedArray())
@@ -374,7 +372,7 @@ class Kapt3KotlinGradleSubplugin : KotlinGradleSubplugin<KotlinCompile> {
} }
} }
private fun Kapt3SubpluginContext.createKaptKotlinTask(useWorkerApi: Boolean, classpathHistoryDir: File? = null): KaptTask { private fun Kapt3SubpluginContext.createKaptKotlinTask(useWorkerApi: Boolean): KaptTask {
val taskClass = if (useWorkerApi) KaptWithoutKotlincTask::class.java else KaptWithKotlincTask::class.java val taskClass = if (useWorkerApi) KaptWithoutKotlincTask::class.java else KaptWithKotlincTask::class.java
val kaptTask = project.tasks.create(getKaptTaskName("kapt"), taskClass) val kaptTask = project.tasks.create(getKaptTaskName("kapt"), taskClass)
@@ -391,7 +389,6 @@ class Kapt3KotlinGradleSubplugin : KotlinGradleSubplugin<KotlinCompile> {
kaptTask.isIncremental = project.isIncrementalKapt() kaptTask.isIncremental = project.isIncrementalKapt()
if (kaptTask.isIncremental) { if (kaptTask.isIncremental) {
kaptTask.incAptCache = getKaptIncrementalAnnotationProcessingCache() kaptTask.incAptCache = getKaptIncrementalAnnotationProcessingCache()
kaptTask.classpathDirtyFqNamesHistoryDir = project.files(classpathHistoryDir)
} }
kotlinCompilation?.run { kotlinCompilation?.run {
@@ -422,10 +419,6 @@ class Kapt3KotlinGradleSubplugin : KotlinGradleSubplugin<KotlinCompile> {
kaptTask.pluginOptions.addPluginArgument( kaptTask.pluginOptions.addPluginArgument(
getCompilerPluginId(), getCompilerPluginId(),
SubpluginOption("incrementalCache", kaptTask.incAptCache!!.absolutePath)) SubpluginOption("incrementalCache", kaptTask.incAptCache!!.absolutePath))
kaptTask.pluginOptions.addPluginArgument(
getCompilerPluginId(),
SubpluginOption("classpathFqNamesHistory", kaptTask.classpathDirtyFqNamesHistoryDir.singleFile!!.absolutePath))
} }
buildAndAddOptionsTo(kaptTask, kaptTask.pluginOptions, aptMode = "apt") buildAndAddOptionsTo(kaptTask, kaptTask.pluginOptions, aptMode = "apt")
@@ -74,11 +74,6 @@ open class KaptGenerateStubsTask : KotlinCompile() {
super.setSource(sourceRootsContainer.set(sources)) super.setSource(sourceRootsContainer.set(sources))
} }
@Internal
override fun getClasspathFqNamesHistoryDir(): File? {
return taskBuildDirectory.resolve("classpath-fq-history")
}
private fun isSourceRootAllowed(source: File): Boolean = private fun isSourceRootAllowed(source: File): Boolean =
!destinationDir.isParentOf(source) && !destinationDir.isParentOf(source) &&
!stubsDir.isParentOf(source) && !stubsDir.isParentOf(source) &&
@@ -67,9 +67,6 @@ abstract class KaptTask : ConventionTask(), TaskWithLocalState {
@get:Input @get:Input
internal var includeCompileClasspath: Boolean = true internal var includeCompileClasspath: Boolean = true
@get:InputFiles
internal var classpathDirtyFqNamesHistoryDir: FileCollection = project.files()
@get:Input @get:Input
internal var isIncremental = true internal var isIncremental = true
@@ -160,15 +157,21 @@ abstract class KaptTask : ConventionTask(), TaskWithLocalState {
protected fun getCompiledSources() = listOfNotNull(kotlinCompileTask.destinationDir, kotlinCompileTask.javaOutputDir) protected fun getCompiledSources() = listOfNotNull(kotlinCompileTask.destinationDir, kotlinCompileTask.javaOutputDir)
protected fun getChangedFiles(inputs: IncrementalTaskInputs): List<File> { protected fun getChangedFiles(inputs: IncrementalTaskInputs): List<File> {
return if (!isIncremental || !inputs.isIncremental || !getCompiledSources().all { it.exists() }) { if (!isIncremental || !inputs.isIncremental || !getCompiledSources().all { it.exists() }) {
clearLocalState() clearLocalState()
emptyList() return emptyList()
} else { } else {
with(mutableSetOf<File>()) { val changes = with(mutableSetOf<File>()) {
inputs.outOfDate { this.add(it.file) } inputs.outOfDate { this.add(it.file) }
inputs.removed { this.add(it.file) } inputs.removed { this.add(it.file) }
return@with this.toList() return@with this.toList()
} }
return if (changes.all { it.extension == "java" }) {
changes
} else {
emptyList()
}
} }
} }
@@ -16,17 +16,13 @@ import org.gradle.api.tasks.incremental.IncrementalTaskInputs
import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments
import org.jetbrains.kotlin.compilerRunner.GradleCompilerEnvironment import org.jetbrains.kotlin.compilerRunner.GradleCompilerEnvironment
import org.jetbrains.kotlin.compilerRunner.GradleCompilerRunner import org.jetbrains.kotlin.compilerRunner.GradleCompilerRunner
import org.jetbrains.kotlin.compilerRunner.IncrementalCompilationEnvironment
import org.jetbrains.kotlin.gradle.logging.GradleKotlinLogger
import org.jetbrains.kotlin.compilerRunner.OutputItemsCollectorImpl import org.jetbrains.kotlin.compilerRunner.OutputItemsCollectorImpl
import org.jetbrains.kotlin.gradle.incremental.ChangedFiles
import org.jetbrains.kotlin.gradle.internal.tasks.allOutputFiles import org.jetbrains.kotlin.gradle.internal.tasks.allOutputFiles
import org.jetbrains.kotlin.gradle.logging.GradleKotlinLogger
import org.jetbrains.kotlin.gradle.logging.GradlePrintingMessageCollector
import org.jetbrains.kotlin.gradle.plugin.PLUGIN_CLASSPATH_CONFIGURATION_NAME import org.jetbrains.kotlin.gradle.plugin.PLUGIN_CLASSPATH_CONFIGURATION_NAME
import org.jetbrains.kotlin.gradle.tasks.CompilerPluginOptions import org.jetbrains.kotlin.gradle.tasks.CompilerPluginOptions
import org.jetbrains.kotlin.gradle.logging.GradlePrintingMessageCollector
import org.jetbrains.kotlin.gradle.tasks.clearLocalState
import org.jetbrains.kotlin.gradle.utils.toSortedPathsArray import org.jetbrains.kotlin.gradle.utils.toSortedPathsArray
import org.jetbrains.kotlin.incremental.ChangedFiles
import java.io.File import java.io.File
open class KaptWithKotlincTask : KaptTask(), CompilerArgumentAwareWithInput<K2JVMCompilerArguments> { open class KaptWithKotlincTask : KaptTask(), CompilerArgumentAwareWithInput<K2JVMCompilerArguments> {
@@ -54,7 +50,10 @@ open class KaptWithKotlincTask : KaptTask(), CompilerArgumentAwareWithInput<K2JV
val pluginOptionsWithKapt: CompilerPluginOptions = pluginOptions.withWrappedKaptOptions( val pluginOptionsWithKapt: CompilerPluginOptions = pluginOptions.withWrappedKaptOptions(
withApClasspath = kaptClasspath, withApClasspath = kaptClasspath,
changedFiles = changedFiles, changedFiles = changedFiles,
compiledSourcesDir = getCompiledSources()) classpathChanges = classpathChanges,
compiledSourcesDir = getCompiledSources(),
processIncrementally = processIncrementally
)
args.pluginOptions = (pluginOptionsWithKapt.arguments + args.pluginOptions!!).toTypedArray() args.pluginOptions = (pluginOptionsWithKapt.arguments + args.pluginOptions!!).toTypedArray()
@@ -66,13 +65,25 @@ open class KaptWithKotlincTask : KaptTask(), CompilerArgumentAwareWithInput<K2JV
* in the task action. * in the task action.
*/ */
private var changedFiles: List<File> = emptyList() private var changedFiles: List<File> = emptyList()
private var classpathChanges: List<String> = emptyList()
private var processIncrementally = false
@TaskAction @TaskAction
fun compile(inputs: IncrementalTaskInputs) { fun compile(inputs: IncrementalTaskInputs) {
logger.debug("Running kapt annotation processing using the Kotlin compiler") logger.debug("Running kapt annotation processing using the Kotlin compiler")
checkAnnotationProcessorClasspath() checkAnnotationProcessorClasspath()
changedFiles = getChangedFiles(inputs) val incrementalChanges = getChangedFiles(inputs)
when {
incrementalChanges.isNotEmpty() -> {
changedFiles = incrementalChanges
classpathChanges = emptyList()
processIncrementally = true
}
else -> {
// do nothing
}
}
val args = prepareCompilerArguments() val args = prepareCompilerArguments()
@@ -12,10 +12,8 @@ import org.gradle.api.tasks.TaskAction
import org.gradle.api.tasks.incremental.IncrementalTaskInputs import org.gradle.api.tasks.incremental.IncrementalTaskInputs
import org.gradle.workers.IsolationMode import org.gradle.workers.IsolationMode
import org.gradle.workers.WorkerExecutor import org.gradle.workers.WorkerExecutor
import org.jetbrains.kotlin.gradle.incremental.ChangedFiles
import org.jetbrains.kotlin.gradle.internal.Kapt3KotlinGradleSubplugin.Companion.KAPT_WORKER_DEPENDENCIES_CONFIGURATION_NAME import org.jetbrains.kotlin.gradle.internal.Kapt3KotlinGradleSubplugin.Companion.KAPT_WORKER_DEPENDENCIES_CONFIGURATION_NAME
import org.jetbrains.kotlin.gradle.plugin.KotlinAndroidPluginWrapper import org.jetbrains.kotlin.gradle.plugin.KotlinAndroidPluginWrapper
import org.jetbrains.kotlin.gradle.tasks.clearLocalState
import org.jetbrains.kotlin.gradle.tasks.findKotlinStdlibClasspath import org.jetbrains.kotlin.gradle.tasks.findKotlinStdlibClasspath
import org.jetbrains.kotlin.gradle.tasks.findToolsJar import org.jetbrains.kotlin.gradle.tasks.findToolsJar
import org.jetbrains.kotlin.utils.PathUtil import org.jetbrains.kotlin.utils.PathUtil
@@ -52,6 +50,8 @@ open class KaptWithoutKotlincTask @Inject constructor(private val workerExecutor
logger.info("Running kapt annotation processing using the Gradle Worker API") logger.info("Running kapt annotation processing using the Gradle Worker API")
checkAnnotationProcessorClasspath() checkAnnotationProcessorClasspath()
val incrementalChanges = getChangedFiles(inputs)
val compileClasspath = classpath.files.toMutableList() val compileClasspath = classpath.files.toMutableList()
if (project.plugins.none { it is KotlinAndroidPluginWrapper }) { if (project.plugins.none { it is KotlinAndroidPluginWrapper }) {
compileClasspath.addAll(0, PathUtil.getJdkClassesRootsFromCurrentJre()) compileClasspath.addAll(0, PathUtil.getJdkClassesRootsFromCurrentJre())
@@ -68,10 +68,11 @@ open class KaptWithoutKotlincTask @Inject constructor(private val workerExecutor
compileClasspath, compileClasspath,
javaSourceRoots.toList(), javaSourceRoots.toList(),
getChangedFiles(inputs), incrementalChanges,
getCompiledSources(), getCompiledSources(),
incAptCache, incAptCache,
classpathDirtyFqNamesHistoryDir.singleOrNull(), emptyList(),
incrementalChanges.isNotEmpty(),
destinationDir, destinationDir,
classesDir, classesDir,
@@ -94,7 +95,7 @@ open class KaptWithoutKotlincTask @Inject constructor(private val workerExecutor
workerExecutor.submit(KaptExecution::class.java) { config -> workerExecutor.submit(KaptExecution::class.java) { config ->
val isolationModeStr = project.findProperty("kapt.workers.isolation") as String? ?: "none" val isolationModeStr = project.findProperty("kapt.workers.isolation") as String? ?: "none"
config.isolationMode = when(isolationModeStr.toLowerCase()) { config.isolationMode = when (isolationModeStr.toLowerCase()) {
"process" -> IsolationMode.PROCESS "process" -> IsolationMode.PROCESS
"none" -> IsolationMode.NONE "none" -> IsolationMode.NONE
else -> IsolationMode.NONE else -> IsolationMode.NONE
@@ -148,7 +149,7 @@ private class KaptExecution @Inject constructor(
} }
} }
private fun createKaptOptions(classLoader: ClassLoader) = with (optionsForWorker) { private fun createKaptOptions(classLoader: ClassLoader) = with(optionsForWorker) {
val flags = kaptClass(classLoader).declaredMethods.single { it.name == "kaptFlags" }.invoke(null, flags) val flags = kaptClass(classLoader).declaredMethods.single { it.name == "kaptFlags" }.invoke(null, flags)
val mode = Class.forName("org.jetbrains.kotlin.base.kapt3.AptMode", true, classLoader) val mode = Class.forName("org.jetbrains.kotlin.base.kapt3.AptMode", true, classLoader)
@@ -165,7 +166,8 @@ private class KaptExecution @Inject constructor(
changedFiles, changedFiles,
compiledSources, compiledSources,
incAptCache, incAptCache,
classpathFqNamesHistory, classpathChanges,
processIncrementally,
sourcesOutputDir, sourcesOutputDir,
classesOutputDir, classesOutputDir,
@@ -201,7 +203,8 @@ private data class KaptOptionsForWorker(
val changedFiles: List<File>, val changedFiles: List<File>,
val compiledSources: List<File>, val compiledSources: List<File>,
val incAptCache: File?, val incAptCache: File?,
val classpathFqNamesHistory: File?, val classpathChanges: List<String>,
val processIncrementally: Boolean,
val sourcesOutputDir: File, val sourcesOutputDir: File,
val classesOutputDir: File, val classesOutputDir: File,
@@ -44,13 +44,22 @@ fun encodePluginOptions(options: Map<String, List<String>>): String {
} }
internal fun CompilerPluginOptions.withWrappedKaptOptions( internal fun CompilerPluginOptions.withWrappedKaptOptions(
withApClasspath: Iterable<File>, changedFiles: List<File> = emptyList(), compiledSourcesDir: List<File> = emptyList() withApClasspath: Iterable<File>,
changedFiles: List<File> = emptyList(),
classpathChanges: List<String> = emptyList(),
compiledSourcesDir: List<File> = emptyList(),
processIncrementally: Boolean = false
): CompilerPluginOptions { ): CompilerPluginOptions {
val resultOptionsByPluginId: MutableMap<String, List<SubpluginOption>> = val resultOptionsByPluginId: MutableMap<String, List<SubpluginOption>> =
subpluginOptionsByPluginId.toMutableMap() subpluginOptionsByPluginId.toMutableMap()
resultOptionsByPluginId.compute(Kapt3KotlinGradleSubplugin.KAPT_SUBPLUGIN_ID) { _, kaptOptions -> resultOptionsByPluginId.compute(Kapt3KotlinGradleSubplugin.KAPT_SUBPLUGIN_ID) { _, kaptOptions ->
val changedFilesOption = FilesSubpluginOption("changedFile", changedFiles).takeIf { changedFiles.isNotEmpty() } val changedFilesOption = FilesSubpluginOption("changedFile", changedFiles).takeIf { changedFiles.isNotEmpty() }
val classpathChangesOption = SubpluginOption(
"classpathChange",
classpathChanges.joinToString(separator = File.pathSeparator)
).takeIf { classpathChanges.isNotEmpty() }
val processIncrementallyOption = SubpluginOption("processIncrementally", processIncrementally.toString())
val compiledSourcesOption = val compiledSourcesOption =
FilesSubpluginOption("compiledSourcesDir", compiledSourcesDir).takeIf { compiledSourcesDir.isNotEmpty() } FilesSubpluginOption("compiledSourcesDir", compiledSourcesDir).takeIf { compiledSourcesDir.isNotEmpty() }
@@ -58,7 +67,9 @@ internal fun CompilerPluginOptions.withWrappedKaptOptions(
kaptOptions.orEmpty() + kaptOptions.orEmpty() +
withApClasspath.map { FilesSubpluginOption("apclasspath", listOf(it)) } + withApClasspath.map { FilesSubpluginOption("apclasspath", listOf(it)) } +
changedFilesOption + changedFilesOption +
compiledSourcesOption classpathChangesOption +
compiledSourcesOption +
processIncrementallyOption
wrapPluginOptions(kaptOptionsWithClasspath.filterNotNull(), "configuration") wrapPluginOptions(kaptOptionsWithClasspath.filterNotNull(), "configuration")
} }
@@ -435,8 +435,7 @@ open class KotlinCompile : AbstractKotlinCompile<K2JVMCompilerArguments>(), Kotl
taskBuildDirectory, taskBuildDirectory,
usePreciseJavaTracking = usePreciseJavaTracking, usePreciseJavaTracking = usePreciseJavaTracking,
disableMultiModuleIC = disableMultiModuleIC(), disableMultiModuleIC = disableMultiModuleIC(),
multiModuleICSettings = multiModuleICSettings, multiModuleICSettings = multiModuleICSettings
classpathFqNamesHistory = getClasspathFqNamesHistoryDir()
) )
} else null } else null
@@ -479,10 +478,6 @@ open class KotlinCompile : AbstractKotlinCompile<K2JVMCompilerArguments>(), Kotl
return false return false
} }
@Optional
@Internal
internal open fun getClasspathFqNamesHistoryDir(): File? = null
// override setSource to track source directory sets and files (for generated android folders) // override setSource to track source directory sets and files (for generated android folders)
override fun setSource(sources: Any?) { override fun setSource(sources: Any?) {
sourceRootsContainer.set(sources) sourceRootsContainer.set(sources)
@@ -57,11 +57,16 @@ open class KaptContext(val options: KaptOptions, val withJdk: Boolean, val logge
KaptJavaCompiler.preRegister(context) KaptJavaCompiler.preRegister(context)
cacheManager = options.incrementalCache?.let { cacheManager = options.incrementalCache?.let {
JavaClassCacheManager(it, options.classpathFqNamesHistory!!) JavaClassCacheManager(it)
}
if (options.processIncrementally) {
sourcesToReprocess =
cacheManager?.invalidateAndGetDirtyFiles(
options.changedFiles, options.classpathChanges
) ?: SourcesToReprocess.FullRebuild
} else {
sourcesToReprocess = SourcesToReprocess.FullRebuild
} }
sourcesToReprocess = cacheManager?.invalidateAndGetDirtyFiles(
options.changedFiles.filter { it.extension == "java" }
) ?: SourcesToReprocess.FullRebuild
javacOptions = Options.instance(context).apply { javacOptions = Options.instance(context).apply {
for ((key, value) in options.processingOptions) { for ((key, value) in options.processingOptions) {
@@ -88,7 +93,7 @@ open class KaptContext(val options: KaptOptions, val withJdk: Boolean, val logge
put("accessInternalAPI", "true") put("accessInternalAPI", "true")
} }
val compileClasspath = if (sourcesToReprocess is SourcesToReprocess.FullRebuild || options.changedFiles.isEmpty()) { val compileClasspath = if (sourcesToReprocess is SourcesToReprocess.FullRebuild) {
options.compileClasspath options.compileClasspath
} else { } else {
options.compileClasspath + options.compiledSources options.compileClasspath + options.compiledSources
@@ -17,7 +17,8 @@ class KaptOptions(
val changedFiles: List<File>, val changedFiles: List<File>,
val compiledSources: List<File>, val compiledSources: List<File>,
val incrementalCache: File?, val incrementalCache: File?,
val classpathFqNamesHistory: File?, val classpathChanges: List<String>,
val processIncrementally: Boolean,
val sourcesOutputDir: File, val sourcesOutputDir: File,
val classesOutputDir: File, val classesOutputDir: File,
@@ -45,12 +46,13 @@ class KaptOptions(
val changedFiles: MutableList<File> = mutableListOf() val changedFiles: MutableList<File> = mutableListOf()
val compiledSources: MutableList<File> = mutableListOf() val compiledSources: MutableList<File> = mutableListOf()
var incrementalCache: File? = null var incrementalCache: File? = null
var classpathFqNamesHistory: File? = null val classpathChanges: MutableList<String> = mutableListOf()
var sourcesOutputDir: File? = null var sourcesOutputDir: File? = null
var classesOutputDir: File? = null var classesOutputDir: File? = null
var stubsOutputDir: File? = null var stubsOutputDir: File? = null
var incrementalDataOutputDir: File? = null var incrementalDataOutputDir: File? = null
var processIncrementally: Boolean = false
val processingClasspath: MutableList<File> = mutableListOf() val processingClasspath: MutableList<File> = mutableListOf()
val processors: MutableList<String> = mutableListOf() val processors: MutableList<String> = mutableListOf()
@@ -73,7 +75,7 @@ class KaptOptions(
return KaptOptions( return KaptOptions(
projectBaseDir, compileClasspath, javaSourceRoots, projectBaseDir, compileClasspath, javaSourceRoots,
changedFiles, compiledSources, incrementalCache, classpathFqNamesHistory, changedFiles, compiledSources, incrementalCache, classpathChanges, processIncrementally,
sourcesOutputDir, classesOutputDir, stubsOutputDir, incrementalDataOutputDir, sourcesOutputDir, classesOutputDir, stubsOutputDir, incrementalDataOutputDir,
processingClasspath, processors, processingOptions, javacOptions, KaptFlags.fromSet(flags), processingClasspath, processors, processingOptions, javacOptions, KaptFlags.fromSet(flags),
mode, detectMemoryLeaks mode, detectMemoryLeaks
@@ -169,5 +171,6 @@ fun KaptOptions.logString(additionalInfo: String = "") = buildString {
appendln("[incremental apt] Changed files: $changedFiles") appendln("[incremental apt] Changed files: $changedFiles")
appendln("[incremental apt] Compiled sources directories: ${compiledSources.joinToString()}") appendln("[incremental apt] Compiled sources directories: ${compiledSources.joinToString()}")
appendln("[incremental apt] Cache directory for incremental compilation: $incrementalCache") appendln("[incremental apt] Cache directory for incremental compilation: $incrementalCache")
appendln("[incremental apt] Classpath fq names history dir: $classpathFqNamesHistory") appendln("[incremental apt] Changes classpath names: ${classpathChanges.joinToString()}")
appendln("[incremental apt] If processing incrementally: $processIncrementally")
} }
@@ -8,7 +8,7 @@ package org.jetbrains.kotlin.kapt3.base.incremental
import java.io.* import java.io.*
// TODO(gavra): switch away from Java serialization // TODO(gavra): switch away from Java serialization
class JavaClassCacheManager(val file: File, private val classpathFqNamesHistory: File) : Closeable { class JavaClassCacheManager(val file: File) : Closeable {
private val javaCacheFile = file.resolve("java-cache.bin") private val javaCacheFile = file.resolve("java-cache.bin")
internal val javaCache = maybeGetJavaCacheFromFile() internal val javaCache = maybeGetJavaCacheFromFile()
@@ -16,38 +16,8 @@ class JavaClassCacheManager(val file: File, private val classpathFqNamesHistory:
private val aptCacheFile = file.resolve("apt-cache.bin") private val aptCacheFile = file.resolve("apt-cache.bin")
private val aptCache = maybeGetAptCacheFromFile() private val aptCache = maybeGetAptCacheFromFile()
private val lastBuildTimestamp = file.resolve("last-build-ts.bin")
private var closed = false private var closed = false
private fun getDirtyFqNamesFromClasspath(): ClasspathChanged {
if (!lastBuildTimestamp.exists()) return ClasspathChanged.FullRebuild
val lastTimestamp = lastBuildTimestamp.readText()
val (before, after) = classpathFqNamesHistory.listFiles().partition { it.name < lastTimestamp }
if (before.isEmpty()) {
return ClasspathChanged.FullRebuild
}
val dirtyFqNames = mutableSetOf<String>()
after.forEach { file ->
ObjectInputStream(file.inputStream().buffered()).use {
@Suppress("UNCHECKED_CAST")
dirtyFqNames.addAll(it.readObject() as Collection<String>)
}
}
return if (dirtyFqNames.isNotEmpty()) {
// TODO(gavra): We need to handle constants from classpath that might change between runs being incremental. One solution
// would be to fetch the changed symbols alongside changed fqNames, and to check if the symbol is a constant using ASM.
ClasspathChanged.FullRebuild
} else {
ClasspathChanged.Incremental(dirtyFqNames)
}
}
fun updateCache(processors: List<IncrementalProcessor>) { fun updateCache(processors: List<IncrementalProcessor>) {
if (!aptCache.updateCache(processors)) { if (!aptCache.updateCache(processors)) {
javaCache.invalidateAll() javaCache.invalidateAll()
@@ -58,39 +28,38 @@ class JavaClassCacheManager(val file: File, private val classpathFqNamesHistory:
* From set of changed sources, get list of files to recompile using structural information and dependency information from * From set of changed sources, get list of files to recompile using structural information and dependency information from
* annotation processing. * annotation processing.
*/ */
fun invalidateAndGetDirtyFiles(changedSources: Collection<File>): SourcesToReprocess { fun invalidateAndGetDirtyFiles(changedSources: Collection<File>, dirtyClasspathJvmNames: Collection<String>): SourcesToReprocess {
if (!aptCache.isIncremental) { if (!aptCache.isIncremental) {
return SourcesToReprocess.FullRebuild return SourcesToReprocess.FullRebuild
} }
val dirtyFqNamesFromClasspath = getDirtyFqNamesFromClasspath() val dirtyClasspathFqNames = HashSet<String>(dirtyClasspathJvmNames.size)
return when (dirtyFqNamesFromClasspath) { dirtyClasspathJvmNames.forEach {
is ClasspathChanged.FullRebuild -> SourcesToReprocess.FullRebuild dirtyClasspathFqNames.add(it.replace("$", ".").replace("/", "."))
is ClasspathChanged.Incremental -> { }
val changes = Changes(changedSources, dirtyFqNamesFromClasspath.dirtyFqNames)
val filesToReprocess = javaCache.invalidateEntriesForChangedFiles(changes)
when (filesToReprocess) { val changes = Changes(changedSources, dirtyClasspathFqNames.toSet())
is SourcesToReprocess.FullRebuild -> SourcesToReprocess.FullRebuild val filesToReprocess = javaCache.invalidateEntriesForChangedFiles(changes)
is SourcesToReprocess.Incremental -> {
val toReprocess = filesToReprocess.toReprocess.toMutableSet()
val isolatingGenerated = aptCache.invalidateIsolatingGenerated(toReprocess) return when (filesToReprocess) {
val generatedDirtyTypes = javaCache.invalidateGeneratedTypes(isolatingGenerated).toMutableSet() is SourcesToReprocess.FullRebuild -> SourcesToReprocess.FullRebuild
is SourcesToReprocess.Incremental -> {
val toReprocess = filesToReprocess.toReprocess.toMutableSet()
if (!toReprocess.isEmpty()) { val isolatingGenerated = aptCache.invalidateIsolatingGenerated(toReprocess)
// only if there are some files to reprocess we should invalidate the aggregating ones val generatedDirtyTypes = javaCache.invalidateGeneratedTypes(isolatingGenerated).toMutableSet()
val aggregatingGenerated = aptCache.invalidateAggregating()
generatedDirtyTypes.addAll(javaCache.invalidateGeneratedTypes(aggregatingGenerated))
toReprocess.addAll( if (!toReprocess.isEmpty()) {
javaCache.invalidateEntriesAnnotatedWith(aptCache.getAggregatingClaimedAnnotations()) // only if there are some files to reprocess we should invalidate the aggregating ones
) val aggregatingGenerated = aptCache.invalidateAggregating()
} generatedDirtyTypes.addAll(javaCache.invalidateGeneratedTypes(aggregatingGenerated))
SourcesToReprocess.Incremental(toReprocess.toList(), generatedDirtyTypes) toReprocess.addAll(
} javaCache.invalidateEntriesAnnotatedWith(aptCache.getAggregatingClaimedAnnotations())
)
} }
SourcesToReprocess.Incremental(toReprocess.toList(), generatedDirtyTypes)
} }
} }
} }
@@ -144,9 +113,6 @@ class JavaClassCacheManager(val file: File, private val classpathFqNamesHistory:
} }
} }
with(lastBuildTimestamp) {
writeText(System.currentTimeMillis().toString())
}
closed = true closed = true
} }
} }
@@ -154,9 +120,4 @@ class JavaClassCacheManager(val file: File, private val classpathFqNamesHistory:
sealed class SourcesToReprocess { sealed class SourcesToReprocess {
class Incremental(val toReprocess: List<File>, val dirtyTypes: Set<String>) : SourcesToReprocess() class Incremental(val toReprocess: List<File>, val dirtyTypes: Set<String>) : SourcesToReprocess()
object FullRebuild : SourcesToReprocess() object FullRebuild : SourcesToReprocess()
}
sealed class ClasspathChanged {
class Incremental(val dirtyFqNames: Set<String>) : ClasspathChanged()
object FullRebuild : ClasspathChanged()
} }
@@ -9,6 +9,7 @@ import org.jetbrains.kotlin.base.kapt3.KaptOptions
import org.jetbrains.kotlin.base.kapt3.collectJavaSourceFiles import org.jetbrains.kotlin.base.kapt3.collectJavaSourceFiles
import org.jetbrains.kotlin.kapt3.base.KaptContext import org.jetbrains.kotlin.kapt3.base.KaptContext
import org.jetbrains.kotlin.kapt3.base.doAnnotationProcessing import org.jetbrains.kotlin.kapt3.base.doAnnotationProcessing
import org.jetbrains.kotlin.kapt3.base.incremental.SourcesToReprocess
import org.jetbrains.kotlin.kapt3.base.util.WriterBackedKaptLogger import org.jetbrains.kotlin.kapt3.base.util.WriterBackedKaptLogger
import org.junit.Assert.* import org.junit.Assert.*
import org.junit.Rule import org.junit.Rule
@@ -32,9 +33,6 @@ class IncrementalKaptTest {
val outputDir = tmp.newFolder() val outputDir = tmp.newFolder()
val incrementalCacheDir = tmp.newFolder() val incrementalCacheDir = tmp.newFolder()
val classpathHistory = tmp.newFolder().also {
it.resolve("0").createNewFile()
}
val options = KaptOptions.Builder().apply { val options = KaptOptions.Builder().apply {
projectBaseDir = tmp.newFolder() projectBaseDir = tmp.newFolder()
javaSourceRoots.add(sourcesDir) javaSourceRoots.add(sourcesDir)
@@ -45,14 +43,12 @@ class IncrementalKaptTest {
incrementalDataOutputDir = outputDir incrementalDataOutputDir = outputDir
incrementalCache = incrementalCacheDir incrementalCache = incrementalCacheDir
classpathFqNamesHistory = classpathHistory
}.build() }.build()
val logger = WriterBackedKaptLogger(isVerbose = true) val logger = WriterBackedKaptLogger(isVerbose = true)
KaptContext(options, true, logger).use { KaptContext(options, true, logger).use {
val toReprocess = it.cacheManager!!.invalidateAndGetDirtyFiles(options.changedFiles)
it.doAnnotationProcessing( it.doAnnotationProcessing(
options.collectJavaSourceFiles(toReprocess), listOf(SimpleProcessor().toIsolating()) options.collectJavaSourceFiles(SourcesToReprocess.FullRebuild), listOf(SimpleProcessor().toIsolating())
) )
} }
@@ -72,14 +68,14 @@ class IncrementalKaptTest {
incrementalDataOutputDir = outputDir incrementalDataOutputDir = outputDir
incrementalCache = incrementalCacheDir incrementalCache = incrementalCacheDir
classpathFqNamesHistory = classpathHistory
compiledSources.add(classesOutput) compiledSources.add(classesOutput)
changedFiles.add(sourcesDir.resolve("User.java")) changedFiles.add(sourcesDir.resolve("User.java"))
processIncrementally = true
}.build() }.build()
KaptContext(optionsForSecondRun, true, logger).use { KaptContext(optionsForSecondRun, true, logger).use {
val sourcesToReprocess = val sourcesToReprocess =
it.cacheManager!!.invalidateAndGetDirtyFiles(optionsForSecondRun.changedFiles) it.cacheManager!!.invalidateAndGetDirtyFiles(optionsForSecondRun.changedFiles, emptyList())
assertFalse(outputDir.resolve("test/UserGenerated.java").exists()) assertFalse(outputDir.resolve("test/UserGenerated.java").exists())
it.doAnnotationProcessing( it.doAnnotationProcessing(
@@ -92,7 +88,7 @@ class IncrementalKaptTest {
sourcesDir.resolve("User.java").delete() sourcesDir.resolve("User.java").delete()
KaptContext(optionsForSecondRun, true, logger).use { KaptContext(optionsForSecondRun, true, logger).use {
val sourcesToReprocess = it.cacheManager!!.invalidateAndGetDirtyFiles(optionsForSecondRun.changedFiles) val sourcesToReprocess = it.cacheManager!!.invalidateAndGetDirtyFiles(optionsForSecondRun.changedFiles, emptyList())
it.doAnnotationProcessing( it.doAnnotationProcessing(
optionsForSecondRun.collectJavaSourceFiles(sourcesToReprocess), listOf(SimpleProcessor().toIsolating()) optionsForSecondRun.collectJavaSourceFiles(sourcesToReprocess), listOf(SimpleProcessor().toIsolating())
@@ -114,9 +110,6 @@ class IncrementalKaptTest {
val outputDir = tmp.newFolder() val outputDir = tmp.newFolder()
val incrementalCacheDir = tmp.newFolder() val incrementalCacheDir = tmp.newFolder()
val classpathHistory = tmp.newFolder().also {
it.resolve("0").createNewFile()
}
val options = KaptOptions.Builder().apply { val options = KaptOptions.Builder().apply {
projectBaseDir = tmp.newFolder() projectBaseDir = tmp.newFolder()
javaSourceRoots.add(sourcesDir) javaSourceRoots.add(sourcesDir)
@@ -127,14 +120,12 @@ class IncrementalKaptTest {
incrementalDataOutputDir = outputDir incrementalDataOutputDir = outputDir
incrementalCache = incrementalCacheDir incrementalCache = incrementalCacheDir
classpathFqNamesHistory = classpathHistory
}.build() }.build()
val logger = WriterBackedKaptLogger(isVerbose = true) val logger = WriterBackedKaptLogger(isVerbose = true)
KaptContext(options, true, logger).use { KaptContext(options, true, logger).use {
val toReprocess = it.cacheManager!!.invalidateAndGetDirtyFiles(options.changedFiles)
it.doAnnotationProcessing( it.doAnnotationProcessing(
options.collectJavaSourceFiles(toReprocess), listOf(SimpleGeneratingIfTypeDoesNotExist().toIsolating()) options.collectJavaSourceFiles(SourcesToReprocess.FullRebuild), listOf(SimpleGeneratingIfTypeDoesNotExist().toIsolating())
) )
} }
@@ -151,14 +142,14 @@ class IncrementalKaptTest {
incrementalDataOutputDir = outputDir incrementalDataOutputDir = outputDir
incrementalCache = incrementalCacheDir incrementalCache = incrementalCacheDir
classpathFqNamesHistory = classpathHistory
compiledSources.add(classesOutput) compiledSources.add(classesOutput)
changedFiles.add(sourcesDir.resolve("User.java")) changedFiles.add(sourcesDir.resolve("User.java"))
processIncrementally = true
}.build() }.build()
KaptContext(optionsForSecondRun, true, logger).use { KaptContext(optionsForSecondRun, true, logger).use {
val sourcesToReprocess = val sourcesToReprocess =
it.cacheManager!!.invalidateAndGetDirtyFiles(optionsForSecondRun.changedFiles) it.cacheManager!!.invalidateAndGetDirtyFiles(optionsForSecondRun.changedFiles, emptyList())
assertFalse(outputDir.resolve("test/UserGenerated.java").exists()) assertFalse(outputDir.resolve("test/UserGenerated.java").exists())
it.doAnnotationProcessing( it.doAnnotationProcessing(
@@ -30,7 +30,7 @@ class TestInheritedAnnotation {
@BeforeClass @BeforeClass
fun setUp() { fun setUp() {
val classpathHistory = tmp.newFolder() val classpathHistory = tmp.newFolder()
cache = JavaClassCacheManager(tmp.newFolder(), classpathHistory) cache = JavaClassCacheManager(tmp.newFolder())
generatedSources = tmp.newFolder() generatedSources = tmp.newFolder()
cache.close() cache.close()
classpathHistory.resolve("0").createNewFile() classpathHistory.resolve("0").createNewFile()
@@ -22,13 +22,11 @@ class JavaClassCacheManagerTest {
private lateinit var cache: JavaClassCacheManager private lateinit var cache: JavaClassCacheManager
private lateinit var cacheDir: File private lateinit var cacheDir: File
private lateinit var classpathHistory: File
@Before @Before
fun setUp() { fun setUp() {
cacheDir = tmp.newFolder() cacheDir = tmp.newFolder()
classpathHistory = tmp.newFolder() cache = JavaClassCacheManager(cacheDir)
cache = JavaClassCacheManager(cacheDir, classpathHistory)
} }
@@ -38,7 +36,6 @@ class JavaClassCacheManagerTest {
assertTrue(cacheDir.resolve("java-cache.bin").exists()) assertTrue(cacheDir.resolve("java-cache.bin").exists())
assertTrue(cacheDir.resolve("apt-cache.bin").exists()) assertTrue(cacheDir.resolve("apt-cache.bin").exists())
assertTrue(cacheDir.resolve("last-build-ts.bin").exists())
} }
@Test @Test
@@ -59,7 +56,7 @@ class JavaClassCacheManagerTest {
} }
prepareForIncremental() prepareForIncremental()
val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(File("Mentioned.java"))) as SourcesToReprocess.Incremental val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(File("Mentioned.java")), emptyList()) as SourcesToReprocess.Incremental
assertEquals( assertEquals(
listOf( listOf(
File("Mentioned.java").absoluteFile, File("Mentioned.java").absoluteFile,
@@ -87,7 +84,7 @@ class JavaClassCacheManagerTest {
} }
prepareForIncremental() prepareForIncremental()
val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(File("Mentioned.java"))) as SourcesToReprocess.Incremental val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(File("Mentioned.java")), emptyList()) as SourcesToReprocess.Incremental
assertEquals( assertEquals(
listOf( listOf(
File("Mentioned.java").absoluteFile, File("Mentioned.java").absoluteFile,
@@ -115,7 +112,7 @@ class JavaClassCacheManagerTest {
} }
prepareForIncremental() prepareForIncremental()
val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(File("TwoTypes.java"))) as SourcesToReprocess.Incremental val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(File("TwoTypes.java")), emptyList()) as SourcesToReprocess.Incremental
assertEquals( assertEquals(
listOf( listOf(
File("TwoTypes.java").absoluteFile, File("TwoTypes.java").absoluteFile,
@@ -126,48 +123,16 @@ class JavaClassCacheManagerTest {
} }
@Test @Test
fun testNoClasspathHistory() { fun testWithClasspathChanges() {
SourceFileStructure(File("Src.java").toURI()).also {
it.addDeclaredType("test.Src")
cache.javaCache.addSourceStructure(it)
}
cache.close()
classpathHistory.resolve(Long.MAX_VALUE.toString()).createNewFile()
val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf())
assertEquals(SourcesToReprocess.FullRebuild, dirtyFiles)
}
@Test
fun testWithClasspathHistoryButNoNewChanges() {
SourceFileStructure(File("Src.java").toURI()).also { SourceFileStructure(File("Src.java").toURI()).also {
it.addDeclaredType("test.Src") it.addDeclaredType("test.Src")
it.addMentionedType("test.Mentioned") it.addMentionedType("test.Mentioned")
cache.javaCache.addSourceStructure(it) cache.javaCache.addSourceStructure(it)
} }
prepareForIncremental() prepareForIncremental()
ObjectOutputStream(classpathHistory.resolve("0").outputStream()).use {
it.writeObject(listOf("test.Mentioned"))
}
val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf()) as SourcesToReprocess.Incremental val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(), listOf("test/Mentioned")) as SourcesToReprocess.Incremental
assertEquals(emptyList<File>(), dirtyFiles.toReprocess) assertEquals(listOf(File("Src.java").absoluteFile), dirtyFiles.toReprocess)
}
@Test
fun testWithClasspathHistoryWithChanges() {
SourceFileStructure(File("Src.java").toURI()).also {
it.addDeclaredType("test.Src")
it.addMentionedType("test.Mentioned")
cache.javaCache.addSourceStructure(it)
}
prepareForIncremental()
ObjectOutputStream(classpathHistory.resolve(Long.MAX_VALUE.toString()).outputStream()).use {
it.writeObject(listOf("test.Mentioned"))
}
val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf())
assertEquals(SourcesToReprocess.FullRebuild, dirtyFiles)
} }
@Test @Test
@@ -187,7 +152,7 @@ class JavaClassCacheManagerTest {
} }
prepareForIncremental() prepareForIncremental()
val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(File("Constants.java"))) val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(File("Constants.java")), emptyList())
assertEquals(SourcesToReprocess.FullRebuild, dirtyFiles) assertEquals(SourcesToReprocess.FullRebuild, dirtyFiles)
} }
@@ -217,7 +182,6 @@ class JavaClassCacheManagerTest {
private fun prepareForIncremental() { private fun prepareForIncremental() {
cache.close() cache.close()
classpathHistory.resolve("0").createNewFile() cache = JavaClassCacheManager(cacheDir)
cache = JavaClassCacheManager(cacheDir, classpathHistory)
} }
} }
@@ -32,11 +32,9 @@ class ReferencedConstantsTest {
val compiledClasses = tmp.newFolder() val compiledClasses = tmp.newFolder()
compileSources(listOf(MY_TEST_DIR.resolve("CKlass.java")), compiledClasses) compileSources(listOf(MY_TEST_DIR.resolve("CKlass.java")), compiledClasses)
val classpathHistory = tmp.newFolder() cache = JavaClassCacheManager(tmp.newFolder())
cache = JavaClassCacheManager(tmp.newFolder(), classpathHistory)
generatedSources = tmp.newFolder() generatedSources = tmp.newFolder()
cache.close() cache.close()
classpathHistory.resolve("0").createNewFile()
val processor = SimpleProcessor().toAggregating() val processor = SimpleProcessor().toAggregating()
val srcFiles = listOf( val srcFiles = listOf(
"A.java", "A.java",
@@ -29,11 +29,9 @@ class TestComplexIncrementalAptCache {
@JvmStatic @JvmStatic
@BeforeClass @BeforeClass
fun setUp() { fun setUp() {
val classpathHistory = tmp.newFolder() cache = JavaClassCacheManager(tmp.newFolder())
cache = JavaClassCacheManager(tmp.newFolder(), classpathHistory)
generatedSources = tmp.newFolder() generatedSources = tmp.newFolder()
cache.close() cache.close()
classpathHistory.resolve("0").createNewFile()
val processor = SimpleProcessor().toAggregating() val processor = SimpleProcessor().toAggregating()
val srcFiles = listOf( val srcFiles = listOf(
"MyEnum.java", "MyEnum.java",
@@ -27,18 +27,16 @@ class TestSimpleIncrementalAptCache {
@Before @Before
fun setUp() { fun setUp() {
val classpathHistory = tmp.newFolder() cache = JavaClassCacheManager(tmp.newFolder())
cache = JavaClassCacheManager(tmp.newFolder(), classpathHistory)
generatedSources = tmp.newFolder() generatedSources = tmp.newFolder()
cache.close() cache.close()
classpathHistory.resolve("0").createNewFile()
} }
@Test @Test
fun testAggregatingAnnotations() { fun testAggregatingAnnotations() {
runProcessor(SimpleProcessor().toAggregating()) runProcessor(SimpleProcessor().toAggregating())
val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(TEST_DATA_DIR.resolve("User.java"))) as SourcesToReprocess.Incremental val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(TEST_DATA_DIR.resolve("User.java")), emptyList()) as SourcesToReprocess.Incremental
assertEquals( assertEquals(
listOf(TEST_DATA_DIR.resolve("User.java").absoluteFile, TEST_DATA_DIR.resolve("Address.java").absoluteFile), listOf(TEST_DATA_DIR.resolve("User.java").absoluteFile, TEST_DATA_DIR.resolve("Address.java").absoluteFile),
dirtyFiles.toReprocess dirtyFiles.toReprocess
@@ -51,7 +49,7 @@ class TestSimpleIncrementalAptCache {
fun testIsolatingAnnotations() { fun testIsolatingAnnotations() {
runProcessor(SimpleProcessor().toIsolating()) runProcessor(SimpleProcessor().toIsolating())
val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(TEST_DATA_DIR.resolve("User.java"))) as SourcesToReprocess.Incremental val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(TEST_DATA_DIR.resolve("User.java")), emptyList()) as SourcesToReprocess.Incremental
assertFalse(generatedSources.resolve("test/UserGenerated.java").exists()) assertFalse(generatedSources.resolve("test/UserGenerated.java").exists())
assertEquals( assertEquals(
listOf(TEST_DATA_DIR.resolve("User.java").absoluteFile), listOf(TEST_DATA_DIR.resolve("User.java").absoluteFile),
@@ -63,7 +61,7 @@ class TestSimpleIncrementalAptCache {
fun testNonIncremental() { fun testNonIncremental() {
runProcessor(SimpleProcessor().toNonIncremental()) runProcessor(SimpleProcessor().toNonIncremental())
val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(TEST_DATA_DIR.resolve("User.java"))) val dirtyFiles = cache.invalidateAndGetDirtyFiles(listOf(TEST_DATA_DIR.resolve("User.java")), emptyList())
assertTrue(dirtyFiles is SourcesToReprocess.FullRebuild) assertTrue(dirtyFiles is SourcesToReprocess.FullRebuild)
} }
+10 -4
View File
@@ -90,10 +90,16 @@ enum class KaptCliOption(
"Use only in apt mode. Output directory for cache necessary to support incremental annotation processing." "Use only in apt mode. Output directory for cache necessary to support incremental annotation processing."
), ),
CLASSPATH_FQ_NAMES_HISTORY( CLASSPATH_CHANGES(
"classpathFqNamesHistory", "classpathChange",
"<path>", "<jvmInternalName,[jvmInternalName,...]>",
"Use only in apt mode. Directory containing history of classpath fq name changes." "Use only in apt mode. Classpath jvm internal names that changed."
),
PROCESS_INCREMENTALLY(
"processIncrementally",
"boolean",
"Use only in apt mode. Enables incremental apt processing"
), ),
ANNOTATION_PROCESSOR_CLASSPATH_OPTION( ANNOTATION_PROCESSOR_CLASSPATH_OPTION(
@@ -100,7 +100,8 @@ class Kapt3CommandLineProcessor : CommandLineProcessor {
CHANGED_FILES -> changedFiles.addAll(value.split(File.pathSeparator).map { File(it) }) CHANGED_FILES -> changedFiles.addAll(value.split(File.pathSeparator).map { File(it) })
COMPILED_SOURCES_DIR -> compiledSources.addAll(value.split(File.pathSeparator).map { File(it) }) COMPILED_SOURCES_DIR -> compiledSources.addAll(value.split(File.pathSeparator).map { File(it) })
INCREMENTAL_CACHE -> incrementalCache = File(value) INCREMENTAL_CACHE -> incrementalCache = File(value)
CLASSPATH_FQ_NAMES_HISTORY -> classpathFqNamesHistory = File(value) CLASSPATH_CHANGES -> classpathChanges.addAll(value.split(File.pathSeparator).map { it })
PROCESS_INCREMENTALLY -> processIncrementally = value.toBoolean()
ANNOTATION_PROCESSOR_CLASSPATH_OPTION -> processingClasspath += File(value) ANNOTATION_PROCESSOR_CLASSPATH_OPTION -> processingClasspath += File(value)
ANNOTATION_PROCESSORS_OPTION -> processors.addAll(value.split(',').map { it.trim() }.filter { it.isNotEmpty() }) ANNOTATION_PROCESSORS_OPTION -> processors.addAll(value.split(',').map { it.trim() }.filter { it.isNotEmpty() })