[FIR] Inherit FIR with parameter renderer from the old parameter renderer

compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/diagnostics/FirDiagnosticRenderer.kt

@@ -7,13 +7,12 @@ package org.jetbrains.kotlin.fir.analysis.diagnostics
 
 import org.jetbrains.kotlin.diagnostics.rendering.*
 import org.jetbrains.kotlin.fir.FirSourceElement
-import java.text.MessageFormat
 
-sealed class FirDiagnosticRenderer<D : FirDiagnostic<*>> : DiagnosticRenderer<D> {
+interface FirDiagnosticRenderer<D : FirDiagnostic<*>> : DiagnosticRenderer<D> {
-    abstract override fun render(diagnostic: D): String
+    override fun render(diagnostic: D): String
 }
 
-class SimpleFirDiagnosticRenderer<E : FirSourceElement>(private val message: String) : FirDiagnosticRenderer<FirSimpleDiagnostic<E>>() {
+class SimpleFirDiagnosticRenderer<E : FirSourceElement>(private val message: String) : FirDiagnosticRenderer<FirSimpleDiagnostic<E>> {
     override fun render(diagnostic: FirSimpleDiagnostic<E>): String {
         return message
     }
@@ -21,15 +20,7 @@ class SimpleFirDiagnosticRenderer<E : FirSourceElement>(private val message: Str
 
 sealed class AbstractFirDiagnosticWithParametersRenderer<D : FirDiagnostic<*>>(
     protected val message: String
-) : FirDiagnosticRenderer<D>() {
+) : FirDiagnosticRenderer<D>, AbstractDiagnosticWithParametersRenderer<D>(message)
-    private val messageFormat = MessageFormat(message)
-
-    override fun render(diagnostic: D): String {
-        return messageFormat.format(renderParameters(diagnostic))
-    }
-
-    abstract fun renderParameters(diagnostic: D): Array<out Any>
-}
 
 class FirDiagnosticWithParameters1Renderer<E : FirSourceElement, A : Any>(
     message: String,

compiler/frontend/src/org/jetbrains/kotlin/diagnostics/rendering/diagnosticsWithParameterRenderers.kt

@@ -23,8 +23,8 @@ import java.text.MessageFormat
 abstract class AbstractDiagnosticWithParametersRenderer<D : Diagnostic> protected constructor(message: String) : DiagnosticRenderer<D> {
     private val messageFormat = MessageFormat(message)
 
-    override fun render(obj: D): String {
+    override fun render(diagnostic: D): String {
-        return messageFormat.format(renderParameters(obj))
+        return messageFormat.format(renderParameters(diagnostic))
     }
 
     abstract fun renderParameters(diagnostic: D): Array<out Any>

compiler/tests-common/tests/org/jetbrains/kotlin/fir/AbstractFirDiagnosticTest.kt

@@ -203,6 +203,7 @@ abstract class AbstractFirDiagnosticsTest : AbstractFirBaseDiagnosticsTest() {
         argument: () -> String,
     ): FirDiagnosticWithParameters1<FirSourceElement, String>? {
         val sourceElement = element.source ?: return null
+        if (sourceElement.kind != FirRealSourceElementKind) return null
         val name = name ?: return null
         if (diagnosedRangesToDiagnosticNames[sourceElement.startOffset..sourceElement.endOffset]?.contains(name) != true) return null