From c714e599eae01f097c0e16a51a64514f59a5ff33 Mon Sep 17 00:00:00 2001
From: Mikhail Glukhikh <mikhail.glukhikh@jetbrains.com>
Date: Fri, 1 Mar 2019 17:08:20 +0300
Subject: [PATCH] Don't report "Unsafe call with ? extension receiver" with
 smart-cast

#KT-29499 Fixed
---
 ...tformExtensionReceiverOfInlineInspection.kt | 18 +++++++++++++++---
 .../before/ToBoolean/src/Test.kt               |  5 +++++
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/idea/src/org/jetbrains/kotlin/idea/inspections/PlatformExtensionReceiverOfInlineInspection.kt b/idea/src/org/jetbrains/kotlin/idea/inspections/PlatformExtensionReceiverOfInlineInspection.kt
index 2cacccab752..3d0fa7f6121 100644
--- a/idea/src/org/jetbrains/kotlin/idea/inspections/PlatformExtensionReceiverOfInlineInspection.kt
+++ b/idea/src/org/jetbrains/kotlin/idea/inspections/PlatformExtensionReceiverOfInlineInspection.kt
@@ -16,12 +16,17 @@ import com.intellij.ui.EditorTextField
 import org.intellij.lang.regexp.RegExpFileType
 import org.jetbrains.kotlin.config.LanguageFeature
 import org.jetbrains.kotlin.descriptors.FunctionDescriptor
-import org.jetbrains.kotlin.idea.caches.resolve.resolveToCall
+import org.jetbrains.kotlin.idea.caches.resolve.analyze
+import org.jetbrains.kotlin.idea.caches.resolve.getResolutionFacade
 import org.jetbrains.kotlin.idea.project.languageVersionSettings
 import org.jetbrains.kotlin.idea.quickfix.AddExclExclCallFix
 import org.jetbrains.kotlin.psi.KtCallExpression
 import org.jetbrains.kotlin.psi.KtDotQualifiedExpression
 import org.jetbrains.kotlin.psi.KtVisitorVoid
+import org.jetbrains.kotlin.resolve.bindingContextUtil.getDataFlowInfoBefore
+import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
+import org.jetbrains.kotlin.resolve.calls.smartcasts.DataFlowValueFactory
+import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
 import org.jetbrains.kotlin.types.isNullabilityFlexible
 import java.awt.BorderLayout
 import java.util.regex.PatternSyntaxException
@@ -46,7 +51,8 @@ class PlatformExtensionReceiverOfInlineInspection : AbstractKotlinInspection() {
             override fun visitDotQualifiedExpression(expression: KtDotQualifiedExpression) {
                 super.visitDotQualifiedExpression(expression)
 
-                if (!expression.languageVersionSettings.supportsFeature(LanguageFeature.NullabilityAssertionOnExtensionReceiver)) {
+                val languageVersionSettings = expression.languageVersionSettings
+                if (!languageVersionSettings.supportsFeature(LanguageFeature.NullabilityAssertionOnExtensionReceiver)) {
                     return
                 }
                 val nameRegex = nameRegex
@@ -56,13 +62,19 @@ class PlatformExtensionReceiverOfInlineInspection : AbstractKotlinInspection() {
                     return
                 }
 
-                val resolvedCall = expression.resolveToCall() ?: return
+                val context = expression.analyze(BodyResolveMode.PARTIAL)
+                val resolvedCall = expression.getResolvedCall(context) ?: return
                 val extensionReceiverType = resolvedCall.extensionReceiver?.type ?: return
                 if (!extensionReceiverType.isNullabilityFlexible()) return
                 val descriptor = resolvedCall.resultingDescriptor as? FunctionDescriptor ?: return
                 if (!descriptor.isInline) return
 
                 val receiverExpression = expression.receiverExpression
+                val dataFlowValueFactory = receiverExpression.getResolutionFacade().getFrontendService(DataFlowValueFactory::class.java)
+                val dataFlow = dataFlowValueFactory.createDataFlowValue(receiverExpression, extensionReceiverType, context, descriptor)
+                val stableNullability = context.getDataFlowInfoBefore(receiverExpression).getStableNullability(dataFlow)
+                if (!stableNullability.canBeNull()) return
+
                 holder.registerProblem(
                     receiverExpression,
                     "Call of inline function with nullable extension receiver can provoke NPE in Kotlin 1.2+",
diff --git a/idea/testData/multiFileInspections/platformExtensionReceiverOfInline/before/ToBoolean/src/Test.kt b/idea/testData/multiFileInspections/platformExtensionReceiverOfInline/before/ToBoolean/src/Test.kt
index b409c1e7aaf..7f1c5c4b5ce 100644
--- a/idea/testData/multiFileInspections/platformExtensionReceiverOfInline/before/ToBoolean/src/Test.kt
+++ b/idea/testData/multiFileInspections/platformExtensionReceiverOfInline/before/ToBoolean/src/Test.kt
@@ -6,6 +6,11 @@ fun test() {
 
     JavaClass.getNull().contentNotInline() // OK
     JavaClass.getMy().contentNonExtensionInlineFun() // OK
+
+    val res = JavaClass.getNull()
+    if (res != null) {
+        res.toBoolean() // OK: KT-29499
+    }
 }
 
 fun String.contentNotInline() {}