azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not search for getter usages for every "may be const" quickfix invocation

Browse Source 
It is a rather expensive operation which is critical for j2k

relates to #KT-33854
This commit is contained in:
Ilya Kirillov
2019-09-16 20:10:25 +03:00
parent 1b3c5f5d37
commit c6e0356a59
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/org/jetbrains/kotlin/idea/quickfix/AddConstModifierFix.kt
+2 -5
View File
@@ -100,16 +100,13 @@ object ConstFixFactory : KotlinSingleIntentionActionFactory() {
fun replaceReferencesToGetterByReferenceToField(property: KtProperty) { fun replaceReferencesToGetterByReferenceToField(property: KtProperty) {
val project = property.project val project = property.project
val getter = LightClassUtil.getLightClassPropertyMethods(property).getter val getter = LightClassUtil.getLightClassPropertyMethods(property).getter ?: return
val javaScope = GlobalSearchScope.getScopeRestrictedByFileTypes(project.allScope(), JavaFileType.INSTANCE) val javaScope = GlobalSearchScope.getScopeRestrictedByFileTypes(project.allScope(), JavaFileType.INSTANCE)
val getterUsages = if (getter != null)
ReferencesSearch.search(getter, javaScope).findAll()
else
emptyList()
val backingField = LightClassUtil.getLightClassPropertyMethods(property).backingField val backingField = LightClassUtil.getLightClassPropertyMethods(property).backingField
if (backingField != null) { if (backingField != null) {
val getterUsages = ReferencesSearch.search(getter, javaScope).findAll()
val factory = PsiElementFactory.SERVICE.getInstance(project) val factory = PsiElementFactory.SERVICE.getInstance(project)
val fieldFQName = backingField.containingClass!!.qualifiedName + "." + backingField.name val fieldFQName = backingField.containingClass!!.qualifiedName + "." + backingField.name