[Analysis API] Fix exceptions around type parameters being treated as callables

- `toResolvedCallableSymbol`: cast defensively because
  the resolved symbol might not be a callable symbol.
- `toKtCallInfo`: Check that the resolved symbol is actually callable.

^KTIJ-23003 fixed

analysis/analysis-api-fe10/tests-gen/org/jetbrains/kotlin/analysis/api/fe10/test/cases/generated/cases/components/callResolver/Fe10IdeNormalAnalysisSourceModuleResolveCallTestGenerated.java

@@ -898,6 +898,12 @@ public class Fe10IdeNormalAnalysisSourceModuleResolveCallTestGenerated extends A
         public void testGetterAssignment() throws Exception {
             runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/invalidCode/getterAssignment.kt");
         }
+
+        @Test
+        @TestMetadata("typeParameterAsValue.kt")
+        public void testTypeParameterAsValue() throws Exception {
+            runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/invalidCode/typeParameterAsValue.kt");
+        }
     }
 
     @Nested

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/components/KtFirCallResolver.kt

@@ -168,10 +168,20 @@ internal class KtFirCallResolver(
         return when (this) {
             is FirResolvable -> {
                 when (val calleeReference = calleeReference) {
-                    is FirResolvedNamedReference -> {
+                    is FirResolvedNamedReference -> when (calleeReference.resolvedSymbol) {
-                        val call = createKtCall(psi, this, null, resolveFragmentOfCall)
+                        // `calleeReference.resolvedSymbol` isn't guaranteed to be callable. For example, function type parameters used in
-                            ?: errorWithFirSpecificEntries("expect `createKtCall` to succeed for resolvable case", fir = this, psi = psi)
+                        // expression positions (e.g. `T` in `println(T)`) are parsed as `KtSimpleNameExpression` and built into
-                        KtSuccessCallInfo(call)
+                        // `FirPropertyAccessExpression` (which is `FirResolvable`).
+                        is FirCallableSymbol<*> -> {
+                            val call = createKtCall(psi, this, null, resolveFragmentOfCall)
+                                ?: errorWithFirSpecificEntries(
+                                    "expect `createKtCall` to succeed for resolvable case with callable symbol",
+                                    fir = this,
+                                    psi = psi
+                                )
+                            KtSuccessCallInfo(call)
+                        }
+                        else -> null
                     }
                     is FirErrorNamedReference -> {
                         val diagnostic = calleeReference.diagnostic

analysis/analysis-api-fir/tests-gen/org/jetbrains/kotlin/analysis/api/fir/test/cases/generated/cases/components/callResolver/FirIdeNormalAnalysisSourceModuleResolveCallTestGenerated.java

@@ -898,6 +898,12 @@ public class FirIdeNormalAnalysisSourceModuleResolveCallTestGenerated extends Ab
         public void testGetterAssignment() throws Exception {
             runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/invalidCode/getterAssignment.kt");
         }
+
+        @Test
+        @TestMetadata("typeParameterAsValue.kt")
+        public void testTypeParameterAsValue() throws Exception {
+            runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/invalidCode/typeParameterAsValue.kt");
+        }
     }
 
     @Nested

analysis/analysis-api-fir/tests-gen/org/jetbrains/kotlin/analysis/api/fir/test/cases/generated/cases/components/importOptimizer/FirIdeNormalAnalysisSourceModuleAnalysisApiImportOptimizerTestGenerated.java

@@ -127,6 +127,12 @@ public class FirIdeNormalAnalysisSourceModuleAnalysisApiImportOptimizerTestGener
             KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("analysis/analysis-api/testData/components/importOptimizer/analyseImports/referencesWithErrors"), Pattern.compile("^([^.]+)\\.kt$"), null, true);
         }
 
+        @Test
+        @TestMetadata("unusedTypeHiddenByTypeParameter_invalidAsArgument.kt")
+        public void testUnusedTypeHiddenByTypeParameter_invalidAsArgument() throws Exception {
+            runTest("analysis/analysis-api/testData/components/importOptimizer/analyseImports/referencesWithErrors/unusedTypeHiddenByTypeParameter_invalidAsArgument.kt");
+        }
+
         @Test
         @TestMetadata("usedConstructor_invalidArguments.kt")
         public void testUsedConstructor_invalidArguments() throws Exception {

analysis/analysis-api-standalone/tests-gen/org/jetbrains/kotlin/analysis/api/standalone/fir/test/cases/generated/cases/components/callResolver/FirStandaloneNormalAnalysisSourceModuleResolveCallTestGenerated.java

@@ -898,6 +898,12 @@ public class FirStandaloneNormalAnalysisSourceModuleResolveCallTestGenerated ext
         public void testGetterAssignment() throws Exception {
             runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/invalidCode/getterAssignment.kt");
         }
+
+        @Test
+        @TestMetadata("typeParameterAsValue.kt")
+        public void testTypeParameterAsValue() throws Exception {
+            runTest("analysis/analysis-api/testData/components/callResolver/resolveCall/invalidCode/typeParameterAsValue.kt");
+        }
     }
 
     @Nested

analysis/analysis-api-standalone/tests-gen/org/jetbrains/kotlin/analysis/api/standalone/fir/test/cases/generated/cases/components/importOptimizer/FirStandaloneNormalAnalysisSourceModuleAnalysisApiImportOptimizerTestGenerated.java

@@ -127,6 +127,12 @@ public class FirStandaloneNormalAnalysisSourceModuleAnalysisApiImportOptimizerTe
             KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("analysis/analysis-api/testData/components/importOptimizer/analyseImports/referencesWithErrors"), Pattern.compile("^([^.]+)\\.kt$"), null, true);
         }
 
+        @Test
+        @TestMetadata("unusedTypeHiddenByTypeParameter_invalidAsArgument.kt")
+        public void testUnusedTypeHiddenByTypeParameter_invalidAsArgument() throws Exception {
+            runTest("analysis/analysis-api/testData/components/importOptimizer/analyseImports/referencesWithErrors/unusedTypeHiddenByTypeParameter_invalidAsArgument.kt");
+        }
+
         @Test
         @TestMetadata("usedConstructor_invalidArguments.kt")
         public void testUsedConstructor_invalidArguments() throws Exception {

analysis/analysis-api/testData/components/callResolver/resolveCall/invalidCode/typeParameterAsValue.kt

@@ -0,0 +1,5 @@
+// See: KTIJ-23003 (KotlinExceptionWithAttachments)
+
+fun <T> test(x: Any) {
+    println(<expr>T</expr>)
+}

analysis/analysis-api/testData/components/callResolver/resolveCall/invalidCode/typeParameterAsValue.txt

@@ -0,0 +1 @@
+null

analysis/analysis-api/testData/components/importOptimizer/analyseImports/referencesWithErrors/unusedTypeHiddenByTypeParameter_invalidAsArgument.imports

@@ -0,0 +1 @@
+dependency.T

analysis/analysis-api/testData/components/importOptimizer/analyseImports/referencesWithErrors/unusedTypeHiddenByTypeParameter_invalidAsArgument.kt

@@ -0,0 +1,15 @@
+// See: KTIJ-23003 (ClassCastException)
+
+// FILE: main.kt
+package test
+
+import dependency.T
+
+fun <T> usage() {
+    println(T)
+}
+
+// FILE: dependency.kt
+package dependency
+
+class T(i: Int)

compiler/fir/tree/src/org/jetbrains/kotlin/fir/expressions/FirExpressionUtil.kt

@@ -74,7 +74,7 @@ fun FirExpression.toReference(): FirReference? {
 }
 
 fun FirExpression.toResolvedCallableSymbol(): FirCallableSymbol<*>? {
-    return toResolvedCallableReference()?.resolvedSymbol as FirCallableSymbol<*>?
+    return toResolvedCallableReference()?.resolvedSymbol as? FirCallableSymbol<*>?
 }
 
 fun FirReference.toResolvedCallableSymbol(): FirCallableSymbol<*>? {