From c5a81691fb96a4b461846ca7e97a3976695751e6 Mon Sep 17 00:00:00 2001 From: Mikhail Glukhikh Date: Thu, 27 Jul 2017 14:38:01 +0300 Subject: [PATCH] Partial code cleanup: can be private and some others applied --- .../kotlin/ant/KotlinCompilerAdapter.kt | 4 +- .../kotlin/codegen/DefaultCallArgs.kt | 4 +- .../kotlin/codegen/InlineCycleReporter.kt | 4 +- .../JvmStaticInCompanionObjectGenerator.kt | 6 +- .../codegen/PropertyReferenceCodegen.kt | 6 +- .../jetbrains/kotlin/codegen/StackValue.kt | 2 +- .../context/DefaultImplsClassContext.kt | 6 +- .../codegen/context/InlineLambdaContext.kt | 4 +- .../inline/CoveringTryCatchNodeProcessor.kt | 2 +- .../codegen/inline/DeferredMethodVisitor.kt | 2 +- .../codegen/inline/InlinedLambdaRemapper.kt | 2 +- .../kotlin/codegen/inline/LambdaInfo.kt | 2 +- .../codegen/inline/ObjectTransformer.kt | 2 +- .../codegen/inline/ReifiedTypeInliner.kt | 6 +- .../jetbrains/kotlin/codegen/inline/SMAP.kt | 8 +- .../codegen/inline/TransformationInfo.kt | 2 +- .../kotlin/codegen/inline/TypeRemapper.kt | 2 +- .../DeadCodeEliminationMethodTransformer.kt | 2 +- .../optimization/boxing/BoxedBasicValue.kt | 4 +- .../optimization/common/MethodAnalyzer.kt | 2 +- .../fixStack/StackTransformationUtils.kt | 2 +- .../transformer/CompositeMethodTransformer.kt | 2 +- .../cli/common/repl/AggregatedReplState.kt | 7 +- .../repl/GenericReplCompilingEvaluator.kt | 2 +- .../cli/common/repl/GenericReplEvaluator.kt | 9 ++- .../jetbrains/kotlin/container/Container.kt | 2 +- .../org/jetbrains/kotlin/container/Resolve.kt | 2 +- .../org/jetbrains/kotlin/container/Storage.kt | 2 +- .../impl/classFiles/BinaryJavaClass.kt | 2 +- .../IncrementalPackageFragmentProvider.kt | 2 +- .../checkers/JvmSimpleNameBacktickChecker.kt | 2 +- ...inScriptDefinitionFromAnnotatedTemplate.kt | 2 +- .../kotlin/analyzer/AnalyzerFacade.kt | 4 +- .../jumps/NondeterministicJumpInstruction.kt | 2 +- .../jumps/ThrowExceptionInstruction.kt | 2 +- .../jetbrains/kotlin/kdoc/psi/impl/KDocTag.kt | 2 +- .../org/jetbrains/kotlin/psi/userDataUtil.kt | 6 +- .../kotlin/resolve/AnnotationChecker.kt | 2 +- .../kotlin/resolve/ModifiersChecker.kt | 4 +- .../resolve/calls/CallExpressionResolver.kt | 2 +- .../resolve/calls/GenericCandidateResolver.kt | 2 +- .../calls/checkers/UnderscoreUsageChecker.kt | 2 +- .../calls/smartcasts/SmartCastManager.kt | 9 +-- .../evaluate/ConstantExpressionEvaluator.kt | 2 +- .../resolve/inline/InlineAnalyzerExtension.kt | 2 +- ...ombinedPackageMemberDeclarationProvider.kt | 4 +- .../descriptors/AbstractLazyMemberScope.kt | 2 +- .../IncrementalJvmCompilerRunner.kt | 2 +- .../backend/jvm/codegen/ClassCodegen.kt | 12 ++- .../backend/jvm/codegen/FunctionCodegen.kt | 2 +- .../jvm/descriptors/KnownDescriptors.kt | 2 +- .../descriptors/SpecialDescriptorsFactory.kt | 4 +- .../backend/jvm/lower/BridgeLowering.kt | 2 +- .../jvm/lower/SyntheticAccessorLowering.kt | 2 +- .../ir2cfg/generators/FunctionGenerator.kt | 2 +- .../kotlin/psi2ir/PsiSourceManager.kt | 4 +- .../psi2ir/generators/FunctionGenerator.kt | 2 +- .../kotlin/ir/util/DeepCopySymbolsRemapper.kt | 2 +- .../jetbrains/kotlin/ir/util/DumpIrTree.kt | 8 +- .../lazy/descriptors/DeclaredMemberIndex.kt | 5 +- .../kotlin/descriptors/EffectiveVisibility.kt | 2 +- .../kotlin/renderer/ClassifierNamePolicy.kt | 7 +- .../idea/caches/KotlinShortNamesCache.kt | 4 +- .../resolve/IDELightClassGenerationSupport.kt | 2 +- .../idea/caches/resolve/ScriptModuleInfos.kt | 7 +- .../classFile/KotlinClsStubBuilder.kt | 2 +- .../inspections/IntentionBasedInspection.kt | 2 +- .../SyntheticPropertyAccessorReference.kt | 2 +- .../idea/search/PsiBasedClassResolver.kt | 2 +- .../inspection/IllegalIdentifierInspection.kt | 4 +- .../idea/completion/KeywordCompletion.kt | 16 ++-- .../idea/completion/OperatorNameCompletion.kt | 2 +- .../completion/ReferenceVariantsCollector.kt | 4 +- .../completion/ToFromOriginalFileMapper.kt | 20 ++--- .../kotlin/idea/completion/smart/Utils.kt | 5 +- .../KotlinJsr223JvmScriptEngine4Idea.kt | 2 +- .../idea/KotlinQuickDocumentationProvider.kt | 2 +- .../SearchNotPropertyCandidatesAction.kt | 2 +- .../copy/PlainTextPasteImportResolver.kt | 6 +- .../debugger/DebuggerClassNameProvider.kt | 2 +- .../debugger/InlineCallableUsagesSearcher.kt | 5 +- .../breakpoints/KotlinFieldBreakpoint.kt | 2 +- .../DelegatedPropertyFieldDescriptor.kt | 2 +- ...otlinClassWithDelegatedPropertyRenderer.kt | 2 +- .../KotlinMultilineStringEnterHandler.kt | 8 +- .../KotlinMissingForOrWhileBodyFixer.kt | 2 +- .../fixers/KotlinMissingWhenBodyFixer.kt | 2 +- .../idea/facet/KotlinFacetEditorGeneralTab.kt | 10 +-- .../findUsages/KotlinUsageTypeProvider.kt | 75 +++++++++---------- .../idea/injection/KotlinLanguageInjector.kt | 3 +- .../ConvertLambdaToReferenceIntention.kt | 2 +- ...tPrimaryConstructorToSecondaryIntention.kt | 2 +- .../ConvertReferenceToLambdaIntention.kt | 2 +- .../MovePropertyToClassBodyIntention.kt | 12 +-- .../MovePropertyToConstructorIntention.kt | 2 +- .../UsePropertyAccessSyntaxIntention.kt | 2 +- .../BranchedFoldingUtils.kt | 4 +- .../loopToCallChain/sequence/Condition.kt | 2 +- .../internal/KotlinDecompilerServiceImpl.kt | 4 +- .../kotlin/idea/kdoc/KDocRenderer.kt | 8 +- .../kotlin/idea/quickfix/AddLoopLabelFix.kt | 5 +- .../AddReifiedToTypeParameterOfFunctionFix.kt | 2 +- .../AddTypeAnnotationToValueParameterFix.kt | 2 +- .../idea/quickfix/ChangeVisibilityFix.kt | 4 +- .../CreateCallableFromUsageFix.kt | 2 +- .../CreateCallableMemberFromUsageFactory.kt | 2 +- .../createClass/CreateClassFromUsageFix.kt | 5 +- .../CreateTypeAliasFromUsageFix.kt | 2 +- .../ReplaceProtectedToPublishedApiCallFix.kt | 2 +- .../changeSignature/KotlinChangeSignature.kt | 14 ++-- .../ui/KotlinChangePropertySignatureDialog.kt | 4 +- .../ui/KotlinChangeSignatureDialog.kt | 2 +- .../usages/KotlinFunctionCallUsage.kt | 2 +- .../KotlinExtractSuperHandlerBase.kt | 2 +- .../ExtractKotlinFunctionHandler.kt | 2 +- .../KotlinIntroduceParameterHandler.kt | 2 +- .../IntroduceTypeAliasHandler.kt | 2 +- .../KotlinIntroduceVariableHandler.kt | 2 +- .../move/AutocreatingPsiDirectoryWrapper.kt | 4 +- ...KotlinAwareMoveFilesOrDirectoriesDialog.kt | 2 +- .../kotlin/idea/refactoring/move/moveUtils.kt | 4 +- .../refactoring/pullUp/KotlinPullUpData.kt | 2 +- .../pushDown/KotlinPushDownDialog.kt | 2 +- .../rename/RenameKotlinPropertyProcessor.kt | 2 +- .../kotlin/j2k/JavaToKotlinTranslator.kt | 2 +- .../AnnotationCollectorExtension.kt | 2 +- 126 files changed, 270 insertions(+), 258 deletions(-) diff --git a/ant/src/org/jetbrains/kotlin/ant/KotlinCompilerAdapter.kt b/ant/src/org/jetbrains/kotlin/ant/KotlinCompilerAdapter.kt index aa6b3e0faeb..89bc532d71b 100644 --- a/ant/src/org/jetbrains/kotlin/ant/KotlinCompilerAdapter.kt +++ b/ant/src/org/jetbrains/kotlin/ant/KotlinCompilerAdapter.kt @@ -39,9 +39,7 @@ class KotlinCompilerAdapter : Javac13() { return argument } - override fun getSupportedFileExtensions(): Array { - return super.getSupportedFileExtensions() + KOTLIN_EXTENSIONS - } + override fun getSupportedFileExtensions(): Array = super.getSupportedFileExtensions() + KOTLIN_EXTENSIONS @Throws(BuildException::class) override fun execute(): Boolean { diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/DefaultCallArgs.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/DefaultCallArgs.kt index 26b5add025b..1d2ac95b713 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/DefaultCallArgs.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/DefaultCallArgs.kt @@ -22,7 +22,7 @@ import java.util.* class DefaultCallArgs(val size: Int) { - val bits: BitSet = BitSet(size) + private val bits: BitSet = BitSet(size) fun mark(index: Int) { assert (index < size) { @@ -39,7 +39,7 @@ class DefaultCallArgs(val size: Int) { val masks = ArrayList(1) var mask = 0 - for (i in 0..size - 1) { + for (i in 0 until size) { if (i != 0 && i % Integer.SIZE == 0) { masks.add(mask) mask = 0 diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/InlineCycleReporter.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/InlineCycleReporter.kt index f11f31755f2..f061dce31d1 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/InlineCycleReporter.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/InlineCycleReporter.kt @@ -23,9 +23,9 @@ import org.jetbrains.kotlin.diagnostics.DiagnosticSink import org.jetbrains.kotlin.diagnostics.Errors import org.jetbrains.kotlin.resolve.calls.model.ResolvedCall -class InlineCycleReporter(val diagnostics: DiagnosticSink) { +class InlineCycleReporter(private val diagnostics: DiagnosticSink) { - val processingFunctions = linkedMapOf() + private val processingFunctions = linkedMapOf() fun enterIntoInlining(call: ResolvedCall<*>?): Boolean { //null call for default method inlining diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/JvmStaticInCompanionObjectGenerator.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/JvmStaticInCompanionObjectGenerator.kt index 3cd59428508..fb6f3fbc2f5 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/JvmStaticInCompanionObjectGenerator.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/JvmStaticInCompanionObjectGenerator.kt @@ -25,9 +25,9 @@ import org.jetbrains.kotlin.resolve.jvm.diagnostics.Synthetic import org.jetbrains.kotlin.resolve.jvm.jvmSignature.JvmMethodSignature class JvmStaticInCompanionObjectGenerator( - val descriptor: FunctionDescriptor, - val declarationOrigin: JvmDeclarationOrigin, - val state: GenerationState, + private val descriptor: FunctionDescriptor, + private val declarationOrigin: JvmDeclarationOrigin, + private val state: GenerationState, parentBodyCodegen: ImplementationBodyCodegen ) : Function2 { private val typeMapper = state.typeMapper diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/PropertyReferenceCodegen.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/PropertyReferenceCodegen.kt index fd186b74c0c..f270b7e14d1 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/PropertyReferenceCodegen.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/PropertyReferenceCodegen.kt @@ -62,7 +62,7 @@ class PropertyReferenceCodegen( private val isLocalDelegatedProperty = target is LocalVariableDescriptor - val getFunction = + private val getFunction = if (isLocalDelegatedProperty) (localVariableDescriptorForReference as VariableDescriptorWithAccessors).getter!! else @@ -250,13 +250,13 @@ class PropertyReferenceCodegen( class PropertyReferenceGenerationStrategy( val isGetter: Boolean, - val originalFunctionDesc: FunctionDescriptor, + private val originalFunctionDesc: FunctionDescriptor, val target: VariableDescriptor, val asmType: Type, val receiverType: Type?, val expression: KtElement, state: GenerationState, - val isInliningStrategy: Boolean + private val isInliningStrategy: Boolean ) : FunctionGenerationStrategy.CodegenBased(state) { override fun doGenerateBody(codegen: ExpressionCodegen, signature: JvmMethodSignature) { diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/StackValue.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/StackValue.kt index df4b15e872b..799b30efd49 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/StackValue.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/StackValue.kt @@ -21,7 +21,7 @@ import org.jetbrains.org.objectweb.asm.commons.InstructionAdapter class CoercionValue( val value: StackValue, - val castType: Type + private val castType: Type ) : StackValue(castType, value.canHaveSideEffects()) { override fun putSelector(type: Type, v: InstructionAdapter) { diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/context/DefaultImplsClassContext.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/context/DefaultImplsClassContext.kt index a395941ca14..69cc02e57ef 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/context/DefaultImplsClassContext.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/context/DefaultImplsClassContext.kt @@ -28,12 +28,10 @@ class DefaultImplsClassContext( contextKind: OwnerKind, parentContext: CodegenContext<*>?, localLookup: ((DeclarationDescriptor) -> Boolean)?, - val interfaceContext: ClassContext + private val interfaceContext: ClassContext ) : ClassContext(typeMapper, contextDescriptor, contextKind, parentContext, localLookup) { - override fun getCompanionObjectContext(): CodegenContext<*>? { - return interfaceContext.companionObjectContext - } + override fun getCompanionObjectContext(): CodegenContext<*>? = interfaceContext.companionObjectContext override fun getAccessors(): Collection> { val accessors = super.getAccessors() diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/context/InlineLambdaContext.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/context/InlineLambdaContext.kt index 934c636795b..b1bcb3a6168 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/context/InlineLambdaContext.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/context/InlineLambdaContext.kt @@ -25,8 +25,8 @@ class InlineLambdaContext( contextKind: OwnerKind, parentContext: CodegenContext<*>, closure: MutableClosure?, - val isCrossInline: Boolean, - val isPropertyReference: Boolean + private val isCrossInline: Boolean, + private val isPropertyReference: Boolean ) : MethodContext(functionDescriptor, contextKind, parentContext, closure, false) { override fun getFirstCrossInlineOrNonInlineContext(): CodegenContext<*> { diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/CoveringTryCatchNodeProcessor.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/CoveringTryCatchNodeProcessor.kt index 7bcc88e3793..3b8c35147b2 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/CoveringTryCatchNodeProcessor.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/CoveringTryCatchNodeProcessor.kt @@ -141,7 +141,7 @@ class IntervalMetaInfo> { return splitPair } - fun getInterval(curIns: LabelNode, isOpen: Boolean) = + private fun getInterval(curIns: LabelNode, isOpen: Boolean) = if (isOpen) intervalStarts.get(curIns) else intervalEnds.get(curIns) } diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/DeferredMethodVisitor.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/DeferredMethodVisitor.kt index 3c34356cfd8..6ff841d43c2 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/DeferredMethodVisitor.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/DeferredMethodVisitor.kt @@ -21,7 +21,7 @@ import org.jetbrains.org.objectweb.asm.tree.MethodNode class DeferredMethodVisitor( val intermediate: MethodNode, - val resultNode: () -> MethodVisitor + private val resultNode: () -> MethodVisitor ) : MethodVisitor(API, intermediate) { override fun visitEnd() { diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/InlinedLambdaRemapper.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/InlinedLambdaRemapper.kt index e130e176602..a8bfcd099e0 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/InlinedLambdaRemapper.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/InlinedLambdaRemapper.kt @@ -24,7 +24,7 @@ class InlinedLambdaRemapper( originalLambdaInternalName: String, parent: FieldRemapper, methodParams: Parameters, - val isDefaultBoundCallableReference: Boolean + private val isDefaultBoundCallableReference: Boolean ) : FieldRemapper(originalLambdaInternalName, parent, methodParams) { public override fun canProcess(fieldOwner: String, fieldName: String, isFolding: Boolean) = diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/LambdaInfo.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/LambdaInfo.kt index 0995b1a3d38..2f231263413 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/LambdaInfo.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/LambdaInfo.kt @@ -84,7 +84,7 @@ abstract class LambdaInfo(@JvmField val isCrossInline: Boolean) : LabelOwner { class DefaultLambda( override val lambdaClassType: Type, - val capturedArgs: Array, + private val capturedArgs: Array, val parameterDescriptor: ValueParameterDescriptor, val offset: Int, val needReification: Boolean diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/ObjectTransformer.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/ObjectTransformer.kt index 04dbc390942..b6ae7a4c404 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/ObjectTransformer.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/ObjectTransformer.kt @@ -53,7 +53,7 @@ abstract class ObjectTransformer(@JvmField val trans class WhenMappingTransformer( whenObjectRegenerationInfo: WhenMappingTransformationInfo, - val inliningContext: InliningContext + private val inliningContext: InliningContext ) : ObjectTransformer(whenObjectRegenerationInfo, inliningContext.state) { override fun doTransform(parentRemapper: FieldRemapper): InlineResult { diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/ReifiedTypeInliner.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/ReifiedTypeInliner.kt index 7d97370fd22..d8a6c811ba3 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/ReifiedTypeInliner.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/ReifiedTypeInliner.kt @@ -16,13 +16,11 @@ package org.jetbrains.kotlin.codegen.inline -import org.jetbrains.kotlin.codegen.AsmUtil import org.jetbrains.kotlin.codegen.context.MethodContext import org.jetbrains.kotlin.codegen.generateAsCast import org.jetbrains.kotlin.codegen.generateIsCheck import org.jetbrains.kotlin.codegen.intrinsics.IntrinsicMethods import org.jetbrains.kotlin.codegen.optimization.common.intConstant -import org.jetbrains.kotlin.codegen.optimization.removeNodeGetNext import org.jetbrains.kotlin.types.KotlinType import org.jetbrains.kotlin.types.TypeUtils import org.jetbrains.kotlin.types.Variance @@ -34,7 +32,7 @@ import org.jetbrains.org.objectweb.asm.commons.InstructionAdapter import org.jetbrains.org.objectweb.asm.tree.* class ReificationArgument( - val parameterName: String, val nullable: Boolean, val arrayDepth: Int + val parameterName: String, val nullable: Boolean, private val arrayDepth: Int ) { fun asString() = "[".repeat(arrayDepth) + parameterName + (if (nullable) "?" else "") fun combine(replacement: ReificationArgument) = @@ -302,7 +300,7 @@ class TypeParameterMapping( ) class ReifiedTypeParametersUsages { - val usedTypeParameters: MutableSet = hashSetOf() + private val usedTypeParameters: MutableSet = hashSetOf() fun wereUsedReifiedParameters(): Boolean = usedTypeParameters.isNotEmpty() diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/SMAP.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/SMAP.kt index a27338ac41d..4f702d661c7 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/SMAP.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/SMAP.kt @@ -28,7 +28,7 @@ val KOTLIN_DEBUG_STRATA_NAME = "KotlinDebug" class SMAPBuilder( val source: String, val path: String, - val fileMappings: List + private val fileMappings: List ) { private val header = "SMAP\n$source\nKotlin" @@ -91,9 +91,9 @@ open class NestedSourceMapper( override val parent: SourceMapper, val ranges: List, sourceInfo: SourceInfo ) : DefaultSourceMapper(sourceInfo) { - val visitedLines = TIntIntHashMap() + private val visitedLines = TIntIntHashMap() - var lastVisitedRange: RangeMapping? = null + private var lastVisitedRange: RangeMapping? = null override fun mapLineNumber(lineNumber: Int): Int { val mappedLineNumber = visitedLines.get(lineNumber) @@ -115,7 +115,7 @@ open class NestedSourceMapper( } } - fun findMappingIfExists(lineNumber: Int): RangeMapping? { + private fun findMappingIfExists(lineNumber: Int): RangeMapping? { val index = ranges.binarySearch(RangeMapping(lineNumber, lineNumber, 1), Comparator { value, key -> if (key.dest in value) 0 else RangeMapping.Comparator.compare(value, key) diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/TransformationInfo.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/TransformationInfo.kt index 740faddd7af..8e7775c39c3 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/TransformationInfo.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/TransformationInfo.kt @@ -40,7 +40,7 @@ interface TransformationInfo { class WhenMappingTransformationInfo( override val oldClassName: String, parentNameGenerator: NameGenerator, - val alreadyRegenerated: Boolean, + private val alreadyRegenerated: Boolean, val fieldNode: FieldInsnNode ) : TransformationInfo { diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/TypeRemapper.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/TypeRemapper.kt index 9aae494805f..cf6fe1366e2 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/TypeRemapper.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/inline/TypeRemapper.kt @@ -24,7 +24,7 @@ class TypeParameter(val oldName: String, val newName: String?, val isReified: Bo class TypeRemapper private constructor( private val typeMapping: MutableMap, val parent: TypeRemapper? = null, - val isRootInlineLambda: Boolean = false + private val isRootInlineLambda: Boolean = false ) { private val additionalMappings = hashMapOf() private val typeParametersMapping = hashMapOf() diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/DeadCodeEliminationMethodTransformer.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/DeadCodeEliminationMethodTransformer.kt index 8b2c5660305..aae00a45028 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/DeadCodeEliminationMethodTransformer.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/DeadCodeEliminationMethodTransformer.kt @@ -88,7 +88,7 @@ class DeadCodeEliminationMethodTransformer : MethodTransformer() { return true } - class Result(val removedNodes: Set) { + class Result(private val removedNodes: Set) { fun hasRemovedAnything() = removedNodes.isNotEmpty() fun isRemoved(node: AbstractInsnNode) = removedNodes.contains(node) fun isAlive(node: AbstractInsnNode) = !isRemoved(node) diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/boxing/BoxedBasicValue.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/boxing/BoxedBasicValue.kt index 7908d4cf5c1..aaea372fc95 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/boxing/BoxedBasicValue.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/boxing/BoxedBasicValue.kt @@ -45,7 +45,7 @@ class CleanBoxedValue( } -class TaintedBoxedValue(val boxedBasicValue: CleanBoxedValue) : BoxedBasicValue(boxedBasicValue.type) { +class TaintedBoxedValue(private val boxedBasicValue: CleanBoxedValue) : BoxedBasicValue(boxedBasicValue.type) { override val descriptor get() = boxedBasicValue.descriptor override fun taint(): BoxedBasicValue = this @@ -53,7 +53,7 @@ class TaintedBoxedValue(val boxedBasicValue: CleanBoxedValue) : BoxedBasicValue( class BoxedValueDescriptor( - val boxedType: Type, + private val boxedType: Type, val boxingInsn: AbstractInsnNode, val progressionIterator: ProgressionIteratorBasicValue? ) { diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/common/MethodAnalyzer.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/common/MethodAnalyzer.kt index c4903835bc1..53aeb4b86df 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/common/MethodAnalyzer.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/common/MethodAnalyzer.kt @@ -67,7 +67,7 @@ open class MethodAnalyzer( protected val interpreter: Interpreter ) { val instructions: InsnList = method.instructions - val nInsns: Int = instructions.size() + private val nInsns: Int = instructions.size() val frames: Array?> = arrayOfNulls(nInsns) diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/fixStack/StackTransformationUtils.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/fixStack/StackTransformationUtils.kt index 001fdd93c8e..85a33442d69 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/fixStack/StackTransformationUtils.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/fixStack/StackTransformationUtils.kt @@ -57,7 +57,7 @@ class SavedStackDescriptor( val savedValues: List, val firstLocalVarIndex: Int ) { - val savedValuesSize = savedValues.fold(0, { size, value -> size + value.size }) + private val savedValuesSize = savedValues.fold(0, { size, value -> size + value.size }) val firstUnusedLocalVarIndex = firstLocalVarIndex + savedValuesSize override fun toString(): String = diff --git a/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/transformer/CompositeMethodTransformer.kt b/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/transformer/CompositeMethodTransformer.kt index 153d5137433..5726321e506 100644 --- a/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/transformer/CompositeMethodTransformer.kt +++ b/compiler/backend/src/org/jetbrains/kotlin/codegen/optimization/transformer/CompositeMethodTransformer.kt @@ -18,7 +18,7 @@ package org.jetbrains.kotlin.codegen.optimization.transformer import org.jetbrains.org.objectweb.asm.tree.MethodNode -open class CompositeMethodTransformer(vararg val transformers: MethodTransformer) : MethodTransformer() { +open class CompositeMethodTransformer(private vararg val transformers: MethodTransformer) : MethodTransformer() { override fun transform(internalClassName: String, methodNode: MethodNode) { transformers.forEach { it.transform(internalClassName, methodNode) } } diff --git a/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/repl/AggregatedReplState.kt b/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/repl/AggregatedReplState.kt index dc7747dc686..1d82dd8d0ae 100644 --- a/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/repl/AggregatedReplState.kt +++ b/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/repl/AggregatedReplState.kt @@ -20,8 +20,11 @@ import java.util.concurrent.locks.ReentrantReadWriteLock import kotlin.concurrent.read import kotlin.concurrent.write -open class AggregatedReplStateHistory(val history1: IReplStageHistory, val history2: IReplStageHistory, override val lock: ReentrantReadWriteLock = ReentrantReadWriteLock()) - : IReplStageHistory>, AbstractList>>() +open class AggregatedReplStateHistory( + private val history1: IReplStageHistory, + private val history2: IReplStageHistory, + override val lock: ReentrantReadWriteLock = ReentrantReadWriteLock() +) : IReplStageHistory>, AbstractList>>() { override val size: Int get() = minOf(history1.size, history2.size) diff --git a/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/repl/GenericReplCompilingEvaluator.kt b/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/repl/GenericReplCompilingEvaluator.kt index 6da1650ecb6..031e097e3cd 100644 --- a/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/repl/GenericReplCompilingEvaluator.kt +++ b/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/repl/GenericReplCompilingEvaluator.kt @@ -26,7 +26,7 @@ class GenericReplCompilingEvaluator(val compiler: ReplCompiler, private val fallbackScriptArgs: ScriptArgsWithTypes? = null, repeatingMode: ReplRepeatingMode = ReplRepeatingMode.REPEAT_ONLY_MOST_RECENT ) : ReplFullEvaluator { - val evaluator = GenericReplEvaluator(baseClasspath, baseClassloader, fallbackScriptArgs, repeatingMode) + private val evaluator = GenericReplEvaluator(baseClasspath, baseClassloader, fallbackScriptArgs, repeatingMode) override fun createState(lock: ReentrantReadWriteLock): IReplStageState<*> = AggregatedReplStageState(compiler.createState(lock), evaluator.createState(lock), lock) diff --git a/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/repl/GenericReplEvaluator.kt b/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/repl/GenericReplEvaluator.kt index bf4642f3f5d..529c2b6370f 100644 --- a/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/repl/GenericReplEvaluator.kt +++ b/compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/repl/GenericReplEvaluator.kt @@ -22,10 +22,11 @@ import java.lang.reflect.InvocationTargetException import java.util.concurrent.locks.ReentrantReadWriteLock import kotlin.concurrent.write -open class GenericReplEvaluator(val baseClasspath: Iterable, - val baseClassloader: ClassLoader? = Thread.currentThread().contextClassLoader, - protected val fallbackScriptArgs: ScriptArgsWithTypes? = null, - protected val repeatingMode: ReplRepeatingMode = ReplRepeatingMode.REPEAT_ONLY_MOST_RECENT +open class GenericReplEvaluator( + val baseClasspath: Iterable, + val baseClassloader: ClassLoader? = Thread.currentThread().contextClassLoader, + protected val fallbackScriptArgs: ScriptArgsWithTypes? = null, + protected val repeatingMode: ReplRepeatingMode = ReplRepeatingMode.REPEAT_ONLY_MOST_RECENT ) : ReplEvaluator { override fun createState(lock: ReentrantReadWriteLock): IReplStageState<*> = GenericReplEvaluatorState(baseClasspath, baseClassloader, lock) diff --git a/compiler/container/src/org/jetbrains/kotlin/container/Container.kt b/compiler/container/src/org/jetbrains/kotlin/container/Container.kt index 7a64e3fccc9..f71176e272b 100644 --- a/compiler/container/src/org/jetbrains/kotlin/container/Container.kt +++ b/compiler/container/src/org/jetbrains/kotlin/container/Container.kt @@ -43,7 +43,7 @@ class StorageComponentContainer(id: String, parent: StorageComponentContainer? = val parentContext = parent?.let { ComponentResolveContext(it, DynamicComponentDescriptor) } ComponentResolveContext(this, DynamicComponentDescriptor, parentContext) } - val componentStorage: ComponentStorage = ComponentStorage(id, parent?.componentStorage) + private val componentStorage: ComponentStorage = ComponentStorage(id, parent?.componentStorage) override fun createResolveContext(requestingDescriptor: ValueDescriptor): ValueResolveContext { if (requestingDescriptor == DynamicComponentDescriptor) // cache unknown component descriptor diff --git a/compiler/container/src/org/jetbrains/kotlin/container/Resolve.kt b/compiler/container/src/org/jetbrains/kotlin/container/Resolve.kt index 50e4bfe8c7c..133c7c032c9 100644 --- a/compiler/container/src/org/jetbrains/kotlin/container/Resolve.kt +++ b/compiler/container/src/org/jetbrains/kotlin/container/Resolve.kt @@ -42,7 +42,7 @@ class ComponentResolveContext( class ConstructorBinding(val constructor: Constructor<*>, val argumentDescriptors: List) -class MethodBinding(val method: Method, val argumentDescriptors: List) { +class MethodBinding(val method: Method, private val argumentDescriptors: List) { fun invoke(instance: Any) { val arguments = computeArguments(argumentDescriptors).toTypedArray() method.invoke(instance, *arguments) diff --git a/compiler/container/src/org/jetbrains/kotlin/container/Storage.kt b/compiler/container/src/org/jetbrains/kotlin/container/Storage.kt index 7f88e8bcfbd..486b00a33aa 100644 --- a/compiler/container/src/org/jetbrains/kotlin/container/Storage.kt +++ b/compiler/container/src/org/jetbrains/kotlin/container/Storage.kt @@ -35,7 +35,7 @@ enum class ComponentStorageState { internal class InvalidCardinalityException(message: String, val descriptors: Collection) : Exception(message) -class ComponentStorage(val myId: String, parent: ComponentStorage?) : ValueResolver { +class ComponentStorage(private val myId: String, parent: ComponentStorage?) : ValueResolver { var state = ComponentStorageState.Initial private val registry = ComponentRegistry() init { diff --git a/compiler/frontend.java/src/org/jetbrains/kotlin/load/java/structure/impl/classFiles/BinaryJavaClass.kt b/compiler/frontend.java/src/org/jetbrains/kotlin/load/java/structure/impl/classFiles/BinaryJavaClass.kt index 11d4b1e3611..e5335c657f9 100644 --- a/compiler/frontend.java/src/org/jetbrains/kotlin/load/java/structure/impl/classFiles/BinaryJavaClass.kt +++ b/compiler/frontend.java/src/org/jetbrains/kotlin/load/java/structure/impl/classFiles/BinaryJavaClass.kt @@ -39,7 +39,7 @@ class BinaryJavaClass( override val outerClass: JavaClass?, classContent: ByteArray? = null ) : ClassVisitor(ASM_API_VERSION_FOR_CLASS_READING), VirtualFileBoundJavaClass, BinaryJavaModifierListOwner, MapBasedJavaAnnotationOwner { - lateinit var myInternalName: String + private lateinit var myInternalName: String override val annotations: MutableCollection = ContainerUtil.newSmartList() override lateinit var typeParameters: List diff --git a/compiler/frontend.java/src/org/jetbrains/kotlin/load/kotlin/incremental/IncrementalPackageFragmentProvider.kt b/compiler/frontend.java/src/org/jetbrains/kotlin/load/kotlin/incremental/IncrementalPackageFragmentProvider.kt index c3fbe33af2e..8273f90c2cd 100644 --- a/compiler/frontend.java/src/org/jetbrains/kotlin/load/kotlin/incremental/IncrementalPackageFragmentProvider.kt +++ b/compiler/frontend.java/src/org/jetbrains/kotlin/load/kotlin/incremental/IncrementalPackageFragmentProvider.kt @@ -47,7 +47,7 @@ class IncrementalPackageFragmentProvider( val target: TargetId, private val kotlinClassFinder: KotlinClassFinder ) : PackageFragmentProvider { - val fqNameToPackageFragment = + private val fqNameToPackageFragment = PackagePartClassUtils.getFilesWithCallables(sourceFiles) .mapTo(hashSetOf()) { it.packageFqName } .keysToMap(this::IncrementalPackageFragment) diff --git a/compiler/frontend.java/src/org/jetbrains/kotlin/resolve/jvm/checkers/JvmSimpleNameBacktickChecker.kt b/compiler/frontend.java/src/org/jetbrains/kotlin/resolve/jvm/checkers/JvmSimpleNameBacktickChecker.kt index 7757bf36fd4..cba0a368ee1 100644 --- a/compiler/frontend.java/src/org/jetbrains/kotlin/resolve/jvm/checkers/JvmSimpleNameBacktickChecker.kt +++ b/compiler/frontend.java/src/org/jetbrains/kotlin/resolve/jvm/checkers/JvmSimpleNameBacktickChecker.kt @@ -47,7 +47,7 @@ object JvmSimpleNameBacktickChecker : IdentifierChecker { } } - fun checkNamed(declaration: KtNamedDeclaration, diagnosticHolder: DiagnosticSink) { + private fun checkNamed(declaration: KtNamedDeclaration, diagnosticHolder: DiagnosticSink) { val name = declaration.name ?: return val element = declaration.nameIdentifier ?: declaration diff --git a/compiler/frontend.script/src/org/jetbrains/kotlin/script/KotlinScriptDefinitionFromAnnotatedTemplate.kt b/compiler/frontend.script/src/org/jetbrains/kotlin/script/KotlinScriptDefinitionFromAnnotatedTemplate.kt index 0586765a73c..8d6d16d8803 100644 --- a/compiler/frontend.script/src/org/jetbrains/kotlin/script/KotlinScriptDefinitionFromAnnotatedTemplate.kt +++ b/compiler/frontend.script/src/org/jetbrains/kotlin/script/KotlinScriptDefinitionFromAnnotatedTemplate.kt @@ -93,7 +93,7 @@ open class KotlinScriptDefinitionFromAnnotatedTemplate( } } - val samWithReceiverAnnotations: List? by lazy { + private val samWithReceiverAnnotations: List? by lazy { takeUnlessError { template.annotations.firstIsInstanceOrNull()?.annotations?.toList() } ?: takeUnlessError { template.annotations.firstIsInstanceOrNull()?.annotations?.toList() } } diff --git a/compiler/frontend/src/org/jetbrains/kotlin/analyzer/AnalyzerFacade.kt b/compiler/frontend/src/org/jetbrains/kotlin/analyzer/AnalyzerFacade.kt index eaa3e2fde9d..0d691b15185 100644 --- a/compiler/frontend/src/org/jetbrains/kotlin/analyzer/AnalyzerFacade.kt +++ b/compiler/frontend/src/org/jetbrains/kotlin/analyzer/AnalyzerFacade.kt @@ -75,8 +75,8 @@ class EmptyResolverForProject : ResolverForProject() { class ResolverForProjectImpl( private val debugName: String, - val descriptorByModule: Map, - val delegateResolver: ResolverForProject = EmptyResolverForProject() + private val descriptorByModule: Map, + private val delegateResolver: ResolverForProject = EmptyResolverForProject() ) : ResolverForProject() { override fun tryGetResolverForModule(moduleInfo: M): ResolverForModule? { if (!isCorrectModuleInfo(moduleInfo)) { diff --git a/compiler/frontend/src/org/jetbrains/kotlin/cfg/pseudocode/instructions/jumps/NondeterministicJumpInstruction.kt b/compiler/frontend/src/org/jetbrains/kotlin/cfg/pseudocode/instructions/jumps/NondeterministicJumpInstruction.kt index 4e9f0f345dc..b464761ba90 100644 --- a/compiler/frontend/src/org/jetbrains/kotlin/cfg/pseudocode/instructions/jumps/NondeterministicJumpInstruction.kt +++ b/compiler/frontend/src/org/jetbrains/kotlin/cfg/pseudocode/instructions/jumps/NondeterministicJumpInstruction.kt @@ -36,7 +36,7 @@ class NondeterministicJumpInstruction( private val _resolvedTargets: MutableMap = linkedMapOf() val targetLabels: List