Ensure deterministic insertion of checkExpressionValueIsNotNull.
Kotlinc source’s file DescriptorUtils.kt demonstarted non-deterministic insertion of checkExpressionValueIsNotNull for value returned by CallableDescriptor::getOriginal(). It was difficult to reproduce this behavior on ф smaller example, but I added a test which was failing once in 5-10 times while I was testing manually. I believe this bug is close to KT-23704. This PR addresses non-determinism to a degree when I can run 120 Compilations with './gradlew dist' and get same classes in all jars in 'dist'. NOTE that thew fact that insertion of checkExpressionValueIsNotNull may depend on order of the types seems suspicios. This CL only addresses non-determinism part, but I believe it’s worth looking into this more from semantics point of view.
This commit is contained in:
committed by
Alexander Udalov
parent
10da41b136
commit
c5373c9029
@@ -2344,6 +2344,12 @@ public class BytecodeTextTestGenerated extends AbstractBytecodeTextTest {
|
||||
runTest("compiler/testData/codegen/bytecodeText/nullCheckOptimization/alreadyCheckedForNull.kt");
|
||||
}
|
||||
|
||||
@TestMetadata("deterministicNotNullChecks.kt")
|
||||
public void testDeterministicNotNullChecks() throws Exception {
|
||||
String fileName = KotlinTestUtils.navigationMetadata("compiler/testData/codegen/bytecodeText/nullCheckOptimization/deterministicNotNullChecks.kt");
|
||||
doTest(fileName);
|
||||
}
|
||||
|
||||
@TestMetadata("expressionValueIsNotNull.kt")
|
||||
public void testExpressionValueIsNotNull() throws Exception {
|
||||
runTest("compiler/testData/codegen/bytecodeText/nullCheckOptimization/expressionValueIsNotNull.kt");
|
||||
|
||||
Reference in New Issue
Block a user