Gradually prohibit comparison of incompatible enums

#KT-22043 Fixed
2019-02-28 15:30:34 +03:00
parent 82c8289666
commit c4b69b65bc
14 changed files with 479 additions and 12 deletions
@@ -1,3 +1,5 @@
+// !LANGUAGE: -ProhibitComparisonOfIncompatibleEnums
+
 enum class E1 {
    A, B
 }
@@ -56,3 +58,88 @@ fun foo3(e1: Enum<E1>, e2: Enum<E2>, e: Enum<*>) {
        else -> {}
    }
 }
+
+interface MyInterface
+open class MyOpenClass
+
+fun foo4(e1: E1, i: MyInterface, c: MyOpenClass) {
+    <!INCOMPATIBLE_ENUM_COMPARISON!>e1 == i<!>
+    <!INCOMPATIBLE_ENUM_COMPARISON!>i == e1<!>
+
+    <!INCOMPATIBLE_ENUM_COMPARISON!>e1 == c<!>
+    <!INCOMPATIBLE_ENUM_COMPARISON!>c == e1<!>
+
+    when (e1) {
+        <!INCOMPATIBLE_ENUM_COMPARISON!>i<!> -> {}
+        <!INCOMPATIBLE_ENUM_COMPARISON!>c<!> -> {}
+        else -> {}
+    }
+}
+
+enum class E3 : MyInterface { X, Y }
+
+fun foo5(i: MyInterface, a: Any) {
+    E3.X == E3.Y
+    E3.X == i
+    E3.X == a
+}
+
+fun foo6(e1: E1?, e2: E2) {
+    <!SENSELESS_COMPARISON!>E1.A == null<!>
+    <!SENSELESS_COMPARISON!>null == E1.A<!>
+    e1 == null
+    null == e1
+
+    <!INCOMPATIBLE_ENUM_COMPARISON!>e1 == E2.A<!>
+    <!INCOMPATIBLE_ENUM_COMPARISON!>E2.A == e1<!>
+    <!INCOMPATIBLE_ENUM_COMPARISON!>e1 == e2<!>
+    <!INCOMPATIBLE_ENUM_COMPARISON!>e2 == e1<!>
+
+    <!SENSELESS_COMPARISON!>e2 == null<!>
+    <!SENSELESS_COMPARISON!>null == e2<!>
+    <!SENSELESS_COMPARISON!>E1.A == null<!>
+    <!SENSELESS_COMPARISON!>null == E1.A<!>
+}
+
+fun foo7(e1: E1?, e2: E2?) {
+    e1 == e2 // There should be an IDE-inspection for such cases
+}
+
+fun <T> foo8(e1: E1?, e2: E2, t: T) {
+    e1 == t
+    t == e1
+
+    e2 == t
+    t == e2
+
+    E1.A == t
+    t == E1.A
+}
+
+fun <T, K> foo9(e1: E1?, e2: E2, t: T, k: K) where T : MyInterface, T : MyOpenClass, K : MyInterface {
+    <!INCOMPATIBLE_ENUM_COMPARISON!>e1 == t<!>
+    <!INCOMPATIBLE_ENUM_COMPARISON!>t == e1<!>
+
+    <!INCOMPATIBLE_ENUM_COMPARISON!>e2 == t<!>
+    <!INCOMPATIBLE_ENUM_COMPARISON!>t == e2<!>
+
+    <!INCOMPATIBLE_ENUM_COMPARISON!>E1.A == t<!>
+    <!INCOMPATIBLE_ENUM_COMPARISON!>t == E1.A<!>
+
+    <!INCOMPATIBLE_ENUM_COMPARISON!>E3.X == t<!>
+
+    E3.X == k
+    k == E3.X
+}
+
+interface Inv<T>
+
+enum class E4 : Inv<Int> { A }
+
+fun foo10(e4: E4, invString: Inv<String>) {
+    e4 == invString
+    invString == e4
+
+    E4.A == invString
+    invString == E4.A
+}