From c49770d9a78879da31a5961aeb976d53f3cdde69 Mon Sep 17 00:00:00 2001
From: Toshiaki Kameyama <kmymtsak@gmail.com>
Date: Mon, 19 Nov 2018 16:39:39 +0900
Subject: [PATCH] Unused symbol: don't report for type parameter in open class
 #KT-23639 Fixed

---
 .../inspections/UnusedSymbolInspection.kt     | 11 ++++++
 .../typeParameter/inspectionData/expected.xml | 36 +++++++++++++++++++
 .../typeParameter/openClassTypeParameter.kt   | 33 +++++++++++++++++
 3 files changed, 80 insertions(+)
 create mode 100644 idea/testData/inspections/unusedSymbol/typeParameter/openClassTypeParameter.kt

diff --git a/idea/src/org/jetbrains/kotlin/idea/inspections/UnusedSymbolInspection.kt b/idea/src/org/jetbrains/kotlin/idea/inspections/UnusedSymbolInspection.kt
index 7d6221fe385..3104e068a3a 100644
--- a/idea/src/org/jetbrains/kotlin/idea/inspections/UnusedSymbolInspection.kt
+++ b/idea/src/org/jetbrains/kotlin/idea/inspections/UnusedSymbolInspection.kt
@@ -251,6 +251,17 @@ class UnusedSymbolInspection : AbstractKotlinInspection() {
             }
         } else useScope
 
+        if (declaration is KtTypeParameter) {
+            val containingClass = declaration.containingClass()
+            if (containingClass != null) {
+                val isOpenClass = containingClass.isInterface()
+                        || containingClass.hasModifier(KtTokens.ABSTRACT_KEYWORD)
+                        || containingClass.hasModifier(KtTokens.SEALED_KEYWORD)
+                        || containingClass.hasModifier(KtTokens.OPEN_KEYWORD)
+                if (isOpenClass && hasOverrides(containingClass, restrictedScope)) return true
+            }
+        }
+
         return (declaration is KtObjectDeclaration && declaration.isCompanion() &&
                 declaration.getBody()?.declarations?.isNotEmpty() == true) ||
                 hasReferences(declaration, descriptor, restrictedScope) ||
diff --git a/idea/testData/inspections/unusedSymbol/typeParameter/inspectionData/expected.xml b/idea/testData/inspections/unusedSymbol/typeParameter/inspectionData/expected.xml
index 42512da212b..85fc195c7b2 100644
--- a/idea/testData/inspections/unusedSymbol/typeParameter/inspectionData/expected.xml
+++ b/idea/testData/inspections/unusedSymbol/typeParameter/inspectionData/expected.xml
@@ -16,4 +16,40 @@
     <problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Unused Symbol</problem_class>
     <description>Type parameter 'T' is never used</description>
   </problem>
+
+  <problem>
+    <file>openClassTypeParameter.kt</file>
+    <line>1</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="temp:///src/openClassTypeParameter.kt" />
+    <problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Unused Symbol</problem_class>
+    <description>Type parameter 'T' is never used</description>
+  </problem>
+
+  <problem>
+    <file>openClassTypeParameter.kt</file>
+    <line>5</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="temp:///src/openClassTypeParameter.kt" />
+    <problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Unused Symbol</problem_class>
+    <description>Type parameter 'T' is never used</description>
+  </problem>
+
+  <problem>
+    <file>openClassTypeParameter.kt</file>
+    <line>9</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="temp:///src/openClassTypeParameter.kt" />
+    <problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Unused Symbol</problem_class>
+    <description>Type parameter 'T' is never used</description>
+  </problem>
+
+  <problem>
+    <file>openClassTypeParameter.kt</file>
+    <line>13</line>
+    <module>light_idea_test_case</module>
+    <entry_point TYPE="file" FQNAME="temp:///src/openClassTypeParameter.kt" />
+    <problem_class severity="WARNING" attribute_key="NOT_USED_ELEMENT_ATTRIBUTES">Unused Symbol</problem_class>
+    <description>Type parameter 'T' is never used</description>
+  </problem>
 </problems>
diff --git a/idea/testData/inspections/unusedSymbol/typeParameter/openClassTypeParameter.kt b/idea/testData/inspections/unusedSymbol/typeParameter/openClassTypeParameter.kt
new file mode 100644
index 00000000000..7edcff0fdb2
--- /dev/null
+++ b/idea/testData/inspections/unusedSymbol/typeParameter/openClassTypeParameter.kt
@@ -0,0 +1,33 @@
+interface Interface<T>
+interface Interface2<T>
+class A<T> : Interface2<T>
+
+abstract class Abstract<T>
+abstract class Abstract2<T>
+class B<T> : Abstract2<T>()
+
+sealed class Sealed<T>
+sealed class Sealed2<T>
+class C<T> : Sealed2<T>()
+
+open class Open<T>
+open class Open2<T>
+class D<T> : Open2<T>()
+
+fun main(args: Array<String>) {
+    Interface::class
+    Interface2::class
+    A::class
+
+    Abstract::class
+    Abstract2::class
+    B::class
+
+    Sealed::class
+    Sealed2::class
+    C::class
+
+    Open::class
+    Open2::class
+    D::class
+}
\ No newline at end of file