From c48c3fc8ed1a2913e37c304dc43f400d9b2bef4f Mon Sep 17 00:00:00 2001 From: Mikhail Glukhikh Date: Fri, 15 Jan 2016 16:45:27 +0300 Subject: [PATCH] Cleanup: DataFlowAnalyzer, ignore MethodMayBeStatic for SmartCastManager --- .../kotlin/resolve/calls/smartcasts/SmartCastManager.java | 2 ++ .../kotlin/types/expressions/DataFlowAnalyzer.java | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/smartcasts/SmartCastManager.java b/compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/smartcasts/SmartCastManager.java index 057f99b33f7..0d49a299991 100644 --- a/compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/smartcasts/SmartCastManager.java +++ b/compiler/frontend/src/org/jetbrains/kotlin/resolve/calls/smartcasts/SmartCastManager.java @@ -43,6 +43,8 @@ import static org.jetbrains.kotlin.diagnostics.Errors.SMARTCAST_IMPOSSIBLE; import static org.jetbrains.kotlin.resolve.BindingContext.IMPLICIT_RECEIVER_SMARTCAST; import static org.jetbrains.kotlin.resolve.BindingContext.SMARTCAST; +// We do not want to make methods static to keep SmartCastManager as a component +@SuppressWarnings("MethodMayBeStatic") public class SmartCastManager { @NotNull diff --git a/compiler/frontend/src/org/jetbrains/kotlin/types/expressions/DataFlowAnalyzer.java b/compiler/frontend/src/org/jetbrains/kotlin/types/expressions/DataFlowAnalyzer.java index 4a37a625873..5ebeb7c3ef8 100644 --- a/compiler/frontend/src/org/jetbrains/kotlin/types/expressions/DataFlowAnalyzer.java +++ b/compiler/frontend/src/org/jetbrains/kotlin/types/expressions/DataFlowAnalyzer.java @@ -245,7 +245,7 @@ public class DataFlowAnalyzer { } @Nullable - public SmartCastResult checkPossibleCast( + public static SmartCastResult checkPossibleCast( @NotNull KotlinType expressionType, @NotNull KtExpression expression, @NotNull ResolutionContext c @@ -272,7 +272,7 @@ public class DataFlowAnalyzer { } @NotNull - public KotlinTypeInfo illegalStatementType(@NotNull KtExpression expression, @NotNull ExpressionTypingContext context, @NotNull ExpressionTypingInternals facade) { + public static KotlinTypeInfo illegalStatementType(@NotNull KtExpression expression, @NotNull ExpressionTypingContext context, @NotNull ExpressionTypingInternals facade) { facade.checkStatementType( expression, context.replaceExpectedType(TypeUtils.NO_EXPECTED_TYPE).replaceContextDependency(INDEPENDENT)); context.trace.report(EXPRESSION_EXPECTED.on(expression, expression)); @@ -280,7 +280,7 @@ public class DataFlowAnalyzer { } @NotNull - public Collection getAllPossibleTypes( + public static Collection getAllPossibleTypes( @NotNull KtExpression expression, @NotNull DataFlowInfo dataFlowInfo, @NotNull KotlinType type,