IDE: Don't add this!! in AddExclExclCallFix for nullable member

access in extension function.

^KTIJ-10052 Fixed

idea/src/org/jetbrains/kotlin/idea/quickfix/AddExclExclCallFix.kt

@@ -174,6 +174,6 @@ object MissingIteratorExclExclFixFactory : KotlinSingleIntentionActionFactory()
             else -> return null
         }
 
-        return AddExclExclCallFix(element)
+        return AddExclExclCallFix(element, checkImplicitReceivers = false)
     }
 }

idea/src/org/jetbrains/kotlin/idea/quickfix/QuickFixFactoryForTypeMismatchError.kt

@@ -166,7 +166,7 @@ class QuickFixFactoryForTypeMismatchError : KotlinIntentionActionsFactory() {
             val nullableExpected = expectedType.makeNullable()
             if (expressionType.isSubtypeOf(nullableExpected)) {
                 val targetExpression = diagnosticElement.getTopMostQualifiedForSelectorIfAny()
-                actions.add(AddExclExclCallFix(targetExpression))
+                actions.add(AddExclExclCallFix(targetExpression, checkImplicitReceivers = false))
                 if (expectedType.isBoolean()) {
                     actions.add(AddEqEqTrueFix(targetExpression))
                 }

idea/testData/quickfix/addExclExclCall/iterable.kt

@@ -0,0 +1,6 @@
+// "Add non-null asserted (!!) call" "true"
+// WITH_RUNTIME
+
+fun foo(a: List<String>?) {
+    for (s in <caret>a) {}
+}

idea/testData/quickfix/addExclExclCall/iterable.kt.after

@@ -0,0 +1,6 @@
+// "Add non-null asserted (!!) call" "true"
+// WITH_RUNTIME
+
+fun foo(a: List<String>?) {
+    for (s in a!!) {}
+}

idea/testData/quickfix/addExclExclCall/iterableInExtension.kt

@@ -0,0 +1,11 @@
+// "Add non-null asserted (!!) call" "true"
+// WITH_RUNTIME
+
+class C {
+    val list: List<String>? = null
+}
+
+// Test for KTIJ-10052
+fun C.test() {
+    for (s in <caret>list) {}
+}

idea/testData/quickfix/addExclExclCall/iterableInExtension.kt.after

@@ -0,0 +1,11 @@
+// "Add non-null asserted (!!) call" "true"
+// WITH_RUNTIME
+
+class C {
+    val list: List<String>? = null
+}
+
+// Test for KTIJ-10052
+fun C.test() {
+    for (s in list!!) {}
+}

idea/testData/quickfix/typeMismatch/addExclExclToAssignmentRValue.kt

@@ -0,0 +1,5 @@
+// "Add non-null asserted (!!) call" "true"
+fun test() {
+    val s: String? = null
+    val z: String = <caret>s
+}

idea/testData/quickfix/typeMismatch/addExclExclToAssignmentRValue.kt.after

@@ -0,0 +1,5 @@
+// "Add non-null asserted (!!) call" "true"
+fun test() {
+    val s: String? = null
+    val z: String = s!!
+}

idea/testData/quickfix/typeMismatch/addExclExclToMemberAccessInExtension.kt

@@ -0,0 +1,12 @@
+// "Add non-null asserted (!!) call" "true"
+
+class C {
+    val s: String? = null
+}
+
+// Test for KTIJ-10052
+fun C.test() {
+    other(<caret>s)
+}
+
+fun other(s: String) {}

idea/testData/quickfix/typeMismatch/addExclExclToMemberAccessInExtension.kt.after

@@ -0,0 +1,12 @@
+// "Add non-null asserted (!!) call" "true"
+
+class C {
+    val s: String? = null
+}
+
+// Test for KTIJ-10052
+fun C.test() {
+    other(s!!)
+}
+
+fun other(s: String) {}

idea/testData/quickfix/typeMismatch/addExclExclToMemberAccessInExtensionAsAssignmentRValue.kt

@@ -0,0 +1,9 @@
+// "Add non-null asserted (!!) call" "true"
+class C {
+    val s: String? = null
+}
+
+// Test for KTIJ-10052
+fun C.test() {
+    val z: String = <caret>s
+}

idea/testData/quickfix/typeMismatch/addExclExclToMemberAccessInExtensionAsAssignmentRValue.kt.after

@@ -0,0 +1,9 @@
+// "Add non-null asserted (!!) call" "true"
+class C {
+    val s: String? = null
+}
+
+// Test for KTIJ-10052
+fun C.test() {
+    val z: String = s!!
+}

idea/tests/org/jetbrains/kotlin/idea/quickfix/QuickFixTestGenerated.java

@@ -677,6 +677,16 @@ public class QuickFixTestGenerated extends AbstractQuickFixTest {
             runTest("idea/testData/quickfix/addExclExclCall/implicitFunctionCall.kt");
         }
 
+        @TestMetadata("iterable.kt")
+        public void testIterable() throws Exception {
+            runTest("idea/testData/quickfix/addExclExclCall/iterable.kt");
+        }
+
+        @TestMetadata("iterableInExtension.kt")
+        public void testIterableInExtension() throws Exception {
+            runTest("idea/testData/quickfix/addExclExclCall/iterableInExtension.kt");
+        }
+
         @TestMetadata("normal.kt")
         public void testNormal() throws Exception {
             runTest("idea/testData/quickfix/addExclExclCall/normal.kt");
@@ -13776,6 +13786,21 @@ public class QuickFixTestGenerated extends AbstractQuickFixTest {
             runTest("idea/testData/quickfix/typeMismatch/addArrayOfTypeForNamedParameter.kt");
         }
 
+        @TestMetadata("addExclExclToAssignmentRValue.kt")
+        public void testAddExclExclToAssignmentRValue() throws Exception {
+            runTest("idea/testData/quickfix/typeMismatch/addExclExclToAssignmentRValue.kt");
+        }
+
+        @TestMetadata("addExclExclToMemberAccessInExtension.kt")
+        public void testAddExclExclToMemberAccessInExtension() throws Exception {
+            runTest("idea/testData/quickfix/typeMismatch/addExclExclToMemberAccessInExtension.kt");
+        }
+
+        @TestMetadata("addExclExclToMemberAccessInExtensionAsAssignmentRValue.kt")
+        public void testAddExclExclToMemberAccessInExtensionAsAssignmentRValue() throws Exception {
+            runTest("idea/testData/quickfix/typeMismatch/addExclExclToMemberAccessInExtensionAsAssignmentRValue.kt");
+        }
+
         @TestMetadata("addExclExclToQualifiedArgument.kt")
         public void testAddExclExclToQualifiedArgument() throws Exception {
             runTest("idea/testData/quickfix/typeMismatch/addExclExclToQualifiedArgument.kt");