Rename ClassResolver -> DescriptorFinder
Avoid clash with JavaDescriptorResolver naming conventions
This commit is contained in:
committed by
Alexander Udalov
parent
c3a44e37ba
commit
c3b1716e29
+3
-3
@@ -29,12 +29,12 @@ import org.jetbrains.jet.lang.resolve.name.FqName;
|
||||
|
||||
import static org.jetbrains.jet.lang.resolve.lazy.storage.StorageManager.ReferenceKind.STRONG;
|
||||
|
||||
public abstract class AbstractClassResolver implements ClassResolver {
|
||||
public abstract class AbstractDescriptorFinder implements DescriptorFinder {
|
||||
|
||||
private final MemoizedFunctionToNullable<ClassId, ClassDescriptor> findClass;
|
||||
private final AnnotationDeserializer annotationDeserializer;
|
||||
|
||||
public AbstractClassResolver(@NotNull final StorageManager storageManager, @NotNull AnnotationDeserializer annotationDeserializer) {
|
||||
public AbstractDescriptorFinder(@NotNull final StorageManager storageManager, @NotNull AnnotationDeserializer annotationDeserializer) {
|
||||
this.annotationDeserializer = annotationDeserializer;
|
||||
|
||||
this.findClass = storageManager.createMemoizedFunctionWithNullableValues(new Function<ClassId, ClassDescriptor>() {
|
||||
@@ -51,7 +51,7 @@ public abstract class AbstractClassResolver implements ClassResolver {
|
||||
classId.isTopLevelClass() ? getPackage(classId.getPackageFqName()) : findClass(classId.getOuterClassId());
|
||||
assert owner != null : "No owner found for " + classId;
|
||||
|
||||
AbstractClassResolver _this = AbstractClassResolver.this;
|
||||
AbstractDescriptorFinder _this = AbstractDescriptorFinder.this;
|
||||
ClassDescriptor classDescriptor = new DeserializedClassDescriptor(
|
||||
classId, storageManager, owner, classData.getNameResolver(),
|
||||
_this.annotationDeserializer, _this, classProto, null);
|
||||
+2
-2
@@ -42,11 +42,11 @@ public class DescriptorDeserializer {
|
||||
@NotNull StorageManager storageManager,
|
||||
@NotNull DeclarationDescriptor containingDeclaration,
|
||||
@NotNull NameResolver nameResolver,
|
||||
@NotNull ClassResolver classResolver,
|
||||
@NotNull DescriptorFinder descriptorFinder,
|
||||
@NotNull AnnotationDeserializer annotationDeserializer
|
||||
) {
|
||||
return new DescriptorDeserializer(storageManager,
|
||||
new TypeDeserializer(storageManager, null, nameResolver, classResolver, "Deserializer for " + containingDeclaration, NONE),
|
||||
new TypeDeserializer(storageManager, null, nameResolver, descriptorFinder, "Deserializer for " + containingDeclaration, NONE),
|
||||
containingDeclaration, nameResolver, annotationDeserializer);
|
||||
}
|
||||
|
||||
|
||||
+2
-2
@@ -20,9 +20,9 @@ import org.jetbrains.annotations.NotNull;
|
||||
import org.jetbrains.annotations.Nullable;
|
||||
import org.jetbrains.jet.lang.descriptors.ClassDescriptor;
|
||||
|
||||
public interface ClassResolver {
|
||||
public interface DescriptorFinder {
|
||||
|
||||
ClassResolver EMPTY = new ClassResolver() {
|
||||
DescriptorFinder EMPTY = new DescriptorFinder() {
|
||||
@Nullable
|
||||
@Override
|
||||
public ClassDescriptor findClass(@NotNull ClassId classId) {
|
||||
+7
-7
@@ -53,7 +53,7 @@ public class TypeDeserializer {
|
||||
}
|
||||
|
||||
private final NameResolver nameResolver;
|
||||
private final ClassResolver classResolver;
|
||||
private final DescriptorFinder descriptorFinder;
|
||||
private final TypeDeserializer parent;
|
||||
|
||||
// never written to after constructor returns
|
||||
@@ -71,21 +71,21 @@ public class TypeDeserializer {
|
||||
@NotNull String debugName,
|
||||
@NotNull TypeParameterResolver typeParameterResolver
|
||||
) {
|
||||
this(storageManager, parent, parent.nameResolver, parent.classResolver, debugName, typeParameterResolver);
|
||||
this(storageManager, parent, parent.nameResolver, parent.descriptorFinder, debugName, typeParameterResolver);
|
||||
}
|
||||
|
||||
public TypeDeserializer(
|
||||
@NotNull StorageManager storageManager,
|
||||
@Nullable TypeDeserializer parent,
|
||||
@NotNull NameResolver nameResolver,
|
||||
@NotNull ClassResolver classResolver,
|
||||
@NotNull DescriptorFinder descriptorFinder,
|
||||
@NotNull String debugName,
|
||||
@NotNull TypeParameterResolver typeParameterResolver
|
||||
) {
|
||||
this.storageManager = storageManager;
|
||||
this.parent = parent;
|
||||
this.nameResolver = nameResolver;
|
||||
this.classResolver = classResolver;
|
||||
this.descriptorFinder = descriptorFinder;
|
||||
this.debugName = debugName + (parent == null ? "" : ". Child of " + parent.debugName);
|
||||
|
||||
for (DeserializedTypeParameterDescriptor typeParameterDescriptor : typeParameterResolver.getTypeParameters(this)) {
|
||||
@@ -101,8 +101,8 @@ public class TypeDeserializer {
|
||||
}
|
||||
|
||||
@NotNull
|
||||
public ClassResolver getClassResolver() {
|
||||
return classResolver;
|
||||
public DescriptorFinder getDescriptorFinder() {
|
||||
return descriptorFinder;
|
||||
}
|
||||
|
||||
@Nullable
|
||||
@@ -154,7 +154,7 @@ public class TypeDeserializer {
|
||||
@Nullable
|
||||
private ClassDescriptor computeClassDescriptor(int fqNameIndex) {
|
||||
ClassId classId = nameResolver.getClassId(fqNameIndex);
|
||||
return classResolver.findClass(classId);
|
||||
return descriptorFinder.findClass(classId);
|
||||
}
|
||||
|
||||
private List<TypeProjection> typeArguments(List<ProtoBuf.Type.Argument> protos) {
|
||||
|
||||
+8
-8
@@ -70,7 +70,7 @@ public class DeserializedClassDescriptor extends ClassDescriptorBase implements
|
||||
private final ClassKind kind;
|
||||
private final boolean isInner;
|
||||
private final InnerClassesScopeWrapper innerClassesScope;
|
||||
private final ClassResolver classResolver;
|
||||
private final DescriptorFinder descriptorFinder;
|
||||
|
||||
public DeserializedClassDescriptor(
|
||||
@NotNull ClassId classId,
|
||||
@@ -78,17 +78,17 @@ public class DeserializedClassDescriptor extends ClassDescriptorBase implements
|
||||
@NotNull DeclarationDescriptor containingDeclaration,
|
||||
@NotNull NameResolver nameResolver,
|
||||
@NotNull AnnotationDeserializer annotationResolver,
|
||||
@NotNull final ClassResolver classResolver,
|
||||
@NotNull final DescriptorFinder descriptorFinder,
|
||||
@NotNull ProtoBuf.Class classProto,
|
||||
@Nullable TypeDeserializer outerTypeDeserializer
|
||||
) {
|
||||
this.classId = classId;
|
||||
this.classProto = classProto;
|
||||
this.classResolver = classResolver;
|
||||
this.descriptorFinder = descriptorFinder;
|
||||
this.name = nameResolver.getName(classProto.getName());
|
||||
|
||||
TypeDeserializer notNullTypeDeserializer = new TypeDeserializer(storageManager, outerTypeDeserializer, nameResolver, classResolver,
|
||||
"Deserializer for class " + name, NONE);
|
||||
TypeDeserializer notNullTypeDeserializer = new TypeDeserializer(storageManager, outerTypeDeserializer, nameResolver,
|
||||
descriptorFinder, "Deserializer for class " + name, NONE);
|
||||
DescriptorDeserializer outerDeserializer = DescriptorDeserializer.create(storageManager, notNullTypeDeserializer,
|
||||
this, nameResolver, annotationResolver);
|
||||
List<TypeParameterDescriptor> typeParameters = new ArrayList<TypeParameterDescriptor>(classProto.getTypeParameterCount());
|
||||
@@ -131,13 +131,13 @@ public class DeserializedClassDescriptor extends ClassDescriptorBase implements
|
||||
this.nestedClasses = new NestedClassDescriptors(storageManager, stringSet(classProto.getNestedClassNameList(), nameResolver)) {
|
||||
@Override
|
||||
protected ClassDescriptor resolveNestedClass(@NotNull Name name) {
|
||||
return classResolver.findClass(DeserializedClassDescriptor.this.classId.createNestedClassId(name));
|
||||
return descriptorFinder.findClass(DeserializedClassDescriptor.this.classId.createNestedClassId(name));
|
||||
}
|
||||
};
|
||||
this.nestedObjects = new NestedClassDescriptors(storageManager, stringSet(classProto.getNestedObjectNameList(), nameResolver)) {
|
||||
@Override
|
||||
protected ClassDescriptor resolveNestedClass(@NotNull Name name) {
|
||||
return classResolver.findClass(DeserializedClassDescriptor.this.classId.createNestedClassId(name));
|
||||
return descriptorFinder.findClass(DeserializedClassDescriptor.this.classId.createNestedClassId(name));
|
||||
}
|
||||
};
|
||||
}
|
||||
@@ -270,7 +270,7 @@ public class DeserializedClassDescriptor extends ClassDescriptorBase implements
|
||||
return classObject;
|
||||
}
|
||||
|
||||
return classResolver.findClass(classId.createNestedClassId(getClassObjectName(getName())));
|
||||
return descriptorFinder.findClass(classId.createNestedClassId(getClassObjectName(getName())));
|
||||
}
|
||||
|
||||
@NotNull
|
||||
|
||||
+5
-5
@@ -3,7 +3,7 @@ package org.jetbrains.jet.descriptors.serialization.descriptors;
|
||||
import org.jetbrains.annotations.NotNull;
|
||||
import org.jetbrains.annotations.Nullable;
|
||||
import org.jetbrains.jet.descriptors.serialization.ClassId;
|
||||
import org.jetbrains.jet.descriptors.serialization.ClassResolver;
|
||||
import org.jetbrains.jet.descriptors.serialization.DescriptorFinder;
|
||||
import org.jetbrains.jet.descriptors.serialization.DescriptorDeserializer;
|
||||
import org.jetbrains.jet.descriptors.serialization.ProtoBuf;
|
||||
import org.jetbrains.jet.lang.descriptors.ClassDescriptor;
|
||||
@@ -22,7 +22,7 @@ import java.util.List;
|
||||
|
||||
public abstract class DeserializedPackageMemberScope extends DeserializedMemberScope {
|
||||
|
||||
private final ClassResolver classResolver;
|
||||
private final DescriptorFinder descriptorFinder;
|
||||
private final FqName packageFqName;
|
||||
|
||||
public DeserializedPackageMemberScope(
|
||||
@@ -30,10 +30,10 @@ public abstract class DeserializedPackageMemberScope extends DeserializedMemberS
|
||||
@NotNull NamespaceDescriptor packageDescriptor,
|
||||
@NotNull DescriptorDeserializer deserializer,
|
||||
@NotNull List<ProtoBuf.Callable> membersList,
|
||||
ClassResolver classResolver
|
||||
@NotNull DescriptorFinder descriptorFinder
|
||||
) {
|
||||
super(storageManager, packageDescriptor, deserializer, membersList);
|
||||
this.classResolver = classResolver;
|
||||
this.descriptorFinder = descriptorFinder;
|
||||
this.packageFqName = DescriptorUtils.getFQName(packageDescriptor).toSafe();
|
||||
}
|
||||
|
||||
@@ -51,7 +51,7 @@ public abstract class DeserializedPackageMemberScope extends DeserializedMemberS
|
||||
|
||||
@Nullable
|
||||
private ClassDescriptor findClassDescriptor(Name name, boolean object) {
|
||||
ClassDescriptor classDescriptor = classResolver.findClass(new ClassId(packageFqName, FqNameUnsafe.topLevel(name)));
|
||||
ClassDescriptor classDescriptor = descriptorFinder.findClass(new ClassId(packageFqName, FqNameUnsafe.topLevel(name)));
|
||||
if (classDescriptor == null) {
|
||||
return null;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user