Inspection: Simplify Nested forEach/onEach in also/apply to onEach

^KT-40283 Fixed

idea/testData/inspectionsLocal/simplifyNestedEachInScope/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.SimplifyNestedEachInScopeFunctionInspection

idea/testData/inspectionsLocal/simplifyNestedEachInScope/also.kt

@@ -0,0 +1,4 @@
+// WITH_RUNTIME
+fun test(){
+    listOf(1,2,3).also<caret> { it.forEach{ it + 4 } }.forEach{ it + 5 }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/also.kt.after

@@ -0,0 +1,4 @@
+// WITH_RUNTIME
+fun test(){
+    listOf(1,2,3).onEach { it + 4 }.forEach{ it + 5 }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/also2.kt

@@ -0,0 +1,6 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test(){
+    val a = listOf(1,2,3)
+    "".also<caret> { a.forEach { it + 2 } }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/also3.kt

@@ -0,0 +1,4 @@
+// WITH_RUNTIME
+fun test(){
+    listOf(1,2,3).also<caret> { s -> s.forEach{ it + 4 } }.forEach{ it + 5 }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/also3.kt.after

@@ -0,0 +1,4 @@
+// WITH_RUNTIME
+fun test(){
+    listOf(1,2,3).onEach { it + 4 }.forEach{ it + 5 }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/also4.kt

@@ -0,0 +1,5 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test(){
+    listOf(1,2,3).also<caret> { listOf(1,2,3).forEach { } }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/also5.kt

@@ -0,0 +1,5 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test(){
+    mutableListOf(1,2,3).also<caret> { list -> list.forEach { list.add(it) } }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/alsoLabel.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test(){
+    listOf(1, 2, 3).also<caret> a@ { it.forEach { i ->
+        if (i % 2 == 0) return@a
+    }}
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/alsoLabel2.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test(){
+    listOf(1, 2, 3).also<caret> { it.forEach { i ->
+        if (i % 2 == 0) return@also
+    }}
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/alsoLabel3.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+fun test(){
+    listOf(1, 2, 3).also<caret> { it.forEach { i ->
+        if (i % 2 == 0) return@forEach
+    }}
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/alsoLabel3.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+fun test(){
+    listOf(1, 2, 3).onEach { i ->
+        if (i % 2 == 0) return@onEach
+    }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/apply.kt

@@ -0,0 +1,4 @@
+// WITH_RUNTIME
+fun test(){
+    listOf(1,2,3).apply<caret> { forEach{ it + 4 } }.forEach{ it + 5 }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/apply.kt.after

@@ -0,0 +1,4 @@
+// WITH_RUNTIME
+fun test(){
+    listOf(1,2,3).onEach { it + 4 }.forEach{ it + 5 }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/apply2.kt

@@ -0,0 +1,5 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test(){
+    listOf(1,2,3).apply<caret> { 1.apply<caret> { forEach{ it + 1 } } }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/apply3.kt

@@ -0,0 +1,4 @@
+// WITH_RUNTIME
+fun test(){
+    listOf(1,2,3).apply<caret> { this@apply.forEach { it + 5 } }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/apply3.kt.after

@@ -0,0 +1,4 @@
+// WITH_RUNTIME
+fun test(){
+    listOf(1,2,3).onEach { it + 5 }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/applyLabel.kt

@@ -0,0 +1,5 @@
+// PROBLEM: none
+// WITH_RUNTIME
+fun test(){
+    listOf(1,2,3).apply<caret> { forEach { this@apply.contains(it) } }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/applyLabel2.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+fun test(){
+    1.apply {
+        listOf(1, 2, 3).apply<caret> { forEach { this.plus(it) } }
+    }
+}

idea/testData/inspectionsLocal/simplifyNestedEachInScope/applyLabel2.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+fun test(){
+    1.apply {
+        listOf(1, 2, 3).onEach { this.plus(it) }
+    }
+}