JVM_IR: fix primitive comparison optimizations

1. the `primitive == object?.something` fusion should not apply to
    `primitive.equals(object?.something)` because it can't;

 2. coercions to Int are there for a reason - don't remove them;

 3. better optimize `primitive == object?.something` -- the result
    should be subject to if-null fusion, so it needs to have a specific
    pattern that resembles safe calls.

 #KT-47597 Fixed
This commit is contained in:
pyos
2021-07-05 12:38:34 +02:00
committed by TeamCityServer
parent 7e70c93cbf
commit c3a91efea3
15 changed files with 229 additions and 115 deletions
@@ -1306,6 +1306,16 @@ public class LightAnalysisModeTestGenerated extends AbstractLightAnalysisModeTes
runTest("compiler/testData/codegen/box/binaryOp/eqNullableDoublesWithTP.kt");
}
@TestMetadata("eqNullableShortToShort.kt")
public void testEqNullableShortToShort() throws Exception {
runTest("compiler/testData/codegen/box/binaryOp/eqNullableShortToShort.kt");
}
@TestMetadata("eqNullableToPrimitiveWithSideEffects.kt")
public void testEqNullableToPrimitiveWithSideEffects() throws Exception {
runTest("compiler/testData/codegen/box/binaryOp/eqNullableToPrimitiveWithSideEffects.kt");
}
@TestMetadata("intrinsic.kt")
public void testIntrinsic() throws Exception {
runTest("compiler/testData/codegen/box/binaryOp/intrinsic.kt");
@@ -1360,6 +1370,11 @@ public class LightAnalysisModeTestGenerated extends AbstractLightAnalysisModeTes
public void testOverflowLong() throws Exception {
runTest("compiler/testData/codegen/box/binaryOp/overflowLong.kt");
}
@TestMetadata("primitiveEqualsSafeCall.kt")
public void testPrimitiveEqualsSafeCall() throws Exception {
runTest("compiler/testData/codegen/box/binaryOp/primitiveEqualsSafeCall.kt");
}
}
@TestMetadata("compiler/testData/codegen/box/boxingOptimization")