KT-59293 [SLC] Fix generation of DefaultImpls classes

This commit is contained in:
Pavel Mikhailovskii
2023-06-23 08:01:52 +00:00
committed by Space Team
parent 896f8853ae
commit c3746652a4
9 changed files with 179 additions and 20 deletions
@@ -26,9 +26,11 @@ import org.jetbrains.kotlin.descriptors.annotations.AnnotationUseSiteTarget
import org.jetbrains.kotlin.light.classes.symbol.*
import org.jetbrains.kotlin.light.classes.symbol.annotations.*
import org.jetbrains.kotlin.light.classes.symbol.classes.SymbolLightClassBase
import org.jetbrains.kotlin.light.classes.symbol.classes.SymbolLightClassForInterfaceDefaultImpls
import org.jetbrains.kotlin.light.classes.symbol.modifierLists.GranularModifiersBox
import org.jetbrains.kotlin.light.classes.symbol.modifierLists.SymbolLightMemberModifierList
import org.jetbrains.kotlin.light.classes.symbol.modifierLists.with
import org.jetbrains.kotlin.light.classes.symbol.parameters.SymbolLightParameterForDefaultImplsReceiver
import org.jetbrains.kotlin.light.classes.symbol.parameters.SymbolLightParameterList
import org.jetbrains.kotlin.light.classes.symbol.parameters.SymbolLightSetterParameter
import org.jetbrains.kotlin.light.classes.symbol.parameters.SymbolLightTypeParameterList
@@ -168,7 +170,7 @@ internal class SymbolLightAccessorMethod private constructor(
val isStatic = if (suppressStatic) {
false
} else {
isTopLevel || isStatic()
isTopLevel || containingClass is SymbolLightClassForInterfaceDefaultImpls || isStatic()
}
mapOf(modifier to isStatic)
@@ -299,7 +301,7 @@ internal class SymbolLightAccessorMethod private constructor(
override fun hashCode(): Int = propertyAccessorDeclaration?.hashCode() ?: containingPropertyDeclaration.hashCode()
private val _parametersList by lazyPub {
val parameterPopulator: (LightParameterListBuilder) -> Unit = if (!isGetter) {
val baseParameterPopulator: (LightParameterListBuilder) -> Unit = if (!isGetter) {
{ builder ->
withAccessorSymbol { accessorSymbol ->
val setterParameter = (accessorSymbol as? KtPropertySetterSymbol)?.parameter ?: return@withAccessorSymbol
@@ -317,6 +319,13 @@ internal class SymbolLightAccessorMethod private constructor(
{ }
}
val parameterPopulator: (LightParameterListBuilder) -> Unit = { builder ->
if (containingClass is SymbolLightClassForInterfaceDefaultImpls) {
builder.addParameter(SymbolLightParameterForDefaultImplsReceiver(this@SymbolLightAccessorMethod))
}
baseParameterPopulator(builder)
}
SymbolLightParameterList(
parent = this@SymbolLightAccessorMethod,
callableWithReceiverSymbolPointer = containingPropertySymbolPointer,
@@ -5,9 +5,7 @@
package org.jetbrains.kotlin.light.classes.symbol.methods
import com.intellij.psi.PsiElement
import com.intellij.psi.PsiIdentifier
import com.intellij.psi.PsiParameterList
import com.intellij.psi.*
import com.intellij.psi.impl.light.LightReferenceListBuilder
import org.jetbrains.kotlin.analysis.api.KtAnalysisSession
import org.jetbrains.kotlin.analysis.api.symbols.KtFunctionLikeSymbol
@@ -21,10 +19,12 @@ import org.jetbrains.kotlin.asJava.elements.KtLightIdentifier
import org.jetbrains.kotlin.light.classes.symbol.annotations.computeThrowsList
import org.jetbrains.kotlin.light.classes.symbol.annotations.hasDeprecatedAnnotation
import org.jetbrains.kotlin.light.classes.symbol.classes.SymbolLightClassBase
import org.jetbrains.kotlin.light.classes.symbol.classes.SymbolLightClassForInterfaceDefaultImpls
import org.jetbrains.kotlin.light.classes.symbol.compareSymbolPointers
import org.jetbrains.kotlin.light.classes.symbol.isOriginEquivalentTo
import org.jetbrains.kotlin.light.classes.symbol.isValid
import org.jetbrains.kotlin.light.classes.symbol.parameters.SymbolLightParameter
import org.jetbrains.kotlin.light.classes.symbol.parameters.SymbolLightParameterForDefaultImplsReceiver
import org.jetbrains.kotlin.light.classes.symbol.parameters.SymbolLightParameterList
import org.jetbrains.kotlin.light.classes.symbol.parameters.SymbolLightSuspendContinuationParameter
import org.jetbrains.kotlin.light.classes.symbol.withSymbol
@@ -81,6 +81,10 @@ internal abstract class SymbolLightMethod<FType : KtFunctionLikeSymbol> private
parent = this@SymbolLightMethod,
callableWithReceiverSymbolPointer = functionSymbolPointer,
) { builder ->
if (this@SymbolLightMethod.containingClass is SymbolLightClassForInterfaceDefaultImpls) {
builder.addParameter(SymbolLightParameterForDefaultImplsReceiver(this@SymbolLightMethod))
}
withFunctionSymbol { functionSymbol ->
functionSymbol.valueParameters.mapIndexed { index, parameter ->
val needToSkip = argumentsSkipMask?.get(index) == true
@@ -21,6 +21,7 @@ import org.jetbrains.kotlin.lexer.KtTokens
import org.jetbrains.kotlin.light.classes.symbol.*
import org.jetbrains.kotlin.light.classes.symbol.annotations.*
import org.jetbrains.kotlin.light.classes.symbol.classes.SymbolLightClassBase
import org.jetbrains.kotlin.light.classes.symbol.classes.SymbolLightClassForInterfaceDefaultImpls
import org.jetbrains.kotlin.light.classes.symbol.modifierLists.GranularModifiersBox
import org.jetbrains.kotlin.light.classes.symbol.modifierLists.SymbolLightMemberModifierList
import org.jetbrains.kotlin.light.classes.symbol.modifierLists.with
@@ -77,10 +78,10 @@ internal class SymbolLightSimpleMethod(
private fun computeModifiers(modifier: String): Map<String, Boolean>? = when (modifier) {
in GranularModifiersBox.MODALITY_MODIFIERS -> {
ifInlineOnly { return modifiersForInlineOnlyCase() }
val modality = if (isTopLevel) {
PsiModifier.FINAL
} else {
withFunctionSymbol { functionSymbol ->
val modality = when {
isTopLevel -> PsiModifier.FINAL
containingClass is SymbolLightClassForInterfaceDefaultImpls -> null
else -> withFunctionSymbol { functionSymbol ->
functionSymbol.computeSimpleModality()?.takeUnless { it.isSuppressedFinalModifier(containingClass, functionSymbol) }
}
}
@@ -98,7 +99,9 @@ internal class SymbolLightSimpleMethod(
val isStatic = if (suppressStatic) {
false
} else {
isTopLevel || withFunctionSymbol { it.isStatic || it.hasJvmStaticAnnotation() }
isTopLevel
|| containingClass is SymbolLightClassForInterfaceDefaultImpls
|| withFunctionSymbol { it.isStatic || it.hasJvmStaticAnnotation() }
}
mapOf(modifier to isStatic)
@@ -0,0 +1,56 @@
/*
* Copyright 2010-2023 JetBrains s.r.o. and Kotlin Programming Language contributors.
* Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
*/
package org.jetbrains.kotlin.light.classes.symbol.parameters
import com.intellij.psi.PsiIdentifier
import com.intellij.psi.PsiModifierList
import com.intellij.psi.PsiType
import org.jetbrains.annotations.NotNull
import org.jetbrains.kotlin.asJava.classes.lazyPub
import org.jetbrains.kotlin.light.classes.symbol.annotations.ComputeAllAtOnceAnnotationsBox
import org.jetbrains.kotlin.light.classes.symbol.annotations.SymbolLightSimpleAnnotation
import org.jetbrains.kotlin.light.classes.symbol.classes.SymbolLightClassForInterface
import org.jetbrains.kotlin.light.classes.symbol.methods.SymbolLightMethodBase
import org.jetbrains.kotlin.light.classes.symbol.modifierLists.SymbolLightClassModifierList
import org.jetbrains.kotlin.light.classes.symbol.nonExistentType
import org.jetbrains.kotlin.psi.KtParameter
internal class SymbolLightParameterForDefaultImplsReceiver(containingDeclaration: SymbolLightMethodBase) :
SymbolLightParameterBase(containingDeclaration) {
private val _type by lazyPub {
(method.containingClass.containingClass as SymbolLightClassForInterface).withClassOrObjectSymbol {
it.buildSelfClassType().asPsiType(containingDeclaration, allowErrorTypes = true) ?: nonExistentType()
}
}
override fun getNameIdentifier(): PsiIdentifier? = null
override fun getName(): String = "\$this"
override fun getType(): PsiType = _type
override fun equals(other: Any?): Boolean =
other === this || other is SymbolLightParameterForDefaultImplsReceiver && other.parent == parent
override fun hashCode(): Int = parent.hashCode()
override fun isVarArgs(): Boolean = false
private val _modifierList: PsiModifierList by lazyPub {
SymbolLightClassModifierList(
this,
annotationsBox = ComputeAllAtOnceAnnotationsBox { modifierList ->
listOf(SymbolLightSimpleAnnotation(NotNull::class.java.name, modifierList))
})
}
override fun getModifierList(): PsiModifierList = _modifierList
override fun hasModifierProperty(name: String): Boolean = false
override val kotlinOrigin: KtParameter?
get() = null
}