From c3274b61eee6e29be4aa41bacd38ab1e348377ef Mon Sep 17 00:00:00 2001 From: Anton Lakotka Date: Tue, 10 Jan 2023 15:12:07 +0100 Subject: [PATCH] [Gradle] rename projectIdOrNull to currentBuildProjectIdOrNull for clarity --- .../gradle/plugin/mpp/GranularMetadataTransformation.kt | 5 ++--- .../kotlin/gradle/plugin/sources/DefaultKotlinSourceSet.kt | 2 +- .../targets/metadata/KotlinMetadataTargetConfigurator.kt | 3 +-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/mpp/GranularMetadataTransformation.kt b/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/mpp/GranularMetadataTransformation.kt index e3eaadef9f6..f6a56e7a377 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/mpp/GranularMetadataTransformation.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/mpp/GranularMetadataTransformation.kt @@ -16,7 +16,6 @@ import org.jetbrains.kotlin.gradle.dsl.KotlinMultiplatformExtension import org.jetbrains.kotlin.gradle.dsl.multiplatformExtension import org.jetbrains.kotlin.gradle.plugin.KotlinSourceSet import org.jetbrains.kotlin.gradle.plugin.mpp.MetadataDependencyResolution.ChooseVisibleSourceSets.MetadataProvider.ArtifactMetadataProvider -import org.jetbrains.kotlin.gradle.plugin.sources.KotlinDependencyScope import org.jetbrains.kotlin.gradle.plugin.sources.internal import java.util.* @@ -269,7 +268,7 @@ internal class GranularMetadataTransformation( } } -internal val ResolvedComponentResult.projectIdOrNull get(): ProjectComponentIdentifier? { +internal val ResolvedComponentResult.currentBuildProjectIdOrNull get(): ProjectComponentIdentifier? { val identifier = id return when { identifier is ProjectComponentIdentifier && identifier.build.isCurrentBuild -> identifier @@ -281,7 +280,7 @@ internal fun MetadataDependencyResolution.projectDependency(currentProject: Proj dependency.toProjectOrNull(currentProject) internal fun ResolvedComponentResult.toProjectOrNull(currentProject: Project): Project? { - val projectId = projectIdOrNull ?: return null + val projectId = currentBuildProjectIdOrNull ?: return null return currentProject.project(projectId.projectPath) } diff --git a/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/sources/DefaultKotlinSourceSet.kt b/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/sources/DefaultKotlinSourceSet.kt index 73ee1f42778..89f68361787 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/sources/DefaultKotlinSourceSet.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/plugin/sources/DefaultKotlinSourceSet.kt @@ -163,7 +163,7 @@ abstract class DefaultKotlinSourceSet @Inject constructor( return metadataDependencyResolutionByModule.mapNotNull { (groupAndName, resolution) -> val (group, name) = groupAndName - val projectPath = resolution.dependency.projectIdOrNull?.projectPath + val projectPath = resolution.dependency.currentBuildProjectIdOrNull?.projectPath when (resolution) { // No metadata transformation leads to original dependency being used during import is MetadataDependencyResolution.KeepOriginalDependency -> null diff --git a/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/metadata/KotlinMetadataTargetConfigurator.kt b/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/metadata/KotlinMetadataTargetConfigurator.kt index 2f1607e7586..094dc390d3e 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/metadata/KotlinMetadataTargetConfigurator.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/metadata/KotlinMetadataTargetConfigurator.kt @@ -25,7 +25,6 @@ import org.jetbrains.kotlin.gradle.plugin.sources.* import org.jetbrains.kotlin.gradle.plugin.statistics.KotlinBuildStatsService import org.jetbrains.kotlin.gradle.targets.native.internal.* import org.jetbrains.kotlin.gradle.tasks.* -import org.jetbrains.kotlin.gradle.utils.addExtendsFromRelation import org.jetbrains.kotlin.gradle.utils.lowerCamelCaseName import org.jetbrains.kotlin.statistics.metrics.BooleanMetrics import java.util.concurrent.Callable @@ -387,7 +386,7 @@ class KotlinMetadataTargetConfigurator : configuration.exclude(mapOf("group" to group, "module" to name)) } - requested.filter { it.dependency.projectIdOrNull == null }.forEach { + requested.filter { it.dependency.currentBuildProjectIdOrNull == null }.forEach { val (group, name) = ModuleIds.fromComponent(project, it.dependency) val notation = listOfNotNull(group.orEmpty(), name, it.dependency.moduleVersion?.version).joinToString(":") configuration.resolutionStrategy.force(notation)