diff --git a/compiler/cli/cli-js/src/org/jetbrains/kotlin/cli/js/K2JsIrCompiler.kt b/compiler/cli/cli-js/src/org/jetbrains/kotlin/cli/js/K2JsIrCompiler.kt index 7eadde7cc57..ab8986d6150 100644 --- a/compiler/cli/cli-js/src/org/jetbrains/kotlin/cli/js/K2JsIrCompiler.kt +++ b/compiler/cli/cli-js/src/org/jetbrains/kotlin/cli/js/K2JsIrCompiler.kt @@ -142,7 +142,10 @@ class K2JsIrCompiler : CLICompiler() { // TODO: Handle non-empty main call arguments val mainCallArguments = if (K2JsArgumentConstants.NO_CALL == arguments.main) null else emptyList() - val resolvedLibraries = jsResolveLibraries(libraries, messageCollectorLogger(configuration)) + val resolvedLibraries = jsResolveLibraries( + libraries, + messageCollectorLogger(configuration[CLIConfigurationKeys.MESSAGE_COLLECTOR_KEY] ?: error("Could not find message collector")) + ) val friendAbsolutePaths = friendLibraries.map { File(it).absolutePath } val friendDependencies = resolvedLibraries.getFullList().filter { @@ -337,8 +340,7 @@ class K2JsIrCompiler : CLICompiler() { } } -fun messageCollectorLogger(configuration: CompilerConfiguration) = object : Logger { - val collector = configuration[CLIConfigurationKeys.MESSAGE_COLLECTOR_KEY]!! +fun messageCollectorLogger(collector: MessageCollector) = object : Logger { override fun warning(message: String)= collector.report(STRONG_WARNING, message) override fun error(message: String) = collector.report(ERROR, message) override fun log(message: String) = collector.report(LOGGING, message) diff --git a/compiler/ir/serialization.js/build.gradle.kts b/compiler/ir/serialization.js/build.gradle.kts index ac6affed0c1..74aa41b12a6 100644 --- a/compiler/ir/serialization.js/build.gradle.kts +++ b/compiler/ir/serialization.js/build.gradle.kts @@ -12,7 +12,7 @@ dependencies { testCompile(intellijCoreDep()) { includeJars("intellij-core") } testCompile(project(":compiler:frontend")) - testCompile(project(":compiler:cli")) + testCompile(project(":compiler:cli-js")) testCompile(project(":compiler:util")) testRuntime(project(":kotlin-reflect")) diff --git a/compiler/ir/serialization.js/test/GenerateIrRuntime.kt b/compiler/ir/serialization.js/test/GenerateIrRuntime.kt index a5b7570ff47..5d387fa008d 100644 --- a/compiler/ir/serialization.js/test/GenerateIrRuntime.kt +++ b/compiler/ir/serialization.js/test/GenerateIrRuntime.kt @@ -9,6 +9,8 @@ import com.intellij.openapi.Disposable import com.intellij.openapi.vfs.StandardFileSystems import com.intellij.openapi.vfs.VirtualFileManager import com.intellij.psi.PsiManager +import org.jetbrains.kotlin.cli.common.messages.MessageCollector +import org.jetbrains.kotlin.cli.js.messageCollectorLogger import org.jetbrains.kotlin.cli.jvm.compiler.EnvironmentConfigFiles import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment import org.jetbrains.kotlin.config.* @@ -17,7 +19,6 @@ import org.jetbrains.kotlin.library.resolver.KotlinLibraryResolveResult import org.jetbrains.kotlin.psi.KtFile import org.jetbrains.kotlin.resolve.multiplatform.isCommonSource import org.jetbrains.kotlin.serialization.js.ModuleKind -import org.jetbrains.kotlin.util.Logger import java.io.File fun buildConfiguration(environment: KotlinCoreEnvironment, moduleName: String): CompilerConfiguration { @@ -115,13 +116,7 @@ fun main(args: Array) { } val resolvedLibraries = jsResolveLibraries( - dependencies, - object : Logger { - override fun log(message: String) = println(message) - override fun error(message: String) = kotlin.error(message) - override fun warning(message: String) = println(message) - override fun fatal(message: String) = kotlin.error(message) - } + dependencies, messageCollectorLogger(MessageCollector.NONE) ) buildKLib(File(outputPath).absolutePath, listOfKtFilesFrom(inputFiles), outputPath, resolvedLibraries, listOfKtFilesFrom(commonSources)) diff --git a/js/js.tests/test/org/jetbrains/kotlin/js/test/BasicIrBoxTest.kt b/js/js.tests/test/org/jetbrains/kotlin/js/test/BasicIrBoxTest.kt index 77b05739dcd..ee9df3145c2 100644 --- a/js/js.tests/test/org/jetbrains/kotlin/js/test/BasicIrBoxTest.kt +++ b/js/js.tests/test/org/jetbrains/kotlin/js/test/BasicIrBoxTest.kt @@ -7,6 +7,7 @@ package org.jetbrains.kotlin.js.test import org.jetbrains.kotlin.backend.common.phaser.PhaseConfig import org.jetbrains.kotlin.backend.common.phaser.toPhaseMap +import org.jetbrains.kotlin.cli.common.messages.MessageCollector import org.jetbrains.kotlin.cli.js.messageCollectorLogger import org.jetbrains.kotlin.ir.backend.js.compile import org.jetbrains.kotlin.ir.backend.js.generateKLib @@ -85,7 +86,7 @@ abstract class BasicIrBoxTest( compilationCache[it] ?: error("Can't find compiled module for dependency $it") }).map { File(it).absolutePath } - val resolvedLibraries = jsResolveLibraries(allKlibPaths, messageCollectorLogger(config.configuration)) + val resolvedLibraries = jsResolveLibraries(allKlibPaths, messageCollectorLogger(MessageCollector.NONE)) val actualOutputFile = outputFile.absolutePath.let { if (!isMainModule) it.replace("_v5.js", "/") else it