Rename platform to targetPlatform in KotlinFacetSettings to avoid ambiguity in Java

Original commit: aeb7f8400a
This commit is contained in:
Dmitry Savvinov
2019-05-28 15:43:23 +03:00
parent 1d14c6e7e3
commit c1eb93ba14
5 changed files with 7 additions and 10 deletions
@@ -189,7 +189,7 @@ class KotlinFacetSettings {
compilerArguments!!.apiVersion = value?.versionString compilerArguments!!.apiVersion = value?.versionString
} }
val platform: TargetPlatform? val targetPlatform: TargetPlatform?
get() { get() {
val compilerArguments = this.compilerArguments ?: return null val compilerArguments = this.compilerArguments ?: return null
return IdePlatformKind.platformByCompilerArguments(compilerArguments) return IdePlatformKind.platformByCompilerArguments(compilerArguments)
@@ -202,7 +202,7 @@ class KotlinFacetSettings {
level = DeprecationLevel.ERROR level = DeprecationLevel.ERROR
) )
fun getPlatform(): org.jetbrains.kotlin.platform.IdePlatform<*, *>? { fun getPlatform(): org.jetbrains.kotlin.platform.IdePlatform<*, *>? {
return platform?.toIdePlatform() return targetPlatform?.toIdePlatform()
} }
var coroutineSupport: LanguageFeature.State? var coroutineSupport: LanguageFeature.State?
@@ -35,7 +35,6 @@ import org.jetbrains.kotlin.platform.jvm.JvmPlatform
import org.jetbrains.kotlin.platform.konan.KonanPlatform import org.jetbrains.kotlin.platform.konan.KonanPlatform
import org.jetbrains.kotlin.platform.oldFashionedDescription import org.jetbrains.kotlin.platform.oldFashionedDescription
import org.jetbrains.kotlin.platform.orDefault import org.jetbrains.kotlin.platform.orDefault
import org.jetbrains.kotlin.resolve.*
import java.lang.reflect.Modifier import java.lang.reflect.Modifier
import kotlin.reflect.KClass import kotlin.reflect.KClass
import kotlin.reflect.full.superclasses import kotlin.reflect.full.superclasses
@@ -288,7 +287,7 @@ private fun buildChildElement(element: Element, tag: String, bean: Any, filter:
private fun KotlinFacetSettings.writeLatestConfig(element: Element) { private fun KotlinFacetSettings.writeLatestConfig(element: Element) {
val filter = SkipDefaultsSerializationFilter() val filter = SkipDefaultsSerializationFilter()
platform?.let { targetPlatform?.let {
element.setAttribute("platform", it.oldFashionedDescription) element.setAttribute("platform", it.oldFashionedDescription)
} }
if (!useProjectSettings) { if (!useProjectSettings) {
@@ -469,7 +469,7 @@ abstract class AbstractIncrementalJpsTest(
private fun configureRequiredLibraries() { private fun configureRequiredLibraries() {
myProject.modules.forEach { module -> myProject.modules.forEach { module ->
val platformKind = module.kotlinFacet?.settings?.platform?.idePlatformKind.orDefault() val platformKind = module.kotlinFacet?.settings?.targetPlatform?.idePlatformKind.orDefault()
when { when {
platformKind.isJvm -> { platformKind.isJvm -> {
@@ -16,8 +16,6 @@ import org.jetbrains.kotlin.config.KotlinModuleKind.COMPILATION_AND_SOURCE_SET_H
import org.jetbrains.kotlin.config.KotlinModuleKind.SOURCE_SET_HOLDER import org.jetbrains.kotlin.config.KotlinModuleKind.SOURCE_SET_HOLDER
import org.jetbrains.kotlin.jps.build.dependeciestxt.ModulesTxt.Dependency.Kind.* import org.jetbrains.kotlin.jps.build.dependeciestxt.ModulesTxt.Dependency.Kind.*
import org.jetbrains.kotlin.platform.impl.FakeK2NativeCompilerArguments import org.jetbrains.kotlin.platform.impl.FakeK2NativeCompilerArguments
import org.jetbrains.kotlin.platform.impl.isCommon
import org.jetbrains.kotlin.platform.impl.isJvm
import org.jetbrains.kotlin.platform.isCommon import org.jetbrains.kotlin.platform.isCommon
import org.jetbrains.kotlin.platform.jvm.isJvm import org.jetbrains.kotlin.platform.jvm.isJvm
import java.io.File import java.io.File
@@ -54,11 +52,11 @@ data class ModulesTxt(
val isCommonModule val isCommonModule
get() = get() =
kotlinFacetSettings?.platform.isCommon() || kotlinFacetSettings?.targetPlatform.isCommon() ||
kotlinFacetSettings?.kind == SOURCE_SET_HOLDER kotlinFacetSettings?.kind == SOURCE_SET_HOLDER
val isJvmModule val isJvmModule
get() = kotlinFacetSettings?.platform.isJvm() get() = kotlinFacetSettings?.targetPlatform.isJvm()
val expectedBy val expectedBy
get() = dependencies.filter { get() = dependencies.filter {
@@ -17,7 +17,7 @@ val JpsModule.kotlinFacet: JpsKotlinFacetModuleExtension?
get() = container.getChild(JpsKotlinFacetModuleExtension.KIND) get() = container.getChild(JpsKotlinFacetModuleExtension.KIND)
val JpsModule.platform: TargetPlatform? val JpsModule.platform: TargetPlatform?
get() = kotlinFacet?.settings?.platform get() = kotlinFacet?.settings?.targetPlatform
val JpsModule.kotlinKind: KotlinModuleKind val JpsModule.kotlinKind: KotlinModuleKind
get() = kotlinFacet?.settings?.kind ?: KotlinModuleKind.DEFAULT get() = kotlinFacet?.settings?.kind ?: KotlinModuleKind.DEFAULT