[SLC] fix multifile-classes in multiplatform case

Multifile-class can contain not only files from the same
module, but also files from the common part.
This commit also fixes KotlinByModulesResolutionScopeProvider as
it should provide all transitive dependencies

^KT-64714 Fixed

analysis/analysis-api-providers/src/org/jetbrains/kotlin/analysis/providers/impl/KotlinByModulesResolutionScopeProvider.kt

@@ -1,5 +1,5 @@
 /*
- * Copyright 2010-2023 JetBrains s.r.o. and Kotlin Programming Language contributors.
+ * Copyright 2010-2024 JetBrains s.r.o. and Kotlin Programming Language contributors.
  * Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
  */
 
@@ -7,15 +7,19 @@ package org.jetbrains.kotlin.analysis.providers.impl
 
 import com.intellij.psi.search.GlobalSearchScope
 import org.jetbrains.kotlin.analysis.project.structure.KtModule
-import org.jetbrains.kotlin.analysis.project.structure.allDirectDependencies
 import org.jetbrains.kotlin.analysis.providers.KotlinResolutionScopeProvider
+import org.jetbrains.kotlin.utils.topologicalSort
 
 public class KotlinByModulesResolutionScopeProvider : KotlinResolutionScopeProvider() {
     override fun getResolutionScope(module: KtModule): GlobalSearchScope {
-        val allModules = buildList {
-            add(module)
-            addAll(module.allDirectDependencies())
+        val allModules = topologicalSort(listOf(module)) {
+            buildList {
+                addAll(directDependsOnDependencies)
+                addAll(directFriendDependencies)
+                addAll(directRegularDependencies)
+            }
         }
+
         return GlobalSearchScope.union(allModules.map { it.contentScope })
     }
-}
+}

analysis/light-classes-base/src/org/jetbrains/kotlin/asJava/KotlinAsJavaSupportBase.kt

@@ -40,7 +40,7 @@ abstract class KotlinAsJavaSupportBase<TModule : Any>(protected val project: Pro
         return when {
             facadeFiles.none(KtFile::hasTopLevelCallables) -> null
             facadeFiles.none(KtFile::isCompiled) -> {
-                LightClassCachedValue(createInstanceOfLightFacade(facadeFqName, facadeFiles), outOfBlockModificationTracker(file))
+                LightClassCachedValue(createInstanceOfLightFacade(facadeFqName, module, facadeFiles), outOfBlockModificationTracker(file))
             }
 
             facadeFiles.all(KtFile::isCompiled) -> {
@@ -68,6 +68,10 @@ abstract class KotlinAsJavaSupportBase<TModule : Any>(protected val project: Pro
     protected abstract val TModule.contentSearchScope: GlobalSearchScope
 
     protected abstract fun createInstanceOfLightFacade(facadeFqName: FqName, files: List<KtFile>): KtLightClassForFacade?
+    protected open fun createInstanceOfLightFacade(facadeFqName: FqName, module: TModule, files: List<KtFile>): KtLightClassForFacade? {
+        return createInstanceOfLightFacade(facadeFqName, files)
+    }
+
     protected abstract fun createInstanceOfDecompiledLightFacade(facadeFqName: FqName, files: List<KtFile>): KtLightClassForFacade?
 
     protected open fun projectWideOutOfBlockModificationTracker(): ModificationTracker {

analysis/symbol-light-classes/src/org/jetbrains/kotlin/light/classes/symbol/SymbolKotlinAsJavaSupport.kt

@@ -141,10 +141,22 @@ class SymbolKotlinAsJavaSupport(project: Project) : KotlinAsJavaSupportBase<KtMo
 
     override fun createInstanceOfLightFacade(facadeFqName: FqName, files: List<KtFile>): KtLightClassForFacade? {
         val module = files.first().getModuleIfSupportEnabled() ?: return null
+        return createInstanceOfLightFacade(facadeFqName, module, files)
+    }
+
+    override fun createInstanceOfLightFacade(facadeFqName: FqName, module: KtModule, files: List<KtFile>): KtLightClassForFacade? {
         return SymbolLightClassForFacade(facadeFqName, files, module)
     }
 
-    override val KtModule.contentSearchScope: GlobalSearchScope get() = this.contentScope
+    override val KtModule.contentSearchScope: GlobalSearchScope
+        get() = GlobalSearchScope.union(
+            buildList {
+                add(contentScope)
+                for (dependency in transitiveDependsOnDependencies) {
+                    add(dependency.contentScope)
+                }
+            }
+        )
 
     override fun facadeIsApplicable(module: KtModule, file: KtFile): Boolean =
         module.isFromSourceOrLibraryBinary() && module.isLightClassesEnabled()