KT-19276: Drop exception logging on loading script definitions failure

See YT discussion
Have to come up with more meaningful diagnostics on definition loading

#KT-19276 Fixed
This commit is contained in:
Pavel V. Talanov
2017-08-17 18:12:49 +03:00
parent 6424b6760f
commit c132f3b0d1
2 changed files with 4 additions and 2 deletions
@@ -61,7 +61,7 @@ interface ScriptTemplatesProvider {
} }
fun makeScriptDefsFromTemplatesProviderExtensions(project: Project, fun makeScriptDefsFromTemplatesProviderExtensions(project: Project,
errorsHandler: ((ScriptTemplatesProvider, Throwable) -> Unit) = { _, ex -> throw ex } errorsHandler: ((ScriptTemplatesProvider, Throwable) -> Unit)
): List<KotlinScriptDefinition> = ): List<KotlinScriptDefinition> =
makeScriptDefsFromTemplatesProviders(Extensions.getArea(project).getExtensionPoint(ScriptTemplatesProvider.EP_NAME).extensions.asIterable(), makeScriptDefsFromTemplatesProviders(Extensions.getArea(project).getExtensionPoint(ScriptTemplatesProvider.EP_NAME).extensions.asIterable(),
errorsHandler) errorsHandler)
@@ -54,7 +54,9 @@ class ScriptDependenciesManager internal constructor(
fun getScriptDependencies(file: VirtualFile) = cacheUpdater.getCurrentDependencies(file) fun getScriptDependencies(file: VirtualFile) = cacheUpdater.getCurrentDependencies(file)
private fun reloadScriptDefinitions() { private fun reloadScriptDefinitions() {
val def = makeScriptDefsFromTemplatesProviderExtensions(project, { ep, ex -> log.warn("[kts] Error loading definition from ${ep.id}", ex) }) val def = makeScriptDefsFromTemplatesProviderExtensions(
project, { ep, ex -> /* do nothing, logging these exception creates too much noise*/}
)
scriptDefinitionProvider.setScriptDefinitions(def) scriptDefinitionProvider.setScriptDefinitions(def)
} }