From c0a4301179b8bf041812aa632b3764a2ccc67d75 Mon Sep 17 00:00:00 2001 From: Roman Golyshev Date: Thu, 4 Feb 2021 15:01:38 +0300 Subject: [PATCH] FIR IDE: Enhance check messages in `KtFirReferenceShortener` --- .../api/fir/components/KtFirReferenceShortener.kt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/idea/idea-frontend-fir/src/org/jetbrains/kotlin/idea/frontend/api/fir/components/KtFirReferenceShortener.kt b/idea/idea-frontend-fir/src/org/jetbrains/kotlin/idea/frontend/api/fir/components/KtFirReferenceShortener.kt index 40013c40c35..a87f41cf98e 100644 --- a/idea/idea-frontend-fir/src/org/jetbrains/kotlin/idea/frontend/api/fir/components/KtFirReferenceShortener.kt +++ b/idea/idea-frontend-fir/src/org/jetbrains/kotlin/idea/frontend/api/fir/components/KtFirReferenceShortener.kt @@ -206,7 +206,9 @@ internal class KtFirReferenceShortener( val (mostTopLevelClassId, mostTopLevelTypeElement) = allClassIds.zip(allTypeElements).last() val availableClassifier = findFirstClassifierInScopesByName(positionScopes, mostTopLevelClassId.shortClassName) - check(availableClassifier?.classId != mostTopLevelClassId) { "This should not be true" } + check(availableClassifier?.classId != mostTopLevelClassId) { + "If this condition were true, we would have exited from the loop on the last iteration. ClassId = $mostTopLevelClassId" + } if (availableClassifier == null || availableClassifier.isFromStarOrPackageImport) { addTypeToImportAndShorten(mostTopLevelClassId.asSingleFqName(), mostTopLevelTypeElement) @@ -360,7 +362,9 @@ internal class KtFirReferenceShortener( val (mostTopLevelClassId, mostTopLevelQualifier) = allClassIds.zip(allQualifiers).last() val availableClassifier = findFirstClassifierInScopesByName(positionScopes, mostTopLevelClassId.shortClassName) - check(availableClassifier?.classId != mostTopLevelClassId) { "This should not be true" } + check(availableClassifier?.classId != mostTopLevelClassId) { + "If this condition were true, we would have exited from the loop on the last iteration. ClassId = $mostTopLevelClassId" + } if (availableClassifier == null || availableClassifier.isFromStarOrPackageImport) { addElementToImportAndShorten(mostTopLevelClassId.asSingleFqName(), mostTopLevelQualifier)