KT-2363 Drop secondary constructors

#KT-2363 Fixed

compiler/testData/diagnostics/tests/Abstract.kt

@@ -53,10 +53,9 @@ abstract class B1(
 class B2() : B1(1, "r") {}
 
 abstract class B3(i: Int) {
-    <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(): this(1)<!>
 }
 
 fun foo(<!UNUSED_PARAMETER!>c<!>: B3) {
-    val <!UNUSED_VARIABLE!>a<!> = <!CREATING_AN_INSTANCE_OF_ABSTRACT_CLASS!>B3()<!>
+    val <!UNUSED_VARIABLE!>a<!> = <!CREATING_AN_INSTANCE_OF_ABSTRACT_CLASS!>B3(1)<!>
     val <!UNUSED_VARIABLE!>b<!> = <!CREATING_AN_INSTANCE_OF_ABSTRACT_CLASS!>B1(2, "s")<!>
 }

compiler/testData/diagnostics/tests/AnonymousInitializers.kt

@@ -26,9 +26,4 @@ class WithC() {
     val zz = x
     val zzz = <!NO_BACKING_FIELD_CUSTOM_ACCESSORS!>$a<!>
   }
-
-  <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(a : Int) : this() {
-    val <!UNUSED_VARIABLE!>b<!> = x
-  }<!>
-
 }

compiler/testData/diagnostics/tests/Constructors.kt

@@ -7,24 +7,10 @@ class NoC2 : <!SUPERTYPE_NOT_INITIALIZED_DEFAULT!>WithC1<!>
 class NoC3 : WithC1()
 class WithC2() : <!SUPERTYPE_NOT_INITIALIZED_DEFAULT!>WithC1<!>
 
-class <!CONFLICTING_OVERLOADS!>NoPC<!> {
-  <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED, CONFLICTING_OVERLOADS!><!SECONDARY_CONSTRUCTOR_NO_INITIALIZER_LIST!>this<!>() {}<!>
-}
-
 class WithPC0() {
-  <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(a : Int) : this() {}<!>
 }
 
 class WithPC1(a : Int) {
-  <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!><!SECONDARY_CONSTRUCTOR_NO_INITIALIZER_LIST!>this<!>() {}<!>
-
-  <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(b : Long) : this("") {}<!>
-
-  <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(s : String) : this(1) {}<!>
-
-  <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(b : Char) : <!NONE_APPLICABLE!>this<!>("", 2) {}<!>
-
-  <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(b : Byte) : this(""), <!MANY_CALLS_TO_THIS!>this(1)<!> {}<!>
 }
 
 

compiler/testData/diagnostics/tests/DefaultValuesTypechecking.kt

@@ -7,7 +7,7 @@ fun bar(x : Int = <!TYPE_MISMATCH!>""<!>, y : Int = x, <!UNUSED_PARAMETER!>z<!>
 // KT-371 Resolve default parameters for constructors
 
 class A(x : Int = <!UNINITIALIZED_PARAMETER!>y<!>, y : Int = x) { // None of the references is resolved, no types checked
-    <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(bool: Boolean, a: Int = <!TYPE_MISMATCH, UNINITIALIZED_PARAMETER!>b<!>, b: String = <!TYPE_MISMATCH!>a<!>) : this(1) {}<!>
+    fun foo(<!UNUSED_PARAMETER!>bool<!>: Boolean, a: Int = <!TYPE_MISMATCH, UNINITIALIZED_PARAMETER!>b<!>, <!UNUSED_PARAMETER!>b<!>: String = <!TYPE_MISMATCH!>a<!>) {}
 }
 
 val z = 3

compiler/testData/diagnostics/tests/FunctionReturnTypes.kt

@@ -137,12 +137,6 @@ fun nonBlockNoReturnIfUnitInOneBranch(): Int = if (1 < 2) <!TYPE_MISMATCH!>{}<!>
 val a = <!RETURN_NOT_ALLOWED!>return 1<!>
 
 class A() {
-  <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(a : Int) : this() {
-    if (a == 1)
-      return
-    return <!TYPE_MISMATCH!>1<!>
-  }<!>
-
 }
 fun illegalConstantBody(): Int = <!TYPE_MISMATCH!>"s"<!>
 fun illegalConstantBlock(): String {

compiler/testData/diagnostics/tests/Properties.kt

@@ -16,11 +16,12 @@ class Test() {
     var a : Int = 111
     var b : Int get() = $a; set(x) {a = x; $a = x}
 
-   <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(i : Int) : this() {
+   {
     <!NO_BACKING_FIELD_CUSTOM_ACCESSORS!>$b<!> = $a
     $a = <!NO_BACKING_FIELD_CUSTOM_ACCESSORS!>$b<!>
     a = <!NO_BACKING_FIELD_CUSTOM_ACCESSORS!>$b<!>
-   }<!>
+   }
+
    fun f() {
     <!NO_BACKING_FIELD_CUSTOM_ACCESSORS!>$b<!> = $a
     a = <!NO_BACKING_FIELD_CUSTOM_ACCESSORS!>$b<!>

compiler/testData/diagnostics/tests/SupertypeListChecks.kt

@@ -22,7 +22,6 @@ trait T1 {}
 trait T2<T> {}
 
 trait Test<!CONSTRUCTOR_IN_TRAIT!>()<!> {
-    <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!><!CONSTRUCTOR_IN_TRAIT, SECONDARY_CONSTRUCTOR_NO_INITIALIZER_LIST!>this<!>(x : Int) {}<!>
 }
 
 trait Test1 : C2<!SUPERTYPE_INITIALIZED_IN_TRAIT!>()<!> {}

compiler/testData/diagnostics/tests/TraitSupertypeList.kt

@@ -1,7 +1,6 @@
 open class bar()
 
 trait Foo<!CONSTRUCTOR_IN_TRAIT!>()<!> : bar<!SUPERTYPE_INITIALIZED_IN_TRAIT!>()<!>, <!MANY_CLASSES_IN_SUPERTYPE_LIST, SUPERTYPE_APPEARS_TWICE!>bar<!>, <!MANY_CLASSES_IN_SUPERTYPE_LIST, SUPERTYPE_APPEARS_TWICE!>bar<!> {
-    <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!><!CONSTRUCTOR_IN_TRAIT, SECONDARY_CONSTRUCTOR_NO_INITIALIZER_LIST!>this<!>(x : Int) {}<!>
 }
 
 trait Foo2 : bar, Foo {

compiler/testData/diagnostics/tests/regressions/ScopeForSecondaryConstructors.kt

@@ -1,17 +0,0 @@
-class Foo(var bar : Int, var barr : Int, var barrr : Int) {
-    {
-      bar = 1
-      barr = 1
-      barrr = 1
-      1 : Int
-      this : Foo
-    }
-
-    <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(var bar : Int) : this(1, 1, 1) {
-      bar = <!UNUSED_VALUE!>1<!>
-      this.bar
-      1 : Int
-      val <!UNUSED_VARIABLE!>a<!> : Int =1
-      this : Foo
-    }<!>
-  }

compiler/testData/diagnostics/tests/regressions/ThisConstructorInGenericClass.kt

@@ -1,3 +0,0 @@
-class Z() {
-    <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(x : Int) : this() {}<!>
-}

compiler/testData/diagnostics/tests/scopes/kt250.617.10.kt

@@ -42,7 +42,6 @@ open class X(p: Int, r: Int) {
 
 class Y(i: Int) : X(i, <!UNRESOLVED_REFERENCE!>rrr<!>) {
     val rrr = 3
-    <!SECONDARY_CONSTRUCTORS_ARE_NOT_SUPPORTED!>this(s: Int, r: Int) : this(s, <!UNRESOLVED_REFERENCE!>rrr<!>)<!>
 }
 
 class Z(val i: Int) : X(<!UNRESOLVED_REFERENCE!>s<!>, <!UNRESOLVED_REFERENCE!>x<!>) {