[FIR] Update/add extended checker tests

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/BasicTest.kt

@@ -3,5 +3,5 @@ fun goo() {
     val b = 4
     a <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> a + 1 + b
     a <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> (a + 1)
-    a = a * b + 1
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>a<!> = a * b + 1
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/ComplexExpression.kt

@@ -1,4 +1,4 @@
 fun foo() {
     var a = 0
-    a = (a + 1) / 2
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>a<!> = (a + 1) / 2
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/OperatorAssignment.kt

@@ -1,4 +1,4 @@
 fun foo() {
     var a = 0
-    a += 10 + a
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>a<!> += 10 + a
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/flexibleTypeBug.kt

@@ -2,5 +2,5 @@
 fun foo() {
     var list1 = java.util.Collections.emptyList<String>()
     val list2 = listOf("b")
-    list1 = list1 + list2
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>list1<!> = list1 + list2
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/illegalMultipleOperators.kt

@@ -1,4 +1,4 @@
 fun foo() {
     var x = 0
-    x = x / 1 + 1
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>x<!> = x / 1 + 1
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/illegalMultipleOperatorsMiddle.kt

@@ -1,5 +1,5 @@
 fun foo() {
     var x = 0
     val y = 0
-    x = y / x + 0
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>x<!> = y / x + 0
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/invalidSubtraction.kt

@@ -1,4 +1,4 @@
 fun foo() {
     var x = 0
-    x = 1 - x
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>x<!> = 1 - x
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/list.kt

@@ -3,5 +3,5 @@ fun foo() {
     var list = listOf(1, 2, 3)
     // Should not be highlighted because it's the way we use to say explicitly
     // "yes, we want to re-assign this immutable list"
-    list = list + 4
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>list<!> = list + 4
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/logicOperators.kt

@@ -1,4 +1,4 @@
 fun foo(something: Boolean) {
     var res = false
-    res = res and something
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>res<!> = res and something
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/multipleOperators.kt

@@ -1,5 +1,5 @@
 fun foo() {
     var x = 0
     <!CAN_BE_VAL!>var<!> y = 0
-    x <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> x + y + 5
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>x<!> <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> x + y + 5
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/multipleOperatorsRightSideRepeat.kt

@@ -1,5 +1,5 @@
 fun foo() {
     var x = 0
     <!CAN_BE_VAL!>var<!> y = 0
-    x <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> y + x + 5
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>x<!> <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> y + x + 5
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/mutableList.kt

@@ -5,5 +5,5 @@ fun foo() {
     // now, Idea hightlights this code like error (cuz listVar
     // is mutable and listVar + 4 is immutable) and like warning
     // (cuz can be replaced with +=)
-    listVar = listVar + 4
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>listVar<!> = listVar + 4
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/nonCommutativeRepeat.kt

@@ -4,5 +4,5 @@ fun foo() {
 
     x <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> x / 1
     x = 1 / x
-    x <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> -1 + x
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>x<!> <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> -1 + x
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/nonRepeatingAssignment.kt

@@ -1,6 +1,6 @@
 fun foo() {
-    var x = 0
+    var <!VARIABLE_NEVER_READ!>x<!> = 0
     val y = 0
     val z = 0
-    x = y + z
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>x<!> = y + z
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/plusAssignConflict.kt

@@ -6,5 +6,5 @@ operator fun A.plusAssign(a: A){}
 fun foo() {
     var a1 = A()
     val a2 = A()
-    a1 = a1 + a2
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>a1<!> = a1 + a2
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/rightSideRepeat.kt

@@ -1,4 +1,4 @@
 fun foo() {
     var x = 0
-    x <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> 1 + x
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>x<!> <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> 1 + x
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/simpleAssign.kt

@@ -1,5 +1,5 @@
 fun foo() {
     var y = 0
     val x = 0
-    y <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> y + x
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>y<!> <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> y + x
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/validAddition.kt

@@ -1,4 +1,4 @@
 fun foo() {
     var x = 0
-    x <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> x + 1
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>x<!> <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> x + 1
 }

compiler/fir/analysis-tests/testData/extendedCheckers/canBeReplacedWithOperatorAssignment/validSubtraction.kt

@@ -1,4 +1,4 @@
 fun foo() {
     var x = 0
-    x <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> x - 1
+    <!ASSIGNED_VALUE_IS_NEVER_READ!>x<!> <!CAN_BE_REPLACED_WITH_OPERATOR_ASSIGNMENT!>=<!> x - 1
 }