Introduce "Useless call on collection type" inspection

Related to KT-12165
Supported functions: filterNotNull, filterIsInstance,
mapNotNull, mapNotNullTo, mapIndexedNotNull, mapIndexedNotNullTo

Also, "Useless cal on not-null" improved a bit

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.collections.UselessCallOnCollectionInspection

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/FilterIsExactInstance.kt

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val x = listOf("1").<caret>filterIsInstance<String>()

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/FilterIsExactInstance.kt.after

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val x = listOf("1")

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/FilterIsExactInstanceFake.kt

@@ -0,0 +1,4 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+val x = listOf(true, "1").<caret>filterIsInstance<String>()

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/FilterIsForFlexible.kt

@@ -0,0 +1,4 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+val x = listOf(System.getProperty("")).<caret>filterIsInstance<String>()

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/FilterIsSupertypeInstance.kt

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val x = listOf("1").<caret>filterIsInstance<Any>()

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/FilterIsSupertypeInstance.kt.after

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val x = listOf("1")

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/FilterIsSupertypeInstanceFake.kt

@@ -0,0 +1,4 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+val x = listOf("1", null).<caret>filterIsInstance<Any>()

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/FilterNotNull.kt

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val x = listOf("1").<caret>filterNotNull()

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/FilterNotNull.kt.after

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val x = listOf("1")

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/MapIndexedNotNullTo.kt

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val someList = listOf("alpha", "beta").<caret>mapIndexedNotNullTo(destination = hashSetOf()) { index, value -> index + value.length }

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/MapIndexedNotNullTo.kt.after

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val someList = listOf("alpha", "beta").mapIndexedTo(destination = hashSetOf()) { index, value -> index + value.length }

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/MapNotNullTo.kt

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val x = listOf("1").<caret>mapNotNullTo(mutableSetOf()) { it.toInt() }

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/MapNotNullTo.kt.after

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val x = listOf("1").mapTo(mutableSetOf()) { it.toInt() }

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/MapNotNullWithLambda.kt

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val x = listOf("1").<caret>mapNotNull { it.toInt() }

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/MapNotNullWithLambda.kt.after

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val x = listOf("1").map { it.toInt() }

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/MapNotNullWithLambdaFake.kt

@@ -0,0 +1,4 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+val x = listOf("1").<caret>mapNotNull { if (it.isNotEmpty()) it.toInt() else null }

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/MapNotNullWithReference.kt

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val x = listOf("1").<caret>mapNotNull(String::toInt)

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/MapNotNullWithReference.kt.after

@@ -0,0 +1,3 @@
+// WITH_RUNTIME
+
+val x = listOf("1").map(String::toInt)

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/MapNotNullWithReferenceFake.kt

@@ -0,0 +1,6 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun String.toNullableInt(): Int? = null
+
+val x = listOf("1").<caret>mapNotNull(String::toNullableInt)

idea/testData/inspectionsLocal/collections/uselessCallOnCollection/filterNotNullFake.kt

@@ -0,0 +1,4 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+val x = listOf("1", null).<caret>filterNotNull()

idea/testData/inspectionsLocal/collections/uselessCallOnNotNull/NullOrBlankSafe.kt

@@ -1,4 +1,5 @@
 // WITH_RUNTIME
+// FIX: Rename useless call to 'isBlank'
 
 val s: String? = ""
 val blank = s<caret>?.isNullOrBlank()

idea/testData/inspectionsLocal/collections/uselessCallOnNotNull/NullOrBlankSafe.kt.after

@@ -1,4 +1,5 @@
 // WITH_RUNTIME
+// FIX: Rename useless call to 'isBlank'
 
 val s: String? = ""
 val blank = s?.isBlank()

idea/testData/inspectionsLocal/collections/uselessCallOnNotNull/NullOrEmptySafe.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+// FIX: Replace with dot call
+
+val s: String? = ""
+val empty = s<caret>?.isNullOrEmpty()

idea/testData/inspectionsLocal/collections/uselessCallOnNotNull/NullOrEmptySafe.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+// FIX: Replace with dot call
+
+val s: String? = ""
+val empty = s.isNullOrEmpty()