New IC: Add tests for constants-in-companion-objects impact computation

^KT-53266 Fixed

compiler/incremental-compilation-impl/test/org/jetbrains/kotlin/incremental/classpathDiff/ClasspathChangesComputerTest.kt

@@ -131,29 +131,6 @@ class KotlinOnlyClasspathChangesComputerTest : ClasspathChangesComputerTest() {
         ).assertEquals(changes)
     }
 
-    @Test
-    override fun testImpactComputation_SupertypesInheritors() {
-        val changes = computeClasspathChanges(File(testDataDir, "KotlinOnly/testImpactComputation_SupertypesInheritors/src"), tmpDir)
-        Changes(
-            lookupSymbols = setOf(
-                LookupSymbol(name = "changedProperty", scope = "com.example.ChangedSuperClass"),
-                LookupSymbol(name = "changedProperty", scope = "com.example.SubClassOfChangedSuperClass"),
-                LookupSymbol(name = "changedProperty", scope = "com.example.SubSubClassOfChangedSuperClass"),
-                LookupSymbol(name = "changedFunction", scope = "com.example.ChangedSuperClass"),
-                LookupSymbol(name = "changedFunction", scope = "com.example.SubClassOfChangedSuperClass"),
-                LookupSymbol(name = "changedFunction", scope = "com.example.SubSubClassOfChangedSuperClass"),
-                LookupSymbol(name = SAM_LOOKUP_NAME.asString(), scope = "com.example.ChangedSuperClass"),
-                LookupSymbol(name = SAM_LOOKUP_NAME.asString(), scope = "com.example.SubClassOfChangedSuperClass"),
-                LookupSymbol(name = SAM_LOOKUP_NAME.asString(), scope = "com.example.SubSubClassOfChangedSuperClass")
-            ),
-            fqNames = setOf(
-                "com.example.ChangedSuperClass",
-                "com.example.SubClassOfChangedSuperClass",
-                "com.example.SubSubClassOfChangedSuperClass"
-            )
-        ).assertEquals(changes)
-    }
-
     @Test
     fun testTopLevelMembers() {
         val changes = computeClasspathChanges(File(testDataDir, "KotlinOnly/testTopLevelMembers/src"), tmpDir)
@@ -235,6 +212,53 @@ class KotlinOnlyClasspathChangesComputerTest : ClasspathChangesComputerTest() {
             )
         ).assertEquals(changes)
     }
+
+    /** Tests [SupertypesInheritorsImpact]. */
+    @Test
+    override fun testImpactComputation_SupertypesInheritors() {
+        val changes = computeClasspathChanges(File(testDataDir, "KotlinOnly/testImpactComputation_SupertypesInheritors/src"), tmpDir)
+        Changes(
+            lookupSymbols = setOf(
+                LookupSymbol(name = "changedProperty", scope = "com.example.ChangedSuperClass"),
+                LookupSymbol(name = "changedProperty", scope = "com.example.SubClassOfChangedSuperClass"),
+                LookupSymbol(name = "changedProperty", scope = "com.example.SubSubClassOfChangedSuperClass"),
+                LookupSymbol(name = "changedFunction", scope = "com.example.ChangedSuperClass"),
+                LookupSymbol(name = "changedFunction", scope = "com.example.SubClassOfChangedSuperClass"),
+                LookupSymbol(name = "changedFunction", scope = "com.example.SubSubClassOfChangedSuperClass"),
+                LookupSymbol(name = SAM_LOOKUP_NAME.asString(), scope = "com.example.ChangedSuperClass"),
+                LookupSymbol(name = SAM_LOOKUP_NAME.asString(), scope = "com.example.SubClassOfChangedSuperClass"),
+                LookupSymbol(name = SAM_LOOKUP_NAME.asString(), scope = "com.example.SubSubClassOfChangedSuperClass")
+            ),
+            fqNames = setOf(
+                "com.example.ChangedSuperClass",
+                "com.example.SubClassOfChangedSuperClass",
+                "com.example.SubSubClassOfChangedSuperClass"
+            )
+        ).assertEquals(changes)
+    }
+
+    /**
+     * Tests [ConstantsInCompanionObjectsImpact].
+     *
+     * Note that this test is slightly different from [testConstantsAndInlineFunctions]: In [testConstantsAndInlineFunctions], the companion
+     * object's .class file changes, whereas in this test, the companion object's .class file does not change because we want to test that
+     * the companion object is unchanged but *impacted* by the change in the .class file of the companion object's outer class.
+     */
+    @Test
+    fun testImpactComputation_ConstantsInCompanionObjects() {
+        val changes = computeClasspathChanges(File(testDataDir, "KotlinOnly/testImpactComputation_ConstantsInCompanionObjects/src"), tmpDir)
+        Changes(
+            lookupSymbols = setOf(
+                LookupSymbol(name = "constantChangedValue", scope = "com.example.SomeClass"),
+                LookupSymbol(name = SAM_LOOKUP_NAME.asString(), scope = "com.example.SomeClass"),
+                LookupSymbol(name = "constantChangedValue", scope = "com.example.SomeClass.CompanionObject"),
+            ),
+            fqNames = setOf(
+                "com.example.SomeClass",
+                "com.example.SomeClass.CompanionObject"
+            )
+        ).assertEquals(changes)
+    }
 }
 
 class JavaOnlyClasspathChangesComputerTest : ClasspathChangesComputerTest() {

compiler/incremental-compilation-impl/testData/org/jetbrains/kotlin/incremental/classpathDiff/ClasspathChangesComputerTest/KotlinOnly/testImpactComputation_ConstantsInCompanionObjects/src/current-classpath/com/example/SomeClass.kt

@@ -0,0 +1,9 @@
+package com.example
+
+class SomeClass {
+
+    companion object CompanionObject {
+        const val constantChangedValue: Int = 1000
+        const val constantUnchanged: Int = 0
+    }
+}

compiler/incremental-compilation-impl/testData/org/jetbrains/kotlin/incremental/classpathDiff/ClasspathChangesComputerTest/KotlinOnly/testImpactComputation_ConstantsInCompanionObjects/src/previous-classpath/com/example/SomeClass.kt

@@ -0,0 +1,9 @@
+package com.example
+
+class SomeClass {
+
+    companion object CompanionObject {
+        const val constantChangedValue: Int = 0
+        const val constantUnchanged: Int = 0
+    }
+}