diff --git a/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/actions/MavenPomActions.kt b/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/actions/MavenPomActions.kt index 8e50fa2d9e4..0d677b3e7da 100644 --- a/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/actions/MavenPomActions.kt +++ b/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/actions/MavenPomActions.kt @@ -29,8 +29,8 @@ import org.jetbrains.idea.maven.dom.model.MavenDomPlugin import org.jetbrains.idea.maven.dom.model.MavenDomProjectModel import org.jetbrains.idea.maven.model.MavenId import org.jetbrains.kotlin.idea.maven.PomFile -import org.jetbrains.kotlin.idea.maven.configuration.KotlinJavaMavenConfigurator import org.jetbrains.kotlin.idea.maven.configuration.KotlinMavenConfigurator +import org.jetbrains.kotlin.idea.versions.MAVEN_STDLIB_ID import org.jetbrains.kotlin.psi.psiUtil.endOffset class GenerateMavenCompileExecutionAction : PomFileActionBase(KotlinMavenExecutionProvider(PomFile.KotlinGoals.Compile, PomFile.DefaultPhases.Compile)) @@ -136,4 +136,4 @@ private fun MavenDomPlugin.isKotlinMavenPlugin() = groupId.stringValue == Kotlin && artifactId.stringValue == KotlinMavenConfigurator.MAVEN_PLUGIN_ID private fun MavenDomDependency.isKotlinStdlib() = groupId.stringValue == KotlinMavenConfigurator.GROUP_ID - && artifactId.stringValue == KotlinJavaMavenConfigurator.STD_LIB_ID + && artifactId.stringValue == MAVEN_STDLIB_ID diff --git a/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/configuration/KotlinJavaMavenConfigurator.kt b/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/configuration/KotlinJavaMavenConfigurator.kt index 3c333248e99..36e9baee550 100644 --- a/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/configuration/KotlinJavaMavenConfigurator.kt +++ b/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/configuration/KotlinJavaMavenConfigurator.kt @@ -18,12 +18,13 @@ package org.jetbrains.kotlin.idea.maven.configuration import com.intellij.openapi.module.Module import org.jetbrains.idea.maven.dom.model.MavenDomPlugin -import org.jetbrains.kotlin.idea.configuration.* +import org.jetbrains.kotlin.idea.configuration.hasKotlinJvmRuntimeInScope import org.jetbrains.kotlin.idea.maven.PomFile +import org.jetbrains.kotlin.idea.versions.MAVEN_STDLIB_ID import org.jetbrains.kotlin.resolve.TargetPlatform import org.jetbrains.kotlin.resolve.jvm.platform.JvmPlatform -class KotlinJavaMavenConfigurator : KotlinMavenConfigurator(KotlinJavaMavenConfigurator.STD_LIB_ID, KotlinJavaMavenConfigurator.TEST_LIB_ID, false, KotlinJavaMavenConfigurator.NAME, KotlinJavaMavenConfigurator.PRESENTABLE_TEXT) { +class KotlinJavaMavenConfigurator : KotlinMavenConfigurator(MAVEN_STDLIB_ID, KotlinJavaMavenConfigurator.TEST_LIB_ID, false, KotlinJavaMavenConfigurator.NAME, KotlinJavaMavenConfigurator.PRESENTABLE_TEXT) { override fun isKotlinModule(module: Module): Boolean { return hasKotlinJvmRuntimeInScope(module) @@ -43,7 +44,6 @@ class KotlinJavaMavenConfigurator : KotlinMavenConfigurator(KotlinJavaMavenConfi companion object { private val NAME = "maven" - val STD_LIB_ID = "kotlin-stdlib" val TEST_LIB_ID = "kotlin-test" private val PRESENTABLE_TEXT = "Maven" } diff --git a/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/configuration/KotlinJavascriptMavenConfigurator.kt b/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/configuration/KotlinJavascriptMavenConfigurator.kt index b2b9edcc802..5963ef4acc2 100644 --- a/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/configuration/KotlinJavascriptMavenConfigurator.kt +++ b/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/configuration/KotlinJavascriptMavenConfigurator.kt @@ -20,10 +20,11 @@ import com.intellij.openapi.module.Module import org.jetbrains.idea.maven.dom.model.MavenDomPlugin import org.jetbrains.kotlin.idea.configuration.hasKotlinJsRuntimeInScope import org.jetbrains.kotlin.idea.maven.PomFile +import org.jetbrains.kotlin.idea.versions.MAVEN_JS_STDLIB_ID import org.jetbrains.kotlin.js.resolve.JsPlatform import org.jetbrains.kotlin.resolve.TargetPlatform -class KotlinJavascriptMavenConfigurator : KotlinMavenConfigurator(KotlinJavascriptMavenConfigurator.STD_LIB_ID, null, false, KotlinJavascriptMavenConfigurator.NAME, KotlinJavascriptMavenConfigurator.PRESENTABLE_TEXT) { +class KotlinJavascriptMavenConfigurator : KotlinMavenConfigurator(MAVEN_JS_STDLIB_ID, null, false, KotlinJavascriptMavenConfigurator.NAME, KotlinJavascriptMavenConfigurator.PRESENTABLE_TEXT) { override fun isKotlinModule(module: Module): Boolean { return hasKotlinJsRuntimeInScope(module) @@ -43,7 +44,6 @@ class KotlinJavascriptMavenConfigurator : KotlinMavenConfigurator(KotlinJavascri companion object { private val NAME = "js maven" - val STD_LIB_ID = "kotlin-js-library" private val PRESENTABLE_TEXT = "JavaScript Maven - experimental" } } diff --git a/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/inspections/DifferentMavenStdlibVersionInspection.kt b/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/inspections/DifferentMavenStdlibVersionInspection.kt index 43a238bebb2..44164498ae2 100644 --- a/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/inspections/DifferentMavenStdlibVersionInspection.kt +++ b/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/inspections/DifferentMavenStdlibVersionInspection.kt @@ -32,6 +32,7 @@ import org.jetbrains.idea.maven.project.MavenProjectsManager import org.jetbrains.kotlin.idea.maven.PomFile import org.jetbrains.kotlin.idea.maven.configuration.KotlinJavaMavenConfigurator import org.jetbrains.kotlin.idea.maven.configuration.KotlinMavenConfigurator +import org.jetbrains.kotlin.idea.versions.MAVEN_STDLIB_ID class DifferentMavenStdlibVersionInspection : DomElementsInspection(MavenDomProjectModel::class.java) { override fun checkFileElement(domFileElement: DomFileElement?, holder: DomElementAnnotationHolder?) { @@ -44,7 +45,7 @@ class DifferentMavenStdlibVersionInspection : DomElementsInspection val fixes = dependency.version.stringValue?.let { version -> diff --git a/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/inspections/KotlinMavenPluginPhaseInspection.kt b/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/inspections/KotlinMavenPluginPhaseInspection.kt index 6c1c884a500..d167e6cc7b2 100644 --- a/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/inspections/KotlinMavenPluginPhaseInspection.kt +++ b/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/inspections/KotlinMavenPluginPhaseInspection.kt @@ -21,7 +21,6 @@ import com.intellij.codeInspection.ProblemDescriptor import com.intellij.ide.highlighter.JavaFileType import com.intellij.lang.annotation.HighlightSeverity import com.intellij.openapi.module.Module -import com.intellij.openapi.module.ModuleManager import com.intellij.openapi.project.Project import com.intellij.psi.search.FileTypeIndex import com.intellij.psi.search.GlobalSearchScope @@ -38,9 +37,9 @@ import org.jetbrains.idea.maven.model.MavenPlugin import org.jetbrains.idea.maven.project.MavenProjectsManager import org.jetbrains.idea.maven.utils.MavenArtifactScope import org.jetbrains.kotlin.idea.maven.PomFile -import org.jetbrains.kotlin.idea.maven.configuration.KotlinJavaMavenConfigurator -import org.jetbrains.kotlin.idea.maven.configuration.KotlinJavascriptMavenConfigurator import org.jetbrains.kotlin.idea.maven.configuration.KotlinMavenConfigurator +import org.jetbrains.kotlin.idea.versions.MAVEN_JS_STDLIB_ID +import org.jetbrains.kotlin.idea.versions.MAVEN_STDLIB_ID import java.util.* class KotlinMavenPluginPhaseInspection : DomElementsInspection(MavenDomProjectModel::class.java) { @@ -114,25 +113,25 @@ class KotlinMavenPluginPhaseInspection : DomElementsInspection holder.createProblem(dep.artifactId.createStableCopy(), @@ -142,7 +141,7 @@ class KotlinMavenPluginPhaseInspection : DomElementsInspection holder.createProblem(dep.artifactId.createStableCopy(), diff --git a/idea/idea.iml b/idea/idea.iml index ddb7d7af13b..44aec20b3e4 100644 --- a/idea/idea.iml +++ b/idea/idea.iml @@ -53,7 +53,6 @@ - \ No newline at end of file diff --git a/idea/src/org/jetbrains/kotlin/idea/facet/facetUtils.kt b/idea/src/org/jetbrains/kotlin/idea/facet/facetUtils.kt index 9f2d03e4152..34a3d678604 100644 --- a/idea/src/org/jetbrains/kotlin/idea/facet/facetUtils.kt +++ b/idea/src/org/jetbrains/kotlin/idea/facet/facetUtils.kt @@ -34,9 +34,7 @@ import org.jetbrains.kotlin.idea.compiler.configuration.KotlinCompilerSettings import org.jetbrains.kotlin.idea.framework.JSLibraryStdPresentationProvider import org.jetbrains.kotlin.idea.framework.JavaRuntimePresentationProvider import org.jetbrains.kotlin.idea.framework.getLibraryProperties -import org.jetbrains.kotlin.idea.maven.configuration.KotlinJavaMavenConfigurator -import org.jetbrains.kotlin.idea.maven.configuration.KotlinJavascriptMavenConfigurator -import org.jetbrains.kotlin.idea.versions.bundledRuntimeVersion +import org.jetbrains.kotlin.idea.versions.* private fun getRuntimeLibraryVersions( module: Module, @@ -134,6 +132,6 @@ internal fun KotlinFacetSettings.initializeIfNeeded(module: Module, rootModel: M val TargetPlatformKind<*>.mavenLibraryId: String get() = when (this) { - is TargetPlatformKind.Jvm -> KotlinJavaMavenConfigurator.STD_LIB_ID - is TargetPlatformKind.JavaScript -> KotlinJavascriptMavenConfigurator.STD_LIB_ID + is TargetPlatformKind.Jvm -> MAVEN_STDLIB_ID + is TargetPlatformKind.JavaScript -> MAVEN_JS_STDLIB_ID } diff --git a/idea/src/org/jetbrains/kotlin/idea/versions/KotlinRuntimeLibraryUtil.kt b/idea/src/org/jetbrains/kotlin/idea/versions/KotlinRuntimeLibraryUtil.kt index 1aac16e927c..d3a0e46751c 100644 --- a/idea/src/org/jetbrains/kotlin/idea/versions/KotlinRuntimeLibraryUtil.kt +++ b/idea/src/org/jetbrains/kotlin/idea/versions/KotlinRuntimeLibraryUtil.kt @@ -286,3 +286,6 @@ fun getKotlinJsRuntimeMarkerClass(project: Project, scope: GlobalSearchScope): V } } } + +val MAVEN_STDLIB_ID = "kotlin-stdlib" +val MAVEN_JS_STDLIB_ID = "kotlin-js-library"