azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[JS] Fix stack trace capturing from secondary constructors KT-37563

Browse Source
This commit is contained in:
Svyatoslav Kuzmich
2020-06-19 16:42:03 +03:00
parent 6792779281
commit bbfc1a10ad
4 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
js/js.translator/testData/box/expression/misc/stackTraceCapturing.kt
Vendored
+1 -2
View File
@@ -1,6 +1,5 @@
// EXPECTED_REACHABLE_NODES: 1281
// EXPECTED_REACHABLE_NODES: 1462
// KJS_WITH_FULL_RUNTIME
// IGNORE_BACKEND: JS
// Reproduction of KT-37563
// Test stack trace capturing in various kinds of constructors
js/js.translator/testData/box/inline/kt26787.kt
Vendored
+1 -1
View File
@@ -1,5 +1,5 @@
// KJS_WITH_FULL_RUNTIME
// EXPECTED_REACHABLE_NODES: 1618
// EXPECTED_REACHABLE_NODES: 1600
// Simplified example from https://youtrack.jetbrains.com/issue/KT-26787
js/js.translator/testData/box/regression/stdlibTestSnippets/abstractCollectionToArray.kt
Vendored
+1 -1
View File
@@ -1,4 +1,4 @@
// EXPECTED_REACHABLE_NODES: 1750
// EXPECTED_REACHABLE_NODES: 1700
// KJS_WITH_FULL_RUNTIME
fun abstractCollectionToArray() {
libraries/stdlib/js-v1/src/kotlin/builtins.kt
+3 -1
View File
@@ -98,7 +98,9 @@ internal fun subSequence(c: CharSequence, startIndex: Int, endIndex: Int): CharS
@JsName("captureStack")
internal fun captureStack(baseClass: JsClass<in Throwable>, instance: Throwable) {
if (js("Error").captureStackTrace) {
js("Error").captureStackTrace(instance, instance::class.js);
// Using uncropped stack traces due to KT-37563.
// Precise stack traces are implemented in JS IR compiler and stdlib
js("Error").captureStackTrace(instance);
} else {
instance.asDynamic().stack = js("new Error()").stack;
}