Cleanup: fix some "leaking this" warnings

This commit is contained in:
Mikhail Glukhikh
2017-02-22 17:44:45 +03:00
parent 045a23ae10
commit bbab0f11ca
5 changed files with 20 additions and 6 deletions
@@ -54,6 +54,10 @@ abstract class KtCodeFragment(
} }
} }
override final fun init(elementType: IElementType, contentElementType: IElementType?) {
super.init(elementType, contentElementType)
}
private var resolveScope: GlobalSearchScope? = null private var resolveScope: GlobalSearchScope? = null
private var thisType: PsiType? = null private var thisType: PsiType? = null
private var superType: PsiType? = null private var superType: PsiType? = null
@@ -27,12 +27,13 @@ fun PropertyDescriptor.asImportedFromObject(original: PropertyImportedFromObject
abstract class ImportedFromObjectCallableDescriptor<out TCallable : CallableMemberDescriptor>( abstract class ImportedFromObjectCallableDescriptor<out TCallable : CallableMemberDescriptor>(
val callableFromObject: TCallable, val callableFromObject: TCallable,
originalOrNull: TCallable? private val originalOrNull: TCallable?
) : CallableDescriptor { ) : CallableDescriptor {
val containingObject = callableFromObject.containingDeclaration as ClassDescriptor val containingObject = callableFromObject.containingDeclaration as ClassDescriptor
protected val _original = originalOrNull ?: this protected val _original
get() = originalOrNull ?: this
} }
// members imported from object should be wrapped to not require dispatch receiver // members imported from object should be wrapped to not require dispatch receiver
@@ -17,16 +17,13 @@
package org.jetbrains.kotlin.idea.search.declarationsSearch package org.jetbrains.kotlin.idea.search.declarationsSearch
import com.intellij.psi.search.SearchScope import com.intellij.psi.search.SearchScope
import com.intellij.util.Query
import com.intellij.util.QueryFactory
import com.intellij.util.Processor
import com.intellij.openapi.application.QueryExecutorBase import com.intellij.openapi.application.QueryExecutorBase
import com.intellij.psi.PsiElement import com.intellij.psi.PsiElement
import com.intellij.openapi.project.Project import com.intellij.openapi.project.Project
import com.intellij.util.EmptyQuery
import java.util.Stack import java.util.Stack
import java.util.HashSet import java.util.HashSet
import com.intellij.openapi.progress.ProgressIndicatorProvider import com.intellij.openapi.progress.ProgressIndicatorProvider
import com.intellij.util.*
import org.jetbrains.kotlin.psi.psiUtil.contains import org.jetbrains.kotlin.psi.psiUtil.contains
interface DeclarationSearchRequest<in T> { interface DeclarationSearchRequest<in T> {
@@ -50,6 +47,10 @@ abstract class DeclarationsSearch<T: PsiElement, R: DeclarationSearchRequest<T>>
) )
} }
override final fun registerExecutor(executor: QueryExecutor<T, R>) {
super.registerExecutor(executor)
}
protected abstract fun doSearch(request: R, consumer: Processor<T>) protected abstract fun doSearch(request: R, consumer: Processor<T>)
protected open fun isApplicable(request: R): Boolean = true protected open fun isApplicable(request: R): Boolean = true
@@ -25,6 +25,10 @@ abstract class AbstractIntroduceAction : BasePlatformRefactoringAction() {
setInjectedContext(true) setInjectedContext(true)
} }
override final fun setInjectedContext(worksInInjected: Boolean) {
super.setInjectedContext(worksInInjected)
}
override fun isAvailableInEditorOnly(): Boolean = true override fun isAvailableInEditorOnly(): Boolean = true
override fun isEnabledOnElements(elements: Array<out PsiElement>): Boolean = override fun isEnabledOnElements(elements: Array<out PsiElement>): Boolean =
@@ -42,6 +42,10 @@ open class DialogWithEditor(
setTitle(title) setTitle(title)
} }
override final fun init() {
super.init()
}
private fun createEditor(): Editor { private fun createEditor(): Editor {
val editorFactory = EditorFactory.getInstance()!! val editorFactory = EditorFactory.getInstance()!!
val virtualFile = LightVirtualFile("dummy.kt", KotlinFileType.INSTANCE, initialText) val virtualFile = LightVirtualFile("dummy.kt", KotlinFileType.INSTANCE, initialText)