azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

KT-15112, KT-15631

Browse Source 
Revert changes for "tolerant to uninitialized values" in OptimizationBasicInterpreter:
this approach doesn't converge for some specific cases where local variable is reused
(e.g., in several inlined functions - see https://youtrack.jetbrains.com/issue/KT-15112).

Instead, treat fake always-false conditional jump in the beginning of the post-condition loop as a "reference point" for stack on loop break / continue.
This requires an extra abstraction layer in FixStackAnalyzer, since we can't perform fine-grain manipulations on Frames
(such as "combine frame C from local variables of frame A and stack of frame B").

NB additional NOPs will be generated for post-condition loops.
Should make a separate bytecode postprocessing pass to get rid of unnecessary NOPs
(several YT issues for perceived quality of the generated bytecode are about such NOPs).
This commit is contained in:
Dmitry Petrov
2017-01-11 13:46:33 +03:00
parent c09a71b178
commit ba933fa887
15 changed files with 289 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/testData/debugger/tinyApp/outs/stepOverWhileWithInline.out
Vendored
+2 -1
View File
@@ -10,13 +10,14 @@ stepOverWhileWithInline.kt:13
stepOverWhileWithInline.kt:14
stepOverWhileWithInline.kt:15
stepOverWhileWithInline.kt:13
stepOverWhileWithInline.kt:18
stepOverWhileWithInline.kt:19
stepOverWhileWithInline.kt:20
stepOverWhileWithInline.kt:21
stepOverWhileWithInline.kt:23
stepOverWhileWithInline.kt:24
stepOverWhileWithInline.kt:25
stepOverWhileWithInline.kt:26
stepOverWhileWithInline.kt:27
Disconnected from the target VM, address: '!HOST_NAME!:PORT_NAME!', transport: 'socket'
Process finished with exit code 0