Split ReplaceSingleLineLetInspection to SimpleRedundantLet & ComplexRedundantLet

Relates to #KT-32010

idea/testData/inspectionsLocal/complexRedundantLet/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.ComplexRedundantLetInspection

idea/testData/inspectionsLocal/complexRedundantLet/assignment.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun withAssign(arg: String?): String {
+    var result: String = ""
+    arg?.let<caret> { result = it }
+    return result
+}

idea/testData/inspectionsLocal/complexRedundantLet/binarySafeCall.kt

@@ -0,0 +1,5 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+val x = 1
+val y = x.<caret>let { it + it?.hashCode() }

idea/testData/inspectionsLocal/complexRedundantLet/callChain.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }.filter { it > 2 }.let<caret> { println(it) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/callChain.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    println(list.filter { it > 1 }.filter { it > 2 })
+}

idea/testData/inspectionsLocal/complexRedundantLet/callChain2.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }.filter { it > 2 }
+        .let<caret> { println(it) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/callChain2.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    println(list.filter { it > 1 }.filter { it > 2 })
+}

idea/testData/inspectionsLocal/complexRedundantLet/callChain3.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }.filter { it > 2 }.let<caret> {
+        println(it)
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/callChain3.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    println(list.filter { it > 1 }.filter { it > 2 })
+}

idea/testData/inspectionsLocal/complexRedundantLet/callChainWithLineBreak.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+// HIGHLIGHT: INFORMATION
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }
+        .filter { it > 2 }
+        .let<caret> { println(it) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/callChainWithLineBreak.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+// HIGHLIGHT: INFORMATION
+
+fun test(list: List<Int>) {
+    println(list.filter { it > 1 }
+    .filter { it > 2 })
+}

idea/testData/inspectionsLocal/complexRedundantLet/comparisons.kt

@@ -0,0 +1,4 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun isAlphaOrBeta(str: String) = str.let<caret> { it == "Alpha" || it == "Beta" }

idea/testData/inspectionsLocal/complexRedundantLet/destructuringDeclaration.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun test() {
+    (1 to 2).let<caret> { (i, j) -> foo() }
+}
+
+fun foo() = 0

idea/testData/inspectionsLocal/complexRedundantLet/destructuringDeclaration.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun test() {
+    foo()
+}
+
+fun foo() = 0

idea/testData/inspectionsLocal/complexRedundantLet/destructuringDeclaration2.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun test() {
+    (1 to 2).let<caret> { (i, j) -> foo(1, 2) }
+}
+
+fun foo(i: Int, j: Int) = i + j

idea/testData/inspectionsLocal/complexRedundantLet/destructuringDeclaration2.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun test() {
+    foo(1, 2)
+}
+
+fun foo(i: Int, j: Int) = i + j

idea/testData/inspectionsLocal/complexRedundantLet/destructuringDeclaration3.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun test() {
+    (1 to 2).let<caret> { (i, j) -> foo(i, 3) }
+}
+
+fun foo(i: Int, j: Int) = i + j

idea/testData/inspectionsLocal/complexRedundantLet/destructuringDeclaration4.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun test(k: Int) {
+    (1 to 2).let<caret> { (i, j) -> i + k }
+}

idea/testData/inspectionsLocal/complexRedundantLet/destructuringDeclaration5.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun test() {
+    (1 to 2).let<caret> { (i, j) -> i.toLong() }
+}

idea/testData/inspectionsLocal/complexRedundantLet/dotWithComparison.kt

@@ -0,0 +1,6 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun main(args: Array<String>) {
+    args[0].let<caret> { it.isBlank() && it.toByteOrNull() != null }
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall1.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    val s = ""
+    s.let<caret> { foo("", 1) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall1.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    val s = ""
+    <caret>foo("", 1)
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall2.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    val s = ""
+    s.let<caret> { foo(it, 1) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall2.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    val s = ""
+    <caret>foo(s, 1)
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall3.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    val s = ""
+    s.let<caret> { foo("", it.length) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall3.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    val s = ""
+    foo("", s.length)
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall4.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    val s = ""
+    s.let<caret> { x -> foo("", x.length) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall4.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    val s = ""
+    foo("", s.length)
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall5.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    val s = ""
+    s.length.let<caret> { foo("", it) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall5.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    val s = ""
+    foo("", s.length)
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall6.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    fun bar() = ""
+    bar().let<caret> { foo(it, 1) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall6.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    fun bar() = ""
+    foo(bar(), 1)
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCall7.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    val s = ""
+    s.let<caret> { foo(it, it.length) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCallInExtension.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun String.baz(): Int {
+    return let<caret> { foo(it, 1) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCallInExtension.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun String.baz(): Int {
+    return foo(this, 1)
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionCallOnSafeCall.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo(s: String, i: Int) = s.length + i
+
+fun test() {
+    val nullable: String? = null
+    nullable?.let<caret> { foo(it, 1) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionInVariableCall.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+class Foo(val bar: () -> Int)
+
+fun bar(foo: Foo?) {
+    foo?.<caret>let { it.bar() }
+}

idea/testData/inspectionsLocal/complexRedundantLet/functionInVariableInvokeCall.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+class Foo(val bar: () -> Int)
+
+fun bar(foo: Foo?) {
+    foo?.<caret>let { it.bar.invoke() }
+}

idea/testData/inspectionsLocal/complexRedundantLet/in.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+
+fun foo(list: List<Int>) {
+    list.filter { it.let<caret> { it in 1000..3000 } }
+}

idea/testData/inspectionsLocal/complexRedundantLet/in.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+
+fun foo(list: List<Int>) {
+    list.filter { it in 1000..3000 }
+}

idea/testData/inspectionsLocal/complexRedundantLet/inWithMultipleParam.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo(list: List<Int>) {
+    list.filter { it.let<caret> { value -> value in value..3000 } }
+}

idea/testData/inspectionsLocal/complexRedundantLet/inWithRange.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+
+fun foo(list: List<Int>) {
+    list.filter { it.let<caret> { it in IntRange(1, 10) } }
+}

idea/testData/inspectionsLocal/complexRedundantLet/inWithRange.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+
+fun foo(list: List<Int>) {
+    list.filter { it in IntRange(1, 10) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/inWithRangeMultipleParam.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo(list: List<Int>) {
+    list.filter { it.let<caret> { it in IntRange(it - 1, 10) } }
+}

idea/testData/inspectionsLocal/complexRedundantLet/invokeCall.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+class A {
+    operator fun invoke() {}
+}
+
+fun foo(a: A) {
+    a.<caret>let { it() }
+}

idea/testData/inspectionsLocal/complexRedundantLet/invokeCall.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+class A {
+    operator fun invoke() {}
+}
+
+fun foo(a: A) {
+    a()
+}

idea/testData/inspectionsLocal/complexRedundantLet/invokeCall2.kt

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+class A {
+    operator fun invoke() {}
+}
+
+fun foo(a: A) {
+    a.<caret>let { b -> b() }
+}

idea/testData/inspectionsLocal/complexRedundantLet/invokeCall2.kt.after

@@ -0,0 +1,8 @@
+// WITH_RUNTIME
+class A {
+    operator fun invoke() {}
+}
+
+fun foo(a: A) {
+    a()
+}

idea/testData/inspectionsLocal/complexRedundantLet/invokeCall3.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// WITH_RUNTIME
+class A {
+    operator fun invoke() {}
+}
+
+fun foo(a: A) {
+    a.<caret>let { b -> b.invoke() }
+}

idea/testData/inspectionsLocal/complexRedundantLet/invokeCall4.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// WITH_RUNTIME
+class A {
+    operator fun invoke(a: A, i: Int) {}
+}
+
+fun foo(a: A) {
+    a.<caret>let { it(it, 1) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/invokeCall5.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// WITH_RUNTIME
+class A {
+    operator fun invoke() {}
+}
+
+fun foo(a: A) {
+    (1 to a).<caret>let { (i, b) -> b() }
+}

idea/testData/inspectionsLocal/complexRedundantLet/lambdaWithBinaryExpression.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun baz(foo: String) {
+    foo.let<caret> { it.indexOfLast { c -> c == it[0] } + 1 }
+}

idea/testData/inspectionsLocal/complexRedundantLet/lambdaWithBinaryExpression2.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun baz(foo: String) {
+    foo.let<caret> { it.length + "".indexOfLast { c -> c == it[0] } }
+}

idea/testData/inspectionsLocal/complexRedundantLet/let.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String? = null
+    foo?.let<caret> {
+        it.length
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letMultipleLines.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.length<caret>
+        it.length
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letNoSafeCall.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String = ""
+    foo.let<caret> {
+        it.length
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letNotUseParameterReceiver.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        text ->
+        "".to("")<caret>
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letNotUseReceiver.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        "".to("")<caret>
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letUseIt.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.to(it)<caret>
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letUseItAsParamWithBinaryExpression.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo() {
+    "".let<caret> { it.length + "".indexOf(it) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letUseItWithBinaryExpression.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo() {
+    "".let<caret> { it.length + it.length }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letUseItWithBinaryExpression2.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo() {
+    "".let<caret> { it.substring(0, 1) + it }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letUseItWithMultipleMethodCall1.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.to(it).to("").to("")<caret>
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letUseItWithMultipleMethodCall2.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.to("").to(it).to("")<caret>
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letUseItWithMultipleMethodCall3.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        it.to("").to("").to(it)<caret>
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letUseParameter.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun foo() {
+    val foo: String? = null
+    foo?.let {
+        text ->
+        text.to(text)<caret>
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithBinaryExpression.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+
+fun foo() {
+    "".let<caret> { it.length + 1 }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithBinaryExpression.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+
+fun foo() {
+    "".length + 1
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithMethodCall.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String? = null
+    foo?.let<caret> {
+        it.to("")
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithMultipleMethodCall.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String? = null
+    foo?.let<caret> {
+        it.hashCode().hashCode()
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithParameter.kt

@@ -0,0 +1,11 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String? = null
+    foo?.let<caret> {
+        text ->
+        text.length
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithSimpleBinaryExpression.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+
+fun foo() {
+    "".let<caret> { it + 1 }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithSimpleBinaryExpression.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+
+fun foo() {
+    "" + 1
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithThisBinaryExpression.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+
+fun Int.foo() {
+    let<caret> { it.dec() + 1 }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithThisBinaryExpression.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+
+fun Int.foo() {
+    dec() + 1
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithThisShortBinaryExpression.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+
+fun Int.foo() {
+    let<caret> { it + 1 }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithThisShortBinaryExpression.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+
+
+fun Int.foo() {
+    this + 1
+}

idea/testData/inspectionsLocal/complexRedundantLet/longCallChain.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// HIGHLIGHT: INFORMATION
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }.filter { it > 2 }.filter { it > 3 }.let<caret> { println(it) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/longCallChain.kt.after

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// HIGHLIGHT: INFORMATION
+
+fun test(list: List<Int>) {
+    println(list.filter { it > 1 }.filter { it > 2 }.filter { it > 3 })
+}

idea/testData/inspectionsLocal/complexRedundantLet/multipleReceiver.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun baz(foo: String) {
+    foo.let<caret> { it.substringAfterLast(it.capitalize()) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/multipleReceiver2.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun baz(foo: String) {
+    foo.let<caret> { it.substringAfterLast("".equals(it).toString()) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/multipleReceiver3.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun baz(foo: String) {
+    foo.let<caret> { it.substring(0, it.length) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/multipleUsages.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    if (s.substring(1).let<caret> { it.startsWith("a") || it[1].isLowerCase() }) {
+
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/noReceiver.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun String.test(): Int {
+    return let<caret> {
+        it.length
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/plusNullable.kt

@@ -0,0 +1,4 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun plusNullable(arg: String?) = arg?.let<caret> { it + "#" } ?: ""

idea/testData/inspectionsLocal/complexRedundantLet/receiverWithLambda.kt

@@ -0,0 +1,6 @@
+// WITH_RUNTIME
+// PROBLEM: none
+
+fun baz(foo: String) {
+    foo.let<caret> { it.indexOfLast { c -> c == it[0] } }
+}

idea/testData/inspectionsLocal/complexRedundantLet/receiverWithLambda2.kt

@@ -0,0 +1,9 @@
+// WITH_RUNTIME
+// PROBLEM: none
+// This should be reported. However, in order to avoid too complicate logic, the intention ignore this case.
+
+import java.util.*
+
+fun baz2(foo: List<String>) {
+    foo.let<caret> { it.binarySearch("", Comparator<kotlin.String> { o1, o2 -> 0 }) }
+}

idea/testData/inspectionsLocal/complexRedundantLet/sameLets.kt

@@ -0,0 +1,12 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String? = null
+    foo?.toString()?.let<caret> {
+        it.to("")
+    }?.let {
+        it.to("")
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/simple.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun test(s: String?): Int? {
+    return s?.let<caret> {
+        it.length
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/smartCastInBody.kt

@@ -0,0 +1,15 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+interface A
+
+interface B : A {
+    val bar: Any?
+}
+
+class Foo {
+    private val a: A = object : A {}
+
+    val isB: Boolean
+        get() = a.let<caret> { it is B && it.bar != null }
+}

idea/testData/inspectionsLocal/complexRedundantLet/this.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun Int.foo(): Int {
+    return <caret>let { it.hashCode().hashCode() }
+}

idea/testData/inspectionsLocal/complexRedundantLet/thisShort.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun Int.foo(): Int {
+    return <caret>let { it.hashCode() }
+}

idea/testData/inspectionsLocal/complexRedundantLet/typeChecks.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+interface Base
+
+class A : Base
+class B : Base
+
+fun isAB(arg: Base) = arg.let<caret> { it is A || it is B }