Split ReplaceSingleLineLetInspection to SimpleRedundantLet & ComplexRedundantLet

Relates to #KT-32010

idea/testData/inspectionsLocal/complexRedundantLet/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.ComplexRedundantLetInspection

idea/testData/inspectionsLocal/complexRedundantLet/functionInVariableInvokeCall.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+class Foo(val bar: () -> Int)
+
+fun bar(foo: Foo?) {
+    foo?.<caret>let { it.bar.invoke() }
+}

idea/testData/inspectionsLocal/complexRedundantLet/invokeCall3.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+// WITH_RUNTIME
+class A {
+    operator fun invoke() {}
+}
+
+fun foo(a: A) {
+    a.<caret>let { b -> b.invoke() }
+}

idea/testData/inspectionsLocal/complexRedundantLet/let.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String? = null
+    foo?.let<caret> {
+        it.length
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letNoSafeCall.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String = ""
+    foo.let<caret> {
+        it.length
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithMethodCall.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String? = null
+    foo?.let<caret> {
+        it.to("")
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithMultipleMethodCall.kt

@@ -0,0 +1,10 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String? = null
+    foo?.let<caret> {
+        it.hashCode().hashCode()
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/letWithParameter.kt

@@ -0,0 +1,11 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String? = null
+    foo?.let<caret> {
+        text ->
+        text.length
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/noReceiver.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun String.test(): Int {
+    return let<caret> {
+        it.length
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/sameLets.kt

@@ -0,0 +1,12 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun foo() {
+    val foo: String? = null
+    foo?.toString()?.let<caret> {
+        it.to("")
+    }?.let {
+        it.to("")
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/simple.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun test(s: String?): Int? {
+    return s?.let<caret> {
+        it.length
+    }
+}

idea/testData/inspectionsLocal/complexRedundantLet/this.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun Int.foo(): Int {
+    return <caret>let { it.hashCode().hashCode() }
+}

idea/testData/inspectionsLocal/complexRedundantLet/thisShort.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+
+fun Int.foo(): Int {
+    return <caret>let { it.hashCode() }
+}

idea/testData/inspectionsLocal/replaceSingleLineLet/.inspection

@@ -1 +0,0 @@
-org.jetbrains.kotlin.idea.inspections.ReplaceSingleLineLetInspection

idea/testData/inspectionsLocal/simpleRedundantLet/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.SimpleRedundantLetInspection

idea/testData/inspectionsLocal/simpleRedundantLet/assignment.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun withAssign(arg: String?): String {
+    var result: String = ""
+    arg?.let<caret> { result = it }
+    return result
+}

idea/testData/inspectionsLocal/simpleRedundantLet/binarySafeCall.kt

@@ -0,0 +1,5 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+val x = 1
+val y = x.<caret>let { it + it?.hashCode() }

idea/testData/inspectionsLocal/simpleRedundantLet/callChain.kt

@@ -0,0 +1,6 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }.filter { it > 2 }.let<caret> { println(it) }
+}

idea/testData/inspectionsLocal/simpleRedundantLet/callChain2.kt

@@ -0,0 +1,7 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }.filter { it > 2 }
+        .let<caret> { println(it) }
+}

idea/testData/inspectionsLocal/simpleRedundantLet/callChain3.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+// WITH_RUNTIME
+
+fun test(list: List<Int>) {
+    list.filter { it > 1 }.filter { it > 2 }.let<caret> {
+        println(it)
+    }
+}