add constans Visibilities.DEFAULT_VISIBILITY and JetTokens.DEFAULT_VISIBILITY_KEYWORD

This commit is contained in:
Michael Nedzelsky
2015-09-03 11:49:22 +03:00
parent e7c9699bfa
commit b8aa5d43bd
13 changed files with 16 additions and 12 deletions
@@ -163,6 +163,8 @@ public interface JetTokens {
JetModifierKeywordToken COMPANION_KEYWORD = JetModifierKeywordToken.softKeywordModifier("companion"); JetModifierKeywordToken COMPANION_KEYWORD = JetModifierKeywordToken.softKeywordModifier("companion");
JetModifierKeywordToken SEALED_KEYWORD = JetModifierKeywordToken.softKeywordModifier("sealed"); JetModifierKeywordToken SEALED_KEYWORD = JetModifierKeywordToken.softKeywordModifier("sealed");
JetModifierKeywordToken DEFAULT_VISIBILITY_KEYWORD = INTERNAL_KEYWORD;
JetKeywordToken FINALLY_KEYWORD = JetKeywordToken.softKeyword("finally"); JetKeywordToken FINALLY_KEYWORD = JetKeywordToken.softKeyword("finally");
JetModifierKeywordToken FINAL_KEYWORD = JetModifierKeywordToken.softKeywordModifier("final"); JetModifierKeywordToken FINAL_KEYWORD = JetModifierKeywordToken.softKeywordModifier("final");
@@ -48,7 +48,7 @@ abstract class JetDeclarationImpl extends JetExpressionImpl implements JetDeclar
@Override @Override
public void addModifier(@NotNull JetModifierKeywordToken modifier) { public void addModifier(@NotNull JetModifierKeywordToken modifier) {
AddRemoveModifierPackage.addModifier(this, modifier, JetTokens.INTERNAL_KEYWORD); AddRemoveModifierPackage.addModifier(this, modifier, JetTokens.DEFAULT_VISIBILITY_KEYWORD);
} }
@Override @Override
@@ -52,7 +52,7 @@ public class JetModifierListOwnerStub<T extends StubElement<?>> extends JetEleme
@Override @Override
public void addModifier(@NotNull JetModifierKeywordToken modifier) { public void addModifier(@NotNull JetModifierKeywordToken modifier) {
AddRemoveModifierPackage.addModifier(this, modifier, JetTokens.INTERNAL_KEYWORD); AddRemoveModifierPackage.addModifier(this, modifier, JetTokens.DEFAULT_VISIBILITY_KEYWORD);
} }
@Override @Override
@@ -298,13 +298,13 @@ public class DescriptorResolver {
JetModifierList modifierList = modifierListOwner.getModifierList(); JetModifierList modifierList = modifierListOwner.getModifierList();
defaultVisibility = modifierList != null && modifierList.hasModifier(OVERRIDE_KEYWORD) defaultVisibility = modifierList != null && modifierList.hasModifier(OVERRIDE_KEYWORD)
? Visibilities.INHERITED ? Visibilities.INHERITED
: Visibilities.INTERNAL; : Visibilities.DEFAULT_VISIBILITY;
} }
else if (containingDescriptor instanceof FunctionDescriptor || containingDescriptor instanceof PropertyDescriptor) { else if (containingDescriptor instanceof FunctionDescriptor || containingDescriptor instanceof PropertyDescriptor) {
defaultVisibility = Visibilities.LOCAL; defaultVisibility = Visibilities.LOCAL;
} }
else { else {
defaultVisibility = Visibilities.INTERNAL; defaultVisibility = Visibilities.DEFAULT_VISIBILITY;
} }
return defaultVisibility; return defaultVisibility;
} }
@@ -139,7 +139,7 @@ public class LazyClassDescriptor extends ClassDescriptorBase implements ClassDes
defaultVisibility = Visibilities.PUBLIC; defaultVisibility = Visibilities.PUBLIC;
} }
else { else {
defaultVisibility = Visibilities.INTERNAL; defaultVisibility = Visibilities.DEFAULT_VISIBILITY;
} }
this.visibility = isLocal ? Visibilities.LOCAL : resolveVisibilityFromModifiers(modifierList, defaultVisibility); this.visibility = isLocal ? Visibilities.LOCAL : resolveVisibilityFromModifiers(modifierList, defaultVisibility);
@@ -258,6 +258,8 @@ public class Visibilities {
return null; return null;
} }
public static final Visibility DEFAULT_VISIBILITY = INTERNAL;
public static boolean isPrivate(@NotNull Visibility visibility) { public static boolean isPrivate(@NotNull Visibility visibility) {
return visibility == PRIVATE || visibility == PRIVATE_TO_THIS; return visibility == PRIVATE || visibility == PRIVATE_TO_THIS;
} }
@@ -413,7 +413,7 @@ internal class DescriptorRendererImpl(
if (normalizedVisibilities) { if (normalizedVisibilities) {
visibility = visibility.normalize() visibility = visibility.normalize()
} }
if (!showInternalKeyword && visibility == Visibilities.INTERNAL) return if (!showInternalKeyword && visibility == Visibilities.DEFAULT_VISIBILITY) return
builder.append(renderKeyword(visibility.displayName)).append(" ") builder.append(renderKeyword(visibility.displayName)).append(" ")
} }
@@ -386,7 +386,7 @@ public class DescriptorUtils {
return Visibilities.PRIVATE; return Visibilities.PRIVATE;
} }
if (isAnonymousObject(classDescriptor)) { if (isAnonymousObject(classDescriptor)) {
return Visibilities.INTERNAL; return Visibilities.DEFAULT_VISIBILITY;
} }
assert classKind == ClassKind.CLASS || classKind == ClassKind.INTERFACE || classKind == ClassKind.ANNOTATION_CLASS; assert classKind == ClassKind.CLASS || classKind == ClassKind.INTERFACE || classKind == ClassKind.ANNOTATION_CLASS;
return Visibilities.PUBLIC; return Visibilities.PUBLIC;
@@ -467,7 +467,7 @@ public class OverridingUtil {
@Nullable @Nullable
private static Visibility findMaxVisibility(@NotNull Collection<? extends CallableMemberDescriptor> descriptors) { private static Visibility findMaxVisibility(@NotNull Collection<? extends CallableMemberDescriptor> descriptors) {
if (descriptors.isEmpty()) { if (descriptors.isEmpty()) {
return Visibilities.INTERNAL; return Visibilities.DEFAULT_VISIBILITY;
} }
Visibility maxVisibility = null; Visibility maxVisibility = null;
for (CallableMemberDescriptor descriptor : descriptors) { for (CallableMemberDescriptor descriptor : descriptors) {
@@ -72,7 +72,7 @@ private class MissingDependencyErrorClassDescriptor(
init { init {
val emptyConstructor = ConstructorDescriptorImpl.create(this, Annotations.EMPTY, true, SourceElement.NO_SOURCE) val emptyConstructor = ConstructorDescriptorImpl.create(this, Annotations.EMPTY, true, SourceElement.NO_SOURCE)
emptyConstructor.initialize(listOf(), listOf(), Visibilities.INTERNAL) emptyConstructor.initialize(listOf(), listOf(), Visibilities.DEFAULT_VISIBILITY)
emptyConstructor.setReturnType(createErrorType("<ERROR RETURN TYPE>")) emptyConstructor.setReturnType(createErrorType("<ERROR RETURN TYPE>"))
initialize(JetScope.Empty, setOf(emptyConstructor), emptyConstructor) initialize(JetScope.Empty, setOf(emptyConstructor), emptyConstructor)
} }
@@ -188,7 +188,7 @@ public open class JetChangeInfo(
public fun getNewSignature(inheritedCallable: JetCallableDefinitionUsage<PsiElement>): String { public fun getNewSignature(inheritedCallable: JetCallableDefinitionUsage<PsiElement>): String {
val buffer = StringBuilder() val buffer = StringBuilder()
val defaultVisibility = if (kind.isConstructor) Visibilities.PUBLIC else Visibilities.INTERNAL val defaultVisibility = if (kind.isConstructor) Visibilities.PUBLIC else Visibilities.DEFAULT_VISIBILITY
if (kind == Kind.PRIMARY_CONSTRUCTOR) { if (kind == Kind.PRIMARY_CONSTRUCTOR) {
buffer.append(name) buffer.append(name)
@@ -97,7 +97,7 @@ public class JetChangeSignatureUsageProcessor implements ChangeSignatureUsagePro
"", "",
null, null,
"", "",
Visibilities.INTERNAL, Visibilities.DEFAULT_VISIBILITY,
Collections.<JetParameterInfo>emptyList(), Collections.<JetParameterInfo>emptyList(),
null, null,
method, method,
@@ -429,7 +429,7 @@ public class JetChangeSignatureDialog(
methodName, methodName,
returnType, returnType,
returnTypeText, returnTypeText,
visibility ?: Visibilities.INTERNAL, visibility ?: Visibilities.DEFAULT_VISIBILITY,
parameters, parameters,
parametersModel.getReceiver(), parametersModel.getReceiver(),
defaultValueContext) defaultValueContext)